* PATCH: PR plugins/56754 some missing plugin headers during installation in gcc 4.8
@ 2013-03-31 21:13 Magnus Granberg
2013-04-24 14:18 ` PING: " Jack Howarth
2013-05-21 15:09 ` Jakub Jelinek
0 siblings, 2 replies; 5+ messages in thread
From: Magnus Granberg @ 2013-03-31 21:13 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
This patch readd TARGET_H that was removed with revision 188166
IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that
did have TARGET_H before it was removed and it was not added to IPA_PROP_H or
PLUGIN_HEADERS. See the bug for more info.
/Magnus
gcc:
2013-03-30 Magnus Granberg <zorry@gentoo.org>
PR plugins/56754
* Makefile.in (PLUGIN_HEADERS): Add TARGET_H
[-- Attachment #2: gcc48_add_target_h_plugins.patch --]
[-- Type: text/x-patch, Size: 577 bytes --]
--- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100
+++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100
@@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $
$(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
$(GIMPLE_PRETTY_PRINT_H) realmpfr.h \
- $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
+ $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
# generate the 'build fragment' b-header-vars
s-header-vars: Makefile
^ permalink raw reply [flat|nested] 5+ messages in thread
* PING: PATCH: PR plugins/56754 some missing plugin headers during installation in gcc 4.8
2013-03-31 21:13 PATCH: PR plugins/56754 some missing plugin headers during installation in gcc 4.8 Magnus Granberg
@ 2013-04-24 14:18 ` Jack Howarth
2013-05-21 15:09 ` Jakub Jelinek
1 sibling, 0 replies; 5+ messages in thread
From: Jack Howarth @ 2013-04-24 14:18 UTC (permalink / raw)
To: Magnus Granberg
Cc: gcc-patches, bonzini, dj, neroden, aoliva, Ralf.Wildenhues
Any chance of this patch getting a review and commit soon so that it
can go into gcc trunk and gcc-4_8-branch?
Jack
On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote:
> This patch readd TARGET_H that was removed with revision 188166
> IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that
> did have TARGET_H before it was removed and it was not added to IPA_PROP_H or
> PLUGIN_HEADERS. See the bug for more info.
>
> /Magnus
>
> gcc:
>
> 2013-03-30 Magnus Granberg <zorry@gentoo.org>
>
> PR plugins/56754
> * Makefile.in (PLUGIN_HEADERS): Add TARGET_H
>
>
> --- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100
> +++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100
> @@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $
> $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
> cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
> $(GIMPLE_PRETTY_PRINT_H) realmpfr.h \
> - $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
> + $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
>
> # generate the 'build fragment' b-header-vars
> s-header-vars: Makefile
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: PR plugins/56754 some missing plugin headers during installation in gcc 4.8
2013-03-31 21:13 PATCH: PR plugins/56754 some missing plugin headers during installation in gcc 4.8 Magnus Granberg
2013-04-24 14:18 ` PING: " Jack Howarth
@ 2013-05-21 15:09 ` Jakub Jelinek
2013-05-21 15:32 ` Jack Howarth
2013-05-21 16:26 ` Duncan Sands
1 sibling, 2 replies; 5+ messages in thread
From: Jakub Jelinek @ 2013-05-21 15:09 UTC (permalink / raw)
To: Magnus Granberg; +Cc: gcc-patches
On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote:
> This patch readd TARGET_H that was removed with revision 188166
> IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that
> did have TARGET_H before it was removed and it was not added to IPA_PROP_H or
> PLUGIN_HEADERS. See the bug for more info.
> 2013-03-30 Magnus Granberg <zorry@gentoo.org>
Two spaces before <, instead of just one.
>
> PR plugins/56754
> * Makefile.in (PLUGIN_HEADERS): Add TARGET_H
Missing dot at the end of line, plus it should be $(TARGET_H)
instead of TARGET_H.
Where has it been tested?
> --- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100
> +++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100
> @@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $
> $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
> cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
> $(GIMPLE_PRETTY_PRINT_H) realmpfr.h \
> - $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
> + $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
>
> # generate the 'build fragment' b-header-vars
> s-header-vars: Makefile
Jakub
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: PR plugins/56754 some missing plugin headers during installation in gcc 4.8
2013-05-21 15:09 ` Jakub Jelinek
@ 2013-05-21 15:32 ` Jack Howarth
2013-05-21 16:26 ` Duncan Sands
1 sibling, 0 replies; 5+ messages in thread
From: Jack Howarth @ 2013-05-21 15:32 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Magnus Granberg, gcc-patches
On Tue, May 21, 2013 at 05:09:14PM +0200, Jakub Jelinek wrote:
> On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote:
> > This patch readd TARGET_H that was removed with revision 188166
> > IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that
> > did have TARGET_H before it was removed and it was not added to IPA_PROP_H or
> > PLUGIN_HEADERS. See the bug for more info.
>
> > 2013-03-30 Magnus Granberg <zorry@gentoo.org>
>
> Two spaces before <, instead of just one.
> >
> > PR plugins/56754
> > * Makefile.in (PLUGIN_HEADERS): Add TARGET_H
>
> Missing dot at the end of line, plus it should be $(TARGET_H)
> instead of TARGET_H.
>
> Where has it been tested?
This has been tested on i386-apple-darwin10, x86_64-apple-darwin10, x86_64-apple-darwin11 and
x86_64-apple-darwin12. The resulting gcc 4.8.1svn builds have been used to build dragonegg trunk
against gcc 4.8.1svn on x86_64-apple-darwin12.
>
> > --- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100
> > +++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100
> > @@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $
> > $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
> > cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
> > $(GIMPLE_PRETTY_PRINT_H) realmpfr.h \
> > - $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
> > + $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
> >
> > # generate the 'build fragment' b-header-vars
> > s-header-vars: Makefile
>
>
> Jakub
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: PR plugins/56754 some missing plugin headers during installation in gcc 4.8
2013-05-21 15:09 ` Jakub Jelinek
2013-05-21 15:32 ` Jack Howarth
@ 2013-05-21 16:26 ` Duncan Sands
1 sibling, 0 replies; 5+ messages in thread
From: Duncan Sands @ 2013-05-21 16:26 UTC (permalink / raw)
To: gcc-patches
Hi Jakub, I actually committed this patch to mainline earlier today, as it is
trivial, enables my own plugin (dragonegg) to compile against gcc-4.8, and
according to the PR makes some other plugins work with gcc-4.8 too. I will
backport it to the gcc-4.8 branch if no-one objects. But maybe you are
objecting?
On 21/05/13 17:09, Jakub Jelinek wrote:
> On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote:
>> This patch readd TARGET_H that was removed with revision 188166
>> IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that
>> did have TARGET_H before it was removed and it was not added to IPA_PROP_H or
>> PLUGIN_HEADERS. See the bug for more info.
>
>> 2013-03-30 Magnus Granberg <zorry@gentoo.org>
>
> Two spaces before <, instead of just one.
I had corrected this one already in the version I committed.
>>
>> PR plugins/56754
>> * Makefile.in (PLUGIN_HEADERS): Add TARGET_H
>
> Missing dot at the end of line, plus it should be $(TARGET_H)
> instead of TARGET_H.
I missed these however. I will correct the changelog if you are otherwise
OK with the commit.
>
> Where has it been tested?
In addition to what Jack mentioned, x86-64 ubuntu 13.04.
Ciao, Duncan.
>
>> --- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100
>> +++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100
>> @@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $
>> $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
>> cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
>> $(GIMPLE_PRETTY_PRINT_H) realmpfr.h \
>> - $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
>> + $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
>>
>> # generate the 'build fragment' b-header-vars
>> s-header-vars: Makefile
>
>
> Jakub
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-21 16:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-31 21:13 PATCH: PR plugins/56754 some missing plugin headers during installation in gcc 4.8 Magnus Granberg
2013-04-24 14:18 ` PING: " Jack Howarth
2013-05-21 15:09 ` Jakub Jelinek
2013-05-21 15:32 ` Jack Howarth
2013-05-21 16:26 ` Duncan Sands
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).