* [PATCH version 2] rs6000, altivec-1-runnable.c update the, require-effective-target
@ 2024-06-21 16:15 Carl Love
2024-06-24 2:41 ` Kewen.Lin
0 siblings, 1 reply; 3+ messages in thread
From: Carl Love @ 2024-06-21 16:15 UTC (permalink / raw)
To: gcc-patches, bergner, Segher Boessenkool, Kewen.Lin, Carl Love
GCC maintainers:
version 2, update the dg options per the feedback. Retested the patch on Power 10 with no regressions.
This patch updates the dg options.
The patch has been tested on Power 10 with no regression failures.
Please let me know if this patch is acceptable for mainline. Thanks.
Carl
----------------------------------------------------------------------
rs6000, altivec-1-runnable.c update the require-effective-target
Update the dg test directives.
gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog:
* gcc.target/powerpc/altivec-1-runnable.c: Change the
require-effective-target for the test.
---
gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
index da8ebbc30ba..3f084c91798 100644
--- a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
+++ b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
@@ -1,6 +1,7 @@
-/* { dg-do compile { target powerpc*-*-* } } */
-/* { dg-require-effective-target powerpc_altivec_ok } */
-/* { dg-options "-maltivec" } */
+/* { dg-do run { target vmx_hw } } */
+/* { dg-do compile { target { ! vmx_hw } } } */
+/* { dg-options "-O2 -maltivec" } */
+/* { dg-require-effective-target powerpc_altivec } */
#include <altivec.h>
--
2.45.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH version 2] rs6000, altivec-1-runnable.c update the, require-effective-target
2024-06-21 16:15 [PATCH version 2] rs6000, altivec-1-runnable.c update the, require-effective-target Carl Love
@ 2024-06-24 2:41 ` Kewen.Lin
2024-06-24 18:55 ` Carl Love
0 siblings, 1 reply; 3+ messages in thread
From: Kewen.Lin @ 2024-06-24 2:41 UTC (permalink / raw)
To: Carl Love; +Cc: gcc-patches, bergner, Segher Boessenkool
Hi,
on 2024/6/22 00:15, Carl Love wrote:
> GCC maintainers:
>
> version 2, update the dg options per the feedback. Retested the patch on Power 10 with no regressions.
>
> This patch updates the dg options.
>
> The patch has been tested on Power 10 with no regression failures.
>
> Please let me know if this patch is acceptable for mainline. Thanks.
>
> Carl
>
> ----------------------------------------------------------------------
> rs6000, altivec-1-runnable.c update the require-effective-target
>
> Update the dg test directives.
>
> gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog:
> * gcc.target/powerpc/altivec-1-runnable.c: Change the
> require-effective-target for the test.
> ---
> gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
> index da8ebbc30ba..3f084c91798 100644
> --- a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
> +++ b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
> @@ -1,6 +1,7 @@
> -/* { dg-do compile { target powerpc*-*-* } } */
> -/* { dg-require-effective-target powerpc_altivec_ok } */
> -/* { dg-options "-maltivec" } */
> +/* { dg-do run { target vmx_hw } } */
> +/* { dg-do compile { target { ! vmx_hw } } } */
> +/* { dg-options "-O2 -maltivec" } */
> +/* { dg-require-effective-target powerpc_altivec } */
This one needs rebasing, "powerpc_altivec" has been adjusted on trunk.
BR,
Kewen
>
> #include <altivec.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH version 2] rs6000, altivec-1-runnable.c update the, require-effective-target
2024-06-24 2:41 ` Kewen.Lin
@ 2024-06-24 18:55 ` Carl Love
0 siblings, 0 replies; 3+ messages in thread
From: Carl Love @ 2024-06-24 18:55 UTC (permalink / raw)
To: Kewen.Lin; +Cc: gcc-patches, bergner, Segher Boessenkool
Kewen:
On 6/23/24 19:41, Kewen.Lin wrote:
> Hi,
>
> on 2024/6/22 00:15, Carl Love wrote:
>> GCC maintainers:
>>
>> version 2, update the dg options per the feedback. Retested the patch on Power 10 with no regressions.
>>
>> This patch updates the dg options.
>>
>> The patch has been tested on Power 10 with no regression failures.
>>
>> Please let me know if this patch is acceptable for mainline. Thanks.
>>
>> Carl
>>
>> ----------------------------------------------------------------------
>> rs6000, altivec-1-runnable.c update the require-effective-target
>>
>> Update the dg test directives.
>>
>> gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog:
>> * gcc.target/powerpc/altivec-1-runnable.c: Change the
>> require-effective-target for the test.
>> ---
>> gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
>> index da8ebbc30ba..3f084c91798 100644
>> --- a/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
>> +++ b/gcc/testsuite/gcc.target/powerpc/altivec-1-runnable.c
>> @@ -1,6 +1,7 @@
>> -/* { dg-do compile { target powerpc*-*-* } } */
>> -/* { dg-require-effective-target powerpc_altivec_ok } */
>> -/* { dg-options "-maltivec" } */
>> +/* { dg-do run { target vmx_hw } } */
>> +/* { dg-do compile { target { ! vmx_hw } } } */
>> +/* { dg-options "-O2 -maltivec" } */
>> +/* { dg-require-effective-target powerpc_altivec } */
>
> This one needs rebasing, "powerpc_altivec" has been adjusted on trunk.
Yes, this seems to be out of sync. I will rebase on the current upstream tree and re-post.
Carl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-25 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-21 16:15 [PATCH version 2] rs6000, altivec-1-runnable.c update the, require-effective-target Carl Love
2024-06-24 2:41 ` Kewen.Lin
2024-06-24 18:55 ` Carl Love
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).