From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id E8139384D998 for ; Mon, 21 Nov 2022 08:52:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E8139384D998 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x330.google.com with SMTP id p16so7949144wmc.3 for ; Mon, 21 Nov 2022 00:52:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5CTnq23OrvydfLx2Xu8ZxMoS2dhboMhcO389Kn85L1E=; b=fnZccCuCLCR9isB3T1zJNcKypCKQyve9xcmm8EyExEei8SUn436UonG3NEx/n2ztUO EbwzXkdyu0gk8c8Yml5RRSs8uqpZrsIIDPzqI2XnaV4yZ7AhB6kfBU0mXm1FfQf1e/Ex y7hF/Axd/ndyo9dbHe4cE64XJk+hna/7U1fvWEkGP0IdIziAYRe95Tk0Nueo8EYp+80K AnUEjRiEiHd7DNOPtLm6NUAC/HKt7vyaAIqXzot2FMDbJRDwIGg7SsPyOYHaQ8QHZbVF PBtB/SUGDKUzxaCY2U4i0zFP/L0CMYrDnFH9ggNRiZzSUzdkqmWMCv4Hz6acI24cOwD0 lfgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CTnq23OrvydfLx2Xu8ZxMoS2dhboMhcO389Kn85L1E=; b=jksio98lw9E2DH1livDEt34rcKCUH9N6N9I4y9M8iWvMfpmllnhm9SewPod3zsn0Si te9lyQqFMqnZSsbHAPYOim0V6wZmE7M6E2mp9sdPlM+J7xsvL7jg2AMH5NEnorRreTVz MyjSvJPDQK1bxYaiGyryfIEeOoOX9EhLmY231jF5Qukh7bb7tOY4EqFWvmOVgOKmw0B/ PTZqs1VaSTl83ZOUkLAZYg/kvXynn5K+zxNP936iPh0Eu/wOk+heGy1k+v/yLHamaBtt uZwAOTqfLhAI/41nBxClvUr1iuJ+WLzVTkUFdNXrC3m7aI0bqu5VOtzCRhsswvRYBGqD xxMg== X-Gm-Message-State: ANoB5plWKb4+2xDMXsXx7rWysHufaCDCGsgIUtJqYu6DEuUgLR4SZRNN aLvHBYWeuithf3Q6zQrSRAD5DQ== X-Google-Smtp-Source: AA0mqf7UyqacLd1ZmiTNDY6Z3cxI1zbAgxSY6u4wDSXbGa9PICJdaCrT3JpCqnxMQuyV5sQfbbf7tQ== X-Received: by 2002:a1c:c90f:0:b0:3c6:c1cc:e96f with SMTP id f15-20020a1cc90f000000b003c6c1cce96fmr15116712wmb.174.1669020730741; Mon, 21 Nov 2022 00:52:10 -0800 (PST) Received: from fomalhaut.localnet ([2a01:e0a:8d5:d990:e654:e8ff:fe8f:2ce6]) by smtp.gmail.com with ESMTPSA id o5-20020a05600c510500b003b4ff30e566sm26054235wms.3.2022.11.21.00.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 00:52:09 -0800 (PST) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Ramana Radhakrishnan Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] ARM: Make ARMv8-M attribute cmse_nonsecure_call work in Ada Date: Mon, 21 Nov 2022 09:51:08 +0100 Message-ID: <2656741.mvXUDI8C0e@fomalhaut> In-Reply-To: References: <3519176.R56niFO833@fomalhaut> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart12097643.O9o76ZdvQC" Content-Transfer-Encoding: 7Bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --nextPart12097643.O9o76ZdvQC Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" > Ok if no regressions, perhaps the test needs to be in the ada test suite ? Thanks. Sure, testcase added to gnat.dg like so: * gnat.dg/machine_attr2.ads, gnat.dg/machine_attr2.adb: New test. -- Eric Botcazou --nextPart12097643.O9o76ZdvQC Content-Disposition: attachment; filename="machine_attr2.ads" Content-Transfer-Encoding: 7Bit Content-Type: text/x-adasrc; charset="UTF-8"; name="machine_attr2.ads" package Machine_Attr2 is type Non_Secure is access procedure; pragma Machine_Attribute (Non_Secure, "cmse_nonsecure_call"); procedure Call (Proc : Non_Secure); end Machine_Attr2; --nextPart12097643.O9o76ZdvQC Content-Disposition: attachment; filename="machine_attr2.adb" Content-Transfer-Encoding: 7Bit Content-Type: text/x-adasrc; charset="UTF-8"; name="machine_attr2.adb" -- { dg-do compile { target arm*-*-* } } -- { dg-options "-mcpu=cortex-m33 -mcmse" } package body Machine_Attr2 is procedure Call (Proc : Non_Secure) is begin Proc.all; end; procedure Foo; -- { dg-warning "only applies to base type" } pragma Machine_Attribute (Foo, "cmse_nonsecure_call"); procedure Foo is null; end Machine_Attr2; --nextPart12097643.O9o76ZdvQC--