From: Eric Botcazou <botcazou@adacore.com>
To: Martin Jambor <mjambor@suse.cz>
Cc: gcc-patches@gcc.gnu.org, Jan Hubicka <hubicka@ucw.cz>,
Josef Melcr <melcrjos@fit.cvut.cz>
Subject: Re: [PATCH] ipa-cp: Fix constant dumping
Date: Thu, 14 Nov 2024 14:07:33 +0100 [thread overview]
Message-ID: <26643435.1r3eYUQgxm@fomalhaut> (raw)
In-Reply-To: <ri64j4a6kxj.fsf@virgil.suse.cz>
> unfortunately, in C++ it is not enough to verify that the source still
> builds with a function removed to conclude that the function is unused.
> After this patch, dumping of IPA-CP scalar constant lattices is broken
> because we attempt to print them with (what was) an
> print_ipcp_constant_value overload for polymorphic contexts which are
> constructible from trees, so the source compiles, but of course are not
> what we want.
Another misfeature of C++ indeed! Thanks for fixing the problem.
--
Eric Botcazou
prev parent reply other threads:[~2024-11-14 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 12:11 [PATCH] Handle addresses of more constants in IPA-CP Eric Botcazou
2023-11-11 18:32 ` Jeff Law
2024-11-14 12:48 ` [PATCH] ipa-cp: Fix constant dumping Martin Jambor
2024-11-14 13:07 ` Eric Botcazou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26643435.1r3eYUQgxm@fomalhaut \
--to=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=melcrjos@fit.cvut.cz \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).