From: Jonathan Yong <10walls@gmail.com>
To: "Jeff Law" <law@redhat.com>,
"Kai Tietz" <ktietz70@googlemail.com>,
"Martin Storsjö" <martin@martin.st>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2] libgcc: Expose the instruction pointer and stack pointer in SEH _Unwind_Backtrace
Date: Fri, 6 Nov 2020 06:44:50 +0000 [thread overview]
Message-ID: <26762b5f-f43f-195d-ea07-4a77e5e1081e@gmail.com> (raw)
In-Reply-To: <4d27dcc7-4f16-5659-34a3-2f0f3675ff93@redhat.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 774 bytes --]
On 11/6/20 3:27 AM, Jeff Law wrote:
>
> On 11/2/20 5:05 AM, Kai Tietz via Gcc-patches wrote:
>> Hello,
>>
>> as noone seems to be able to review this patch, I will do so, even if
>> this is no longer a task of mine.
>> The patch itself is reasonable and seems to fix a pending issue we
>> have on CFA support. I had already private discussion with Martin,
>> and I would have loved to see a test-case illustrating this fix. But
>> as Martin explained to me, there is no trivial testcase for this, so I
>> would approve that patch.
>
> Thanks Kai. I'll get the bits installed momentarily.
>
FYI I already pushed this recently to gcc master branch
bd6ecbe48ada79bb14cbb30ef8318495b5237790, but did not reply earlier.
Sorry about the confusion.
[-- Attachment #1.1.2: OpenPGP_0x713B5FE29C145D45_and_old_rev.asc --]
[-- Type: application/pgp-keys, Size: 8035 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2020-11-06 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 13:01 [PATCH] libgcc: Expose the current instruction " Martin Storsjö
2020-09-04 12:51 ` Martin Storsjö
2020-09-08 12:21 ` [PATCH v2] libgcc: Expose the instruction pointer and stack " Martin Storsjö
2020-11-02 12:05 ` Kai Tietz
2020-11-06 3:27 ` Jeff Law
2020-11-06 6:44 ` Jonathan Yong [this message]
2020-11-03 0:32 ` Jonathan Yong
2020-11-06 3:28 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26762b5f-f43f-195d-ea07-4a77e5e1081e@gmail.com \
--to=10walls@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ktietz70@googlemail.com \
--cc=law@redhat.com \
--cc=martin@martin.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).