From: Tobias Burnus <tobias@codesourcery.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [Patch] LTO: Force externally_visible for offload_vars/funcs (PR97179)
Date: Wed, 23 Sep 2020 17:47:14 +0200 [thread overview]
Message-ID: <26b07ad0-ba42-b2c6-2325-cad7360f8e2c@codesourcery.com> (raw)
In-Reply-To: <0e22d8c5-1008-cad4-c131-57ee3950a73a@codesourcery.com>
I think I screwed up with testing – it seem now as if does not work like
this, but I need to recheck.
Tobias
On 9/23/20 4:23 PM, Tobias Burnus wrote:
> On 9/23/20 3:10 PM, Richard Biener wrote:
>
>> On Wed, 23 Sep 2020, Richard Biener wrote:
>>> LTRANS usually makes the symbols hidden, not local.
> Could also be – whatever the 'nm' output means.
>>> So are you
>>> sure this isn't a target bug (hidden symbols not implemented
>>> but the host compiler obviously having checked that but assuming
>>> the target behaves the same as the host) or a linker bug?
>
> Unlikely, I assume the Linux x86-64 linker is rather well tested.
> As written this is the host – just the offloading symbol table is
> device specific.
>
>> See lto/lto-partition.c:promote_symbol btw.
>
> Thanks for the pointer; it pointed me to node->externally_visible,
> which does the trick :-)
>
> Thus, next try – which a patch I like much better!
>
> Tobias
>
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
next prev parent reply other threads:[~2020-09-23 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 12:53 [Patch] lto-wrapper.c: Use -flto-partition=none with offloading (PR97179) Tobias Burnus
2020-09-23 13:02 ` Jakub Jelinek
2020-09-23 13:09 ` Richard Biener
2020-09-23 13:10 ` Richard Biener
2020-09-23 14:23 ` [Patch] LTO: Force externally_visible for offload_vars/funcs (PR97179) (was: lto-wrapper.c: Use -flto-partition=none with offloading (PR97179)) Tobias Burnus
2020-09-23 15:47 ` Tobias Burnus [this message]
2020-09-23 21:29 ` [Patch] LTO: Force externally_visible for offload_vars/funcs (PR97179) Tobias Burnus
2020-09-24 7:03 ` Richard Biener
2020-09-24 7:47 ` Tobias Burnus
2020-09-24 8:03 ` Richard Biener
2020-09-24 9:41 ` Tobias Burnus
2020-09-24 9:49 ` Jakub Jelinek
2020-09-24 9:51 ` Richard Biener
2020-09-24 9:50 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26b07ad0-ba42-b2c6-2325-cad7360f8e2c@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).