From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 2BF0C3857C46 for ; Wed, 23 Sep 2020 15:47:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2BF0C3857C46 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: S7cO5cJCGVqsd+3XCou5OZD8njC/dmhIFJqbldgOP1fY1LScjsQLjJKDx829RHewy+aAbWZuyO EikYZ/begaBfpIuMZMh8+YAOwOf/dnfga0QNUaZx1boZR0054OA/SzkYQ0FtoSwYaYaxNcz7Ko qBoGsUgoPheL7XsZHMKGOX/hDk2TY3eGoc1wemOS2AZtfLfJZnNqHhTcVnqAMU+4Sa8ZW0BJMY Es9URGvLtS4702m4QVpNCpIREOE8ENcEAeIsngf3zoeMqWprPPOfsL8dCNR/eeCtFMkVxb8b8F RBY= X-IronPort-AV: E=Sophos;i="5.77,293,1596528000"; d="scan'208";a="53180812" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 23 Sep 2020 07:47:20 -0800 IronPort-SDR: Smox2Tc7khhzUsnNUfKVtSsFoQPMIJBrYcn44oQMJNX9HMIwDF1MxEYy68Jz6Sog/MozF6401y xaPVOrGQ/eww9twZNTRDs8MKHR2Y0CGu/dkLWAZ8/sXk8ZUFTyeU8l7Rp9YQnvmol2mJoHY0pL 37RR0CPg3JhWVw59bOaJxm1a5t1BDPhSMGCkwMeP9/xTjZ4plxGiZc9d7GUxim7BIG50bWSb1d EvIKFfvX9NafUQRfZTU9D2vhOD/nockISKYDE2hGf94Yn9pwRsY0meFdT6SeviaESWrDFwSH5b 4qs= Subject: Re: [Patch] LTO: Force externally_visible for offload_vars/funcs (PR97179) From: Tobias Burnus To: Richard Biener CC: gcc-patches , Jakub Jelinek References: <4250958d-f7bf-1a0a-31d2-63eff191b258@codesourcery.com> <0e22d8c5-1008-cad4-c131-57ee3950a73a@codesourcery.com> Message-ID: <26b07ad0-ba42-b2c6-2325-cad7360f8e2c@codesourcery.com> Date: Wed, 23 Sep 2020 17:47:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <0e22d8c5-1008-cad4-c131-57ee3950a73a@codesourcery.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 15:47:22 -0000 I think I screwed up with testing =E2=80=93 it seem now as if does not work= like this, but I need to recheck. Tobias On 9/23/20 4:23 PM, Tobias Burnus wrote: > On 9/23/20 3:10 PM, Richard Biener wrote: > >> On Wed, 23 Sep 2020, Richard Biener wrote: >>> LTRANS usually makes the symbols hidden, not local. > Could also be =E2=80=93 whatever the 'nm' output means. >>> So are you >>> sure this isn't a target bug (hidden symbols not implemented >>> but the host compiler obviously having checked that but assuming >>> the target behaves the same as the host) or a linker bug? > > Unlikely, I assume the Linux x86-64 linker is rather well tested. > As written this is the host =E2=80=93 just the offloading symbol table is > device specific. > >> See lto/lto-partition.c:promote_symbol btw. > > Thanks for the pointer; it pointed me to node->externally_visible, > which does the trick :-) > > Thus, next try =E2=80=93 which a patch I like much better! > > Tobias > ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstra=C3=9Fe 201, 80634 M=C3=BCnch= en / Germany Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas = Heurung, Alexander Walter