From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx.kolabnow.com (mx.kolabnow.com [212.103.80.155]) by sourceware.org (Postfix) with ESMTPS id BBF253858D33 for ; Sat, 6 Apr 2024 11:15:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BBF253858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lambda.is Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lambda.is ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BBF253858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.103.80.155 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712402113; cv=none; b=qnsU8K5fCIx0ZKv6xCQdP063LQvnlng8fhMlNQNzM20G4TuLS2fVkkwJLFE1XufcNPx+g9Zgzfbz8vgkepTPK9O/VUsXx/dUft4ZbOhvoO/+ePiKto/z9LLUzC9pxwhKusYQbttglZIvKzIqPvryd8ZGYMQ25riJloTSChk+4aA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712402113; c=relaxed/simple; bh=gxfvSSP7jUMPL4+e/ouXYdpf1CuSyZIafh7n6m3ZjBw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Mg0+3y5P1ASNtosYQOtlu8o/eNXboA4tn73ISatdwQI8XE3loZBrBc5EsWzDGzpMDvQWShrmQ7dj6mvkMvOGYQQhHCANBYPtE6oNPdQaNv71xkdATmYR37YvZQ2p588L6rFQcQBaEuWcvVNz2l8BXO28u/wqyU1U2E4+EX1TyOo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 62D7B2096DED; Sat, 6 Apr 2024 13:15:07 +0200 (CEST) Authentication-Results: ext-mx-out011.mykolab.com (amavis); dkim=pass (4096-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :mime-version:date:date:message-id:received:received:received; s=dkim20160331; t=1712402104; x=1714216505; bh=PeG8uzkdaZOs3yx2 5TNBStxTgGVac/kJFmbaz1J77Pg=; b=m2ehjofWwlSOuAPb9OWHoeMIVPKGe1Tw ZSSTSu1JihGSnPAs8O4SzI80XoBZbIz8fK5g6vKm8odYsR6Ycxr0uJPZWtuzrB8B q5IyIK6E4hMmk/O3M+aWrTgXg/cerpj4x2yWtTX+OdvZD2bimqk6S1J/eFfzuyXh iABwX/j152YD/xxlkokAvV/zpIcsEonXtSFCJNJAgB3RKX1jMhjkunri9lhP65ES Bj3AaUXmAoaohP+GcexFnV1YCOe66s4RsO1aHT2WRPDgitxJz/3pLX4QHIKKazyQ tSLV77t0Y4Etsq8eCXLDsnEdvA5zMuZXzZsqUuqaYM6ul6MG5dNh7RB888coGOH8 BYFz4YCxKcdTqYRuIu5WK7lKQXqGd8bDc08hd5iVjhVgVT8G0TuuPL/e2MGx7HlZ Bai3AkojO0f6pK8sXStzZWVKUeSTSyMVMz+t9TiGpeanjpVmxYOzmlIKqi7/P0N2 iRdBq2teLz6gcg/K2l7/yxp/Vk+hQhNAqu0oKPeSdeC6pKXF70QcqqFJ4lYX7UEQ P1raV3SV/GhCIdNTF+hWQUEmD9hmytEIm3TrXofVWKBRvbm4oSvIdXZvIkXItF3H GfWrzB3je6crWy3XlMRp/TsJWPvY6Y6j/TreqIpdzBkF3VBzOxvWgTlUbfrtbNnu n9dE0lXgYls= X-Virus-Scanned: amavis at mykolab.com X-Spam-Score: -0.999 X-Spam-Level: X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out011.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id VliHc8x04lXz; Sat, 6 Apr 2024 13:15:04 +0200 (CEST) Received: from int-mx009.mykolab.com (unknown [10.9.13.9]) by mx.kolabnow.com (Postfix) with ESMTPS id E64642096DCB; Sat, 6 Apr 2024 13:15:03 +0200 (CEST) Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx009.mykolab.com (Postfix) with ESMTPS id 2A57F20E33FA; Sat, 6 Apr 2024 13:15:03 +0200 (CEST) Message-ID: <26d42e56-5ac8-4a36-bcaf-72a41d6ba447@lambda.is> Date: Sat, 6 Apr 2024 13:15:00 +0200 MIME-Version: 1.0 Subject: Re: [PATCH 0/2] Condition coverage fixes To: Richard Biener Cc: gcc-patches@gcc.gnu.org, hjl.tools@gmail.com, hubicka@ucw.cz, ro@cebitec.uni-bielefeld.de References: <20240405195831.2728853-1-j@lambda.is> Content-Language: en-US From: =?UTF-8?Q?J=C3=B8rgen_Kvalsvik?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06/04/2024 07:50, Richard Biener wrote: > > >> Am 05.04.2024 um 21:59 schrieb Jørgen Kvalsvik : >> >> Hi, >> >> I propose these fixes for the current issues with the condition >> coverage. >> >> Rainer, I propose to simply delete the test with __sigsetjmp. I don't >> think it actually detects anything reasonable any more, I kept it around >> to prevent a regression. Since then I have built a lot of programs (with >> optimization enabled) and not really seen this problem. >> >> H.J., the problem you found with -O2 was really a problem of >> tree-inlining, which was actually caught earlier by Jan [1]. It probably >> warrants some more testing, but I could reproduce by tuning your test >> case to use always_inline and not -O2 and trigger the error. >> >> [1] https://gcc.gnu.org/pipermail/gcc-patches/2024-April/648785.html > > Ok Thanks, committed. I am wondering if the fn->cond_uids access should always be guarded (in tree-profile.cc) should always be guarded. Right now there is the assumption that if condition coverage is requested the will exist and be populated, but as this shows there may be other circumstances where this is not true. Or perhaps there should be a gcc_assert to (reliably) detect cases where the map is not constructed properly? Thanks, Jørgen > > Thanks, > Richard > > >> Thanks, >> Jørgen >> >> Jørgen Kvalsvik (2): >> Remove unecessary and broken MC/DC compile test >> Copy condition->expr map when inlining [PR114599] >> >> gcc/testsuite/gcc.misc-tests/gcov-19.c | 11 --------- >> gcc/testsuite/gcc.misc-tests/gcov-pr114599.c | 25 ++++++++++++++++++++ >> gcc/tree-inline.cc | 20 +++++++++++++++- >> 3 files changed, 44 insertions(+), 12 deletions(-) >> create mode 100644 gcc/testsuite/gcc.misc-tests/gcov-pr114599.c >> >> -- >> 2.30.2 >>