From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 0E178385E004 for ; Thu, 26 Mar 2020 09:46:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0E178385E004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8882BACA1; Thu, 26 Mar 2020 09:46:49 +0000 (UTC) Subject: Re: [stage1] [PATCH] Make target_clones resolver fn static if possible. To: Jakub Jelinek Cc: Richard Biener , GCC Patches , Alexander Monakov , Uros Bizjak , Jan Hubicka References: <3c501d14-8048-5e9e-4276-fe02e4937487@suse.cz> <20200326092320.GI2156@tucnak> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <26d61d9e-f0a9-3632-9994-301de74df4e6@suse.cz> Date: Thu, 26 Mar 2020 10:46:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200326092320.GI2156@tucnak> Content-Type: multipart/mixed; boundary="------------79EFB5924C631693EF23F7E3" Content-Language: en-US X-Spam-Status: No, score=-33.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2020 09:46:52 -0000 This is a multi-part message in MIME format. --------------79EFB5924C631693EF23F7E3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 3/26/20 10:23 AM, Jakub Jelinek wrote: > On Mon, Mar 23, 2020 at 04:09:52PM +0100, Martin Liška wrote: >> 2020-03-17 Martin Liska >> >> PR target/93274 PR lto/94271 >> * gcc.target/i386/pr81213-2.c: New test. >> * gcc.target/i386/pr81213.c: Add additional source. >> * gcc.dg/lto/pr94271_0.c: New test. >> * gcc.dg/lto/pr94271_1.c: New test. > > I've noticed this test now has UNRESOLVED cases: > +UNRESOLVED: gcc.target/i386/pr81213.c scan-assembler \\t.globl\\tfoo > +UNRESOLVED: gcc.target/i386/pr81213.c scan-assembler foo.resolver: > +UNRESOLVED: gcc.target/i386/pr81213.c scan-assembler foo\\\\, @gnu_indirect_function > > 1) shall the test start with PR ipa/81214 reference when it is PR ipa/81213 > test? Probably yes, note that the test is relevant also to ipa/81214. So I'll add both PRs references. > 2) the UNRESOLVED cases can be fixed e.g. through: > > --- gcc/testsuite/gcc.target/i386/pr81213.c.jj 2020-03-25 11:39:07.605865708 +0100 > +++ gcc/testsuite/gcc.target/i386/pr81213.c 2020-03-26 10:13:23.616527400 +0100 > @@ -1,6 +1,7 @@ > /* PR ipa/81214. */ > /* { dg-do run } */ > /* { dg-require-ifunc "" } */ > +/* { dg-options "-save-temps" } */ > /* { dg-additional-sources "pr81213-2.c" } */ > > int bar(); > > 3) but then one ends up with > FAIL: gcc.target/i386/pr81213.c scan-assembler \t.globl\tfoo The asm scan does not make sense now as it's a run-time test and we would see a linker error in case of 2 .globl foo symbols. I'm suggesting a patch. Martin > > Do you want to change that to scan-assembler-not now that you don't want to > make foo public, or something else? > >> --- a/gcc/testsuite/gcc.target/i386/pr81213.c >> +++ b/gcc/testsuite/gcc.target/i386/pr81213.c >> @@ -1,6 +1,9 @@ >> /* PR ipa/81214. */ >> -/* { dg-do compile } */ >> +/* { dg-do run } */ >> /* { dg-require-ifunc "" } */ >> +/* { dg-additional-sources "pr81213-2.c" } */ >> + >> +int bar(); >> >> __attribute__((target_clones("avx","arch=slm","arch=core-avx2","default"))) >> static int >> @@ -11,7 +14,7 @@ foo () >> >> int main() >> { >> - return foo(); >> + return foo() + bar(); >> } >> >> /* { dg-final { scan-assembler "\t.globl\tfoo" } } */ >> -- >> 2.25.1 >> > > Jakub > --------------79EFB5924C631693EF23F7E3 Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-UNRESOLVED-test-case.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-UNRESOLVED-test-case.patch" >From 6a5c17037c0a20bc687a0c08234928959f441971 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Thu, 26 Mar 2020 10:45:50 +0100 Subject: [PATCH] Fix UNRESOLVED test-case. gcc/testsuite/ChangeLog: 2020-03-26 Martin Liska * gcc.target/i386/pr81213.c: Do not scan assembler and add one missing PR entry. --- gcc/testsuite/gcc.target/i386/pr81213.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gcc/testsuite/gcc.target/i386/pr81213.c b/gcc/testsuite/gcc.target/i386/pr81213.c index 334838631d0..6194e9ecccd 100644 --- a/gcc/testsuite/gcc.target/i386/pr81213.c +++ b/gcc/testsuite/gcc.target/i386/pr81213.c @@ -1,3 +1,4 @@ +/* PR ipa/81213. */ /* PR ipa/81214. */ /* { dg-do run } */ /* { dg-require-ifunc "" } */ @@ -16,7 +17,3 @@ int main() { return foo() + bar(); } - -/* { dg-final { scan-assembler "\t.globl\tfoo" } } */ -/* { dg-final { scan-assembler "foo.resolver:" } } */ -/* { dg-final { scan-assembler "foo\\, @gnu_indirect_function" } } */ -- 2.25.1 --------------79EFB5924C631693EF23F7E3--