From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id CBBFD386D617 for ; Thu, 9 Nov 2023 08:28:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBBFD386D617 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CBBFD386D617 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699518485; cv=none; b=M1ncCDwROeqKJryT9Tp6/gCVkFBpXfuUn74LEyHi1F2MTpKNeiU0b7MUObsHzINj4/A3jys4F4AUInhObaRlfIukQNVUHoOQF7tJkl4TBwsXpZLrIYlP9iwpG2PVqnJOXwjHdMTP8AGUuXeIuqel6dG27xi0c/umESMOTJRESEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699518485; c=relaxed/simple; bh=zfvPnS2iV5le4RkTAMlb/XFYZ8eJIgoZhghngw6jDgg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=uFTYvyD8Hh4m0HNZO1Bmc8vLD5/5ouSxJ0nTafoqqws1hrB/5wotXvJzcu4A55mterb20AxqExqMJvsDtlPwb6xBFk9niZtm8MX1luLO1fr7v6JQGKyW3kwLlJbbfu0nszqGhTucpJ1WD56E8RSpjkgnAjmcijKDkPQkItmc6uM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A98I80D028901 for ; Thu, 9 Nov 2023 08:28:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=UpsMFoKj+Wep3mEFQwjp4zK9euDOU8nU9Jh3tRJztHI=; b=VGW+dblotIbC5dHxq6XyFE19VdNlFPlWKUIWDCtjhpT5y6YekG4Kz+ksrXYW1ARGMfoW S0cFmeB/TlvPYC92BgWtBIFLsQ2cGIsJ2M3F1QF16En6kTQlf93H0IKPgVoK8mGAdwr0 5mcGX86kJJnzTg6/8dYWJZOznLJ2Ng4XiUptVW1wT8uRLmhNWmTJ/rq7FA0MIqShLAgx SCXjyj3Kn8/HEBfYl12cXAn14dB04OpErRUhJ9llQ4R2r17FxzlIieW0jqI33TAMkXac FfhqtKlMiCEpQnKD5dK9Rj1C6o0VvBxvzdEj3swn18oVY5Hng2/ay6a/QJuJ0SiqQ7BZ Dg== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u8usp8bpx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 09 Nov 2023 08:28:02 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3A97xWMV019224 for ; Thu, 9 Nov 2023 08:28:01 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3u7w242jhj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 09 Nov 2023 08:28:01 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3A98RwvY16056936 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Nov 2023 08:27:58 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C703C2004E; Thu, 9 Nov 2023 08:27:58 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AED4020043; Thu, 9 Nov 2023 08:27:58 +0000 (GMT) Received: from [9.152.224.246] (unknown [9.152.224.246]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 9 Nov 2023 08:27:58 +0000 (GMT) Message-ID: <26db3cee-134a-8117-cba9-1de74f5033b0@linux.ibm.com> Date: Thu, 9 Nov 2023 09:27:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 3/3] s390: Revise vector reverse elements Content-Language: en-US To: Stefan Schulze Frielinghaus , gcc-patches@gcc.gnu.org References: <20231109082211.2505-1-stefansf@linux.ibm.com> <20231109082211.2505-3-stefansf@linux.ibm.com> From: Andreas Krebbel In-Reply-To: <20231109082211.2505-3-stefansf@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: nChFBUeV8IsElkdILUNcbPb7zXdJhpRu X-Proofpoint-ORIG-GUID: nChFBUeV8IsElkdILUNcbPb7zXdJhpRu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-09_07,2023-11-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=883 mlxscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311090068 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/9/23 09:22, Stefan Schulze Frielinghaus wrote: > Replace UNSPEC_VEC_ELTSWAP with a vec_select implementation. > > Furthermore, for a vector reverse elements operation between registers > of mode V8HI perform three rotates instead of a vperm operation since > the latter involves loading the permutation vector from the literal > pool. > > Prior z15, instead of > larl + vl + vl + vperm > prefer > vl + vpdi (+ verllg (+ verllf)) > for a load operation. > > Likewise, prior z15, instead of > larl + vl + vperm + vst > prefer > vpdi (+ verllg (+ verllf)) + vst > for a store operation. > > Bootstrapped and regtested on s390. Ok for mainline? > > gcc/ChangeLog: > > * config/s390/s390.md: Remove UNSPEC_VEC_ELTSWAP. > * config/s390/vector.md (eltswapv16qi): New expander. > (*eltswapv16qi): New insn and splitter. > (eltswapv8hi): New insn and splitter. > (eltswap): New insn and splitter for modes V_HW_4 as well > as V_HW_2. > * config/s390/vx-builtins.md (eltswap): Remove. > (*eltswapv16qi): Remove. > (*eltswap): Remove. > (*eltswap_emu): Remove. > > gcc/testsuite/ChangeLog: > > * gcc.target/s390/zvector/vec-reve-load-halfword-z14.c: Remove > vperm and substitude by vpdi et al. > * gcc.target/s390/zvector/vec-reve-load-halfword.c: Likewise. > * gcc.target/s390/vector/reverse-elements-1.c: New test. > * gcc.target/s390/vector/reverse-elements-2.c: New test. > * gcc.target/s390/vector/reverse-elements-3.c: New test. > * gcc.target/s390/vector/reverse-elements-4.c: New test. > * gcc.target/s390/vector/reverse-elements-5.c: New test. > * gcc.target/s390/vector/reverse-elements-6.c: New test. > * gcc.target/s390/vector/reverse-elements-7.c: New test. Ok, thanks! Andreas