From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id C643C3858D39 for ; Thu, 3 Mar 2022 08:38:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C643C3858D39 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2235rLDO029076; Thu, 3 Mar 2022 08:38:24 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3ejqx3jv23-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Mar 2022 08:38:24 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 2238cB9A015955; Thu, 3 Mar 2022 08:38:23 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 3ejqx3jv1n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Mar 2022 08:38:23 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2238Nd9i022695; Thu, 3 Mar 2022 08:38:21 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma04ams.nl.ibm.com with ESMTP id 3egbj1cag0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Mar 2022 08:38:21 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2238cJLM45613504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Mar 2022 08:38:19 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9EFFE5204F; Thu, 3 Mar 2022 08:38:19 +0000 (GMT) Received: from [9.197.239.43] (unknown [9.197.239.43]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 2124D5204E; Thu, 3 Mar 2022 08:38:17 +0000 (GMT) Content-Type: multipart/mixed; boundary="------------kyAOFTGdXKcQ3haulYzsGCD4" Message-ID: <26dce79a-be26-95b0-c14d-51852811969a@linux.ibm.com> Date: Thu, 3 Mar 2022 16:38:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: GCC Patches Cc: Segher Boessenkool , David Edelsohn , Peter Bergner From: "Kewen.Lin" Subject: [PATCH] rs6000: Adjust mov optabs for opaque modes [PR103353] X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: V-sOgvas3gLyl_Uy1pC55OZmZxINbSp3 X-Proofpoint-GUID: Z0jhrSeQolW3Im4kUiCrLxQDb0N4BeyM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-03_05,2022-02-26_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 clxscore=1015 mlxscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203030040 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2022 08:38:26 -0000 This is a multi-part message in MIME format. --------------kyAOFTGdXKcQ3haulYzsGCD4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, As PR103353 shows, we may want to continue to expand a MMA built-in function like a normal function, even if we have already emitted error messages about some missing required conditions. As shown in that PR, without one explicit mov optab on OOmode provided, it would call emit_move_insn recursively. So this patch is to allow the mov pattern to be generated when we are expanding to RTL and have seen errors even without MMA supported, it's expected that the generated pattern would not cause further ICEs as the compilation would stop soon after expanding. Bootstrapped and regtested on powerpc64-linux-gnu P8 and powerpc64le-linux-gnu P9 and P10. Is it ok for trunk? BR, Kewen ------ PR target/103353 gcc/ChangeLog: * config/rs6000/mma.md (define_expand movoo): Move TARGET_MMA condition check to preparation statements and add handlings for !TARGET_MMA. (define_expand movxo): Likewise. --------------kyAOFTGdXKcQ3haulYzsGCD4 Content-Type: text/plain; charset=UTF-8; name="pr103353.patch" Content-Disposition: attachment; filename="pr103353.patch" Content-Transfer-Encoding: base64 LS0tCiBnY2MvY29uZmlnL3JzNjAwMC9tbWEubWQgfCA0MiArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygr KSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nY2MvY29uZmlnL3JzNjAwMC9tbWEu bWQgYi9nY2MvY29uZmlnL3JzNjAwMC9tbWEubWQKaW5kZXggOTA3YzlkNmQ1MTYuLmY3NmE4 N2I0YTIxIDEwMDY0NAotLS0gYS9nY2MvY29uZmlnL3JzNjAwMC9tbWEubWQKKysrIGIvZ2Nj L2NvbmZpZy9yczYwMDAvbW1hLm1kCkBAIC0yNjgsMTAgKzI2OCwyNSBAQCAoZGVmaW5lX2lu dF9hdHRyIGF2dmk0aTRpNAlbKFVOU1BFQ19NTUFfUE1YVkk4R0VSNFBQCSJwbXh2aThnZXI0 cHAiKQogKGRlZmluZV9leHBhbmQgIm1vdm9vIgogICBbKHNldCAobWF0Y2hfb3BlcmFuZDpP TyAwICJub25pbW1lZGlhdGVfb3BlcmFuZCIpCiAJKG1hdGNoX29wZXJhbmQ6T08gMSAiaW5w dXRfb3BlcmFuZCIpKV0KLSAgIlRBUkdFVF9NTUEiCisgICIiCiB7Ci0gIHJzNjAwMF9lbWl0 X21vdmUgKG9wZXJhbmRzWzBdLCBvcGVyYW5kc1sxXSwgT09tb2RlKTsKLSAgRE9ORTsKKyAg aWYgKFRBUkdFVF9NTUEpIHsKKyAgICByczYwMDBfZW1pdF9tb3ZlIChvcGVyYW5kc1swXSwg b3BlcmFuZHNbMV0sIE9PbW9kZSk7CisgICAgRE9ORTsKKyAgfQorICAvKiBPcGFxdWUgbW9k ZXMgYXJlIG9ubHkgZXhwZWN0ZWQgdG8gYmUgYXZhaWxhYmxlIHdoZW4gTU1BIGlzIHN1cHBv cnRlZCwKKyAgICAgYnV0IFBSMTAzMzUzIHNob3dzIHdlIG1heSB3YW50IHRvIGNvbnRpbnVl IHRvIGV4cGFuZCBhIE1NQSBidWlsdC1pbgorICAgICBmdW5jdGlvbiBsaWtlIGEgbm9ybWFs IGZ1bmN0aW9uLCBldmVuIGlmIHdlIGhhdmUgYWxyZWFkeSBlbWl0dGVkCisgICAgIGVycm9y IG1lc3NhZ2VzIGFib3V0IHNvbWUgbWlzc2luZyByZXF1aXJlZCBjb25kaXRpb25zLgorICAg ICBBcyBzaG93biBpbiB0aGF0IFBSLCB3aXRob3V0IG9uZSBleHBsaWNpdCBtb3Ygb3B0YWIg b24gT09tb2RlIHByb3ZpZGVkLAorICAgICBpdCB3b3VsZCBjYWxsIGVtaXRfbW92ZV9pbnNu IHJlY3Vyc2l2ZWx5LiAgU28gd2UgYWxsb3cgdGhpcyBwYXR0ZXJuIHRvCisgICAgIGJlIGdl bmVyYXRlZCB3aGVuIHdlIGFyZSBleHBhbmRpbmcgdG8gUlRMIGFuZCBoYXZlIHNlZW4gZXJy b3JzLCBldmVuCisgICAgIHRob3VnaCB0aGVyZSBpcyBubyBNTUEgc3VwcG9ydC4gIEl0IHdv dWxkIG5vdCBjYXVzZSBmdXJ0aGVyIElDRXMgYXMKKyAgICAgdGhlIGNvbXBpbGF0aW9uIHdv dWxkIHN0b3Agc29vbiBhZnRlciBleHBhbmRpbmcuICAqLworICBlbHNlIGlmIChjdXJyZW50 bHlfZXhwYW5kaW5nX3RvX3J0bCAmJiBzZWVuX2Vycm9yICgpKQorICAgIDsKKyAgZWxzZQor ICAgIGdjY191bnJlYWNoYWJsZSAoKTsKIH0pCiAKIChkZWZpbmVfaW5zbl9hbmRfc3BsaXQg Iiptb3ZvbyIKQEAgLTMwMCwxMCArMzE1LDI1IEBAIChkZWZpbmVfaW5zbl9hbmRfc3BsaXQg Iiptb3ZvbyIKIChkZWZpbmVfZXhwYW5kICJtb3Z4byIKICAgWyhzZXQgKG1hdGNoX29wZXJh bmQ6WE8gMCAibm9uaW1tZWRpYXRlX29wZXJhbmQiKQogCShtYXRjaF9vcGVyYW5kOlhPIDEg ImlucHV0X29wZXJhbmQiKSldCi0gICJUQVJHRVRfTU1BIgorICAiIgogewotICByczYwMDBf ZW1pdF9tb3ZlIChvcGVyYW5kc1swXSwgb3BlcmFuZHNbMV0sIFhPbW9kZSk7Ci0gIERPTkU7 CisgIGlmIChUQVJHRVRfTU1BKSB7CisgICAgcnM2MDAwX2VtaXRfbW92ZSAob3BlcmFuZHNb MF0sIG9wZXJhbmRzWzFdLCBYT21vZGUpOworICAgIERPTkU7CisgIH0KKyAgLyogT3BhcXVl IG1vZGVzIGFyZSBvbmx5IGV4cGVjdGVkIHRvIGJlIGF2YWlsYWJsZSB3aGVuIE1NQSBpcyBz dXBwb3J0ZWQsCisgICAgIGJ1dCBQUjEwMzM1MyBzaG93cyB3ZSBtYXkgd2FudCB0byBjb250 aW51ZSB0byBleHBhbmQgYSBNTUEgYnVpbHQtaW4KKyAgICAgZnVuY3Rpb24gbGlrZSBhIG5v cm1hbCBmdW5jdGlvbiwgZXZlbiBpZiB3ZSBoYXZlIGFscmVhZHkgZW1pdHRlZAorICAgICBl cnJvciBtZXNzYWdlcyBhYm91dCBzb21lIG1pc3NpbmcgcmVxdWlyZWQgY29uZGl0aW9ucy4K KyAgICAgQXMgc2hvd24gaW4gdGhhdCBQUiwgd2l0aG91dCBvbmUgZXhwbGljaXQgbW92IG9w dGFiIG9uIE9PbW9kZSBwcm92aWRlZCwKKyAgICAgaXQgd291bGQgY2FsbCBlbWl0X21vdmVf aW5zbiByZWN1cnNpdmVseS4gIFNvIHdlIGFsbG93IHRoaXMgcGF0dGVybiB0bworICAgICBi ZSBnZW5lcmF0ZWQgd2hlbiB3ZSBhcmUgZXhwYW5kaW5nIHRvIFJUTCBhbmQgaGF2ZSBzZWVu IGVycm9ycywgZXZlbgorICAgICB0aG91Z2ggdGhlcmUgaXMgbm8gTU1BIHN1cHBvcnQuICBJ dCB3b3VsZCBub3QgY2F1c2UgZnVydGhlciBJQ0VzIGFzCisgICAgIHRoZSBjb21waWxhdGlv biB3b3VsZCBzdG9wIHNvb24gYWZ0ZXIgZXhwYW5kaW5nLiAgKi8KKyAgZWxzZSBpZiAoY3Vy cmVudGx5X2V4cGFuZGluZ190b19ydGwgJiYgc2Vlbl9lcnJvciAoKSkKKyAgICA7CisgIGVs c2UKKyAgICBnY2NfdW5yZWFjaGFibGUgKCk7CiB9KQogCiAoZGVmaW5lX2luc25fYW5kX3Nw bGl0ICIqbW92eG8iCi0tIAoyLjI1LjEKCg== --------------kyAOFTGdXKcQ3haulYzsGCD4--