public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [committed] Mark cr16 as keeping null pointer checks in target-supports.exp
@ 2019-04-23 15:04 Jeff Law
  0 siblings, 0 replies; only message in thread
From: Jeff Law @ 2019-04-23 15:04 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]


My tester showed a spurious regression with a recent patch on cr16.  In
reviewing the logs I saw unexpected results for the proposed changes to
isolate-2.c and isolate-4.c.

The cr16 turns off NULL pointer check elimination, but isn't listed as
doing so in target-supports.exp.  As a result we run the tests, but they
fail.

This patch adds cr16 to the list of targets that keep null pointer
checks and those tests are now skipped.

I'm installing this on the trunk momentarily.

Jeff

[-- Attachment #2: P --]
[-- Type: text/plain, Size: 599 bytes --]

	* lib/target-supports.exp
	(check_effective_target_keeps_null_pointer_checks): Add cr16.

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 0dc1e184f55..4bb7da283f1 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -559,7 +559,7 @@ proc check_effective_target_keeps_null_pointer_checks { } {
     if [target_info exists keeps_null_pointer_checks] {
       return 1
     }
-    if { [istarget msp430-*-*] } {
+    if { [istarget msp430-*-*] || [istarget cr16-*-*] } {
 	return 1;   
     }
     return 0

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-04-23 14:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 15:04 [committed] Mark cr16 as keeping null pointer checks in target-supports.exp Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).