From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-h1p-028596.sys.comcast.net (resqmta-h1p-028596.sys.comcast.net [IPv6:2001:558:fd02:2446::4]) by sourceware.org (Postfix) with ESMTPS id 9E37D3858D33 for ; Thu, 2 Mar 2023 18:10:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E37D3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=comcast.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=comcast.net Received: from resomta-h1p-028517.sys.comcast.net ([96.102.179.206]) by resqmta-h1p-028596.sys.comcast.net with ESMTP id Xn13pYUqKHdrfXnO4peOQO; Thu, 02 Mar 2023 18:10:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1677780640; bh=E5Nb5FkBf6STIRBIuP22PmQnb324L23RK0y21xs325Y=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To:Xfinity-Spam-Result; b=BOoF/4BHx/FmPsmHG/jbjHB2OTMNCJO9H/Dpbfx5wtSWQZEMXdBH/1qpM8VayoWzO EX2QnW+B/Wii5HGlgJXPBwVvFcGtnOmQFQelgqMqTS9c+en8UiltLck08rqU97W9FT /kM1nHgDJPJOAeV59Yu9n6T8dFcKSHb+8krFTEmOYdLcX4w1DuZ46zcR9LdjXMVhyo PlMcbAGCSt+B+ODjolt/vZXO72/MysKlzWqbERVtP38lDxIFE1Drfrxp1iBz50xYFh 3+9R0sMToAkAgYXEhDrSmz96rLEtDoA5ok30nedWYIhzBcuP6WPlcCMwkEWj9FfSAK N5UJtmVf9YmSw== Received: from smtpclient.apple ([IPv6:2601:640:4100:880:a859:e0d3:1276:c38d]) by resomta-h1p-028517.sys.comcast.net with ESMTPSA id XnNfpvVehVfFHXnNgpby4W; Thu, 02 Mar 2023 18:10:17 +0000 X-Xfinity-VMeta: sc=-100.00;st=legit Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: Ping: [PATCH] testsuite: Tweak gcc.dg/attr-aligned.c for CRIS From: Mike Stump In-Reply-To: <20230228015458.8F13F2042E@pchp3.se.axis.com> Date: Thu, 2 Mar 2023 10:10:14 -0800 Cc: gcc-patches@gcc.gnu.org, msebor@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <274CA012-AE99-496B-A54E-92E40A932EF8@comcast.net> References: <20230216200529.AC55F2042C@pchp3.se.axis.com> <20230228015458.8F13F2042E@pchp3.se.axis.com> To: Hans-Peter Nilsson X-Mailer: Apple Mail (2.3696.120.41.1.2) X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Feb 27, 2023, at 5:54 PM, Hans-Peter Nilsson via Gcc-patches = wrote: >=20 > Ping... Ok. >=20 >> From: Hans-Peter Nilsson >> Date: Thu, 16 Feb 2023 21:05:29 +0100 >=20 >> Asking for the lines outside the "#if __CRIS__" part. >> Ok to commit? >>=20 >> -- >8 -- >> tm.texi says for BIGGEST_ALIGNMENT (from which >> __BIGGEST_ALIGNMENT__ is derived): "Biggest alignment that >> any data type can require on this machine, in bits." >>=20 >> That is, using that value might be too strict for alignment >> of *functions* and CRIS requires at least 16-bit alignment >> for functions. But, one purpose of the test is to test that >> alignment can be set to a large but valid value, so pick >> 512, which has some use as a historically required alignment >> for certain I/O descriptors. >>=20 >> * gcc.dg/attr-aligned.c: Adjust comment for ALIGN_MAX_STATIC. >> (ALIGN_MAX_STATIC): Set to 512 for CRIS. >> --- >> gcc/testsuite/gcc.dg/attr-aligned.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >>=20 >> diff --git a/gcc/testsuite/gcc.dg/attr-aligned.c = b/gcc/testsuite/gcc.dg/attr-aligned.c >> index 887bdd0f3799..4f0c885dc812 100644 >> --- a/gcc/testsuite/gcc.dg/attr-aligned.c >> +++ b/gcc/testsuite/gcc.dg/attr-aligned.c >> @@ -18,6 +18,10 @@ >> # else >> # define ALIGN_MAX_STATIC ALIGN_MAX_HARD >> # endif >> +#elif __CRIS__ >> +/* __BIGGEST_ALIGNMENT__ doesn't cover functions (16 bits for CRIS). = */ >> +# define ALIGN_MAX_STATIC 512 >> +# define ALIGN_TOO_BIG_OFILE (ALIGN_MAX_HARD << 1) >> #elif pdp11 >> # define ALIGN_MAX_STATIC 2 >> /* Work around a pdp11 ICE (see PR target/87821). */ >> @@ -29,7 +33,9 @@ >> /* Is this processor- or operating-system specific? */ >> # define ALIGN_MAX_STATIC ALIGN_MAX_HARD >> #else >> - /* Guaranteed to be accepted regardless of the target. */ >> + /* Guaranteed to be accepted regardless of the target for = objects. >> + This might not be true for alignment of functions though, so >> + may need to be set to a target-specific value above. */ >> # define ALIGN_MAX_STATIC __BIGGEST_ALIGNMENT__ >> /* Guaranteed to be rejected regardless of the target. */ >> # define ALIGN_TOO_BIG_OFILE (ALIGN_MAX_HARD << 1) >> --=20 >> 2.30.2 >>=20