* [PATCH] LoongArch: Add prefetch instruction
@ 2022-09-25 11:25 Xi Ruoyao
2022-09-28 8:31 ` Lulu Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Xi Ruoyao @ 2022-09-25 11:25 UTC (permalink / raw)
To: gcc-patches; +Cc: Lulu Cheng, Wang Xuerui, Chenghua Xu, Xi Ruoyao
The test pr106397.c fails on LoongArch because we don't have defined
prefetch instruction. We can silence the test for LoongArch, but it's
not too difficult to add the prefetch instruction so add it now.
-- >8 --
gcc/ChangeLog:
* config/loongarch/constraints.md (ZD): New address constraint.
* config/loongarch/loongarch.md (prefetch): New insn.
---
gcc/config/loongarch/constraints.md | 6 ++++++
gcc/config/loongarch/loongarch.md | 14 ++++++++++++++
2 files changed, 20 insertions(+)
diff --git a/gcc/config/loongarch/constraints.md b/gcc/config/loongarch/constraints.md
index 43cb7b5f0f5..93da5970958 100644
--- a/gcc/config/loongarch/constraints.md
+++ b/gcc/config/loongarch/constraints.md
@@ -190,3 +190,9 @@ (define_memory_constraint "ZB"
The offset is zero"
(and (match_code "mem")
(match_test "REG_P (XEXP (op, 0))")))
+
+(define_address_constraint "ZD"
+ "An address operand whose address is formed by a base register and offset
+ that is suitable for use in instructions with the same addressing mode
+ as @code{preld}."
+ (match_test "loongarch_12bit_offset_address_p (op, mode)"))
diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
index 214b14bddd3..84c1bd1c0d6 100644
--- a/gcc/config/loongarch/loongarch.md
+++ b/gcc/config/loongarch/loongarch.md
@@ -2137,6 +2137,20 @@ (define_insn "loongarch_dbar"
""
"dbar\t%0")
+(define_insn "prefetch"
+ [(prefetch (match_operand 0 "address_operand" "ZD")
+ (match_operand 1 "const_uimm5_operand" "i")
+ (match_operand 2 "const_int_operand" "n"))]
+ ""
+{
+ switch (INTVAL (operands[1]))
+ {
+ case 0: return "preld\t0,%a0";
+ case 1: return "preld\t8,%a0";
+ default: gcc_unreachable ();
+ }
+})
+
\f
;; Privileged state instruction
--
2.37.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] LoongArch: Add prefetch instruction
2022-09-25 11:25 [PATCH] LoongArch: Add prefetch instruction Xi Ruoyao
@ 2022-09-28 8:31 ` Lulu Cheng
2022-09-28 8:41 ` Xi Ruoyao
0 siblings, 1 reply; 3+ messages in thread
From: Lulu Cheng @ 2022-09-28 8:31 UTC (permalink / raw)
To: Xi Ruoyao, gcc-patches; +Cc: Wang Xuerui, Chenghua Xu
Hi,
My colleague is testing the performance data of prefetch and prefetchx.
And will submit both supports together if there is no problem.
在 2022/9/25 下午7:25, Xi Ruoyao 写道:
> The test pr106397.c fails on LoongArch because we don't have defined
> prefetch instruction. We can silence the test for LoongArch, but it's
> not too difficult to add the prefetch instruction so add it now.
>
> -- >8 --
>
> gcc/ChangeLog:
>
> * config/loongarch/constraints.md (ZD): New address constraint.
> * config/loongarch/loongarch.md (prefetch): New insn.
> ---
> gcc/config/loongarch/constraints.md | 6 ++++++
> gcc/config/loongarch/loongarch.md | 14 ++++++++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/gcc/config/loongarch/constraints.md b/gcc/config/loongarch/constraints.md
> index 43cb7b5f0f5..93da5970958 100644
> --- a/gcc/config/loongarch/constraints.md
> +++ b/gcc/config/loongarch/constraints.md
> @@ -190,3 +190,9 @@ (define_memory_constraint "ZB"
> The offset is zero"
> (and (match_code "mem")
> (match_test "REG_P (XEXP (op, 0))")))
> +
> +(define_address_constraint "ZD"
> + "An address operand whose address is formed by a base register and offset
> + that is suitable for use in instructions with the same addressing mode
> + as @code{preld}."
> + (match_test "loongarch_12bit_offset_address_p (op, mode)"))
> diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md
> index 214b14bddd3..84c1bd1c0d6 100644
> --- a/gcc/config/loongarch/loongarch.md
> +++ b/gcc/config/loongarch/loongarch.md
> @@ -2137,6 +2137,20 @@ (define_insn "loongarch_dbar"
> ""
> "dbar\t%0")
>
> +(define_insn "prefetch"
> + [(prefetch (match_operand 0 "address_operand" "ZD")
> + (match_operand 1 "const_uimm5_operand" "i")
> + (match_operand 2 "const_int_operand" "n"))]
> + ""
> +{
> + switch (INTVAL (operands[1]))
> + {
> + case 0: return "preld\t0,%a0";
> + case 1: return "preld\t8,%a0";
> + default: gcc_unreachable ();
> + }
> +})
> +
> \f
>
> ;; Privileged state instruction
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] LoongArch: Add prefetch instruction
2022-09-28 8:31 ` Lulu Cheng
@ 2022-09-28 8:41 ` Xi Ruoyao
0 siblings, 0 replies; 3+ messages in thread
From: Xi Ruoyao @ 2022-09-28 8:41 UTC (permalink / raw)
To: Lulu Cheng, gcc-patches; +Cc: Wang Xuerui, Chenghua Xu
On Wed, 2022-09-28 at 16:31 +0800, Lulu Cheng wrote:
> Hi,
>
> My colleague is testing the performance data of prefetch and
> prefetchx.
>
> And will submit both supports together if there is no problem.
Ok, so mark this one as "superseded".
>
> 在 2022/9/25 下午7:25, Xi Ruoyao 写道:
> > The test pr106397.c fails on LoongArch because we don't have defined
> > prefetch instruction. We can silence the test for LoongArch, but
> > it's
> > not too difficult to add the prefetch instruction so add it now.
> >
> > -- >8 --
> >
> > gcc/ChangeLog:
> >
> > * config/loongarch/constraints.md (ZD): New address
> > constraint.
> > * config/loongarch/loongarch.md (prefetch): New insn.
> > ---
> > gcc/config/loongarch/constraints.md | 6 ++++++
> > gcc/config/loongarch/loongarch.md | 14 ++++++++++++++
> > 2 files changed, 20 insertions(+)
> >
> > diff --git a/gcc/config/loongarch/constraints.md
> > b/gcc/config/loongarch/constraints.md
> > index 43cb7b5f0f5..93da5970958 100644
> > --- a/gcc/config/loongarch/constraints.md
> > +++ b/gcc/config/loongarch/constraints.md
> > @@ -190,3 +190,9 @@ (define_memory_constraint "ZB"
> > The offset is zero"
> > (and (match_code "mem")
> > (match_test "REG_P (XEXP (op, 0))")))
> > +
> > +(define_address_constraint "ZD"
> > + "An address operand whose address is formed by a base register
> > and offset
> > + that is suitable for use in instructions with the same
> > addressing mode
> > + as @code{preld}."
> > + (match_test "loongarch_12bit_offset_address_p (op, mode)"))
> > diff --git a/gcc/config/loongarch/loongarch.md
> > b/gcc/config/loongarch/loongarch.md
> > index 214b14bddd3..84c1bd1c0d6 100644
> > --- a/gcc/config/loongarch/loongarch.md
> > +++ b/gcc/config/loongarch/loongarch.md
> > @@ -2137,6 +2137,20 @@ (define_insn "loongarch_dbar"
> > ""
> > "dbar\t%0")
> >
> > +(define_insn "prefetch"
> > + [(prefetch (match_operand 0 "address_operand" "ZD")
> > + (match_operand 1 "const_uimm5_operand" "i")
> > + (match_operand 2 "const_int_operand" "n"))]
> > + ""
> > +{
> > + switch (INTVAL (operands[1]))
> > + {
> > + case 0: return "preld\t0,%a0";
> > + case 1: return "preld\t8,%a0";
> > + default: gcc_unreachable ();
> > + }
> > +})
> > +
> > \f
> >
> > ;; Privileged state instruction
>
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-28 8:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-25 11:25 [PATCH] LoongArch: Add prefetch instruction Xi Ruoyao
2022-09-28 8:31 ` Lulu Cheng
2022-09-28 8:41 ` Xi Ruoyao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).