From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id 59E3B3858D20 for ; Wed, 5 Apr 2023 13:49:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59E3B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1034.google.com with SMTP id mp3-20020a17090b190300b0023fcc8ce113so39561192pjb.4 for ; Wed, 05 Apr 2023 06:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680702546; x=1683294546; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YuJuMutyA5b7z0FTIHkFg6Ay/HrnOQ6sjYKvu4BobfY=; b=ltJMHc3ZGQSDLfZsmylB4EbLv2bauWfBKOu8mXSZ5A6v/UQTcIAdaLDz65Rvf8DORf /C9k44O/Rxq9zXrBMVmZ6PYY//DZ8PD+ChWZNzEA3p0SsafknpQc4TnorE/wr0mVwoT+ Dvhiy1Nbbb5xCPtMl0oWsJYtMMHL+3RX9K3lpED9XjWGS95J6/lvVBoTWa5P9WaAnnca 4Ak4Dsdp6LURg2wkPhCT2gzQ+5R8t9F/EXOV4OZ2tDa16iXwYRl4gx+ET6jrMws8eJOp DD5ZrzVXg4wR3yBczXLcpn4IZ8pRf5Ip8uDD2MYjMT8mgOYutmeHgkVzh/tDdNIAAQp3 +0QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680702546; x=1683294546; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YuJuMutyA5b7z0FTIHkFg6Ay/HrnOQ6sjYKvu4BobfY=; b=6T8M0xeN8D2TrpO36QlRcNIZMkvKzNxucYpKm+mu/HzAtPvNij5MrcUft3XA11hu6D EY7n26IIG1lzRXQbHa4jpszxod9AhJ9PTe2/rIVECVhgkYu/Toh5Q9xEiI+BqwE0qJUM WlG3zGSqoj72vjZSbZj//ob60rUPfig+521vY2g/ZIM75XLsnqdxdM8K6endn7J2+Xvh 5+zhPQl5IkjcjPJa/hOrzQjZAx1qevqOADqPvNFCPCImA9TiBtiXSZGMaMOcZo7D8Am9 /EtncUYR7ZPi8kFw7QYXGbblZ9KB/gdkRbBqK3MxkfRMvAzDB6TFZhSUH/uK/AyHpsGv uB3Q== X-Gm-Message-State: AAQBX9dXtZTtR7WAtES7EpGYqK05UzxzVn4F06abavq8ajM8x8UeGP8i AI3mxYbeE67plUPU9Zdji1w= X-Google-Smtp-Source: AKy350YMCQHlgVnaWdWOG7xczbtDePW846su20SuRNgDaan3CtWrfl6hK8hH6h1ghMQ85gR7hjC40g== X-Received: by 2002:a17:902:f1c2:b0:1a1:b748:f33f with SMTP id e2-20020a170902f1c200b001a1b748f33fmr5011025plc.69.1680702546051; Wed, 05 Apr 2023 06:49:06 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id s16-20020a170902b19000b0019c93ee6902sm1070422plr.109.2023.04.05.06.49.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 06:49:05 -0700 (PDT) Message-ID: <27be39e6-3cbb-bd80-a058-652bf1f773fb@gmail.com> Date: Wed, 5 Apr 2023 07:49:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] RISC-V: Fix SEW64 of vrsub.vx runtime fail in RV32 system Content-Language: en-US To: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, palmer@dabbelt.com References: <20230403003855.113601-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20230403003855.113601-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/2/23 18:38, juzhe.zhong@rivai.ai wrote: > From: Ju-Zhe Zhong > > It's quite obvious that the order of vrsub SEW64 is wrong. > > gcc/ChangeLog: > > * config/riscv/vector.md: Fix incorrect operand order. > > gcc/testsuite/ChangeLog: > > * g++.target/riscv/rvv/base/bug-23.C: New test. Thanks. Installed. Note I still think we need to fix the formatting issues, but that's a larger change that we can tackle independently of the bugfix. jeff