From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117684 invoked by alias); 3 Nov 2015 18:05:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117672 invoked by uid 89); 3 Nov 2015 18:05:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 03 Nov 2015 18:05:43 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 4F489289EA2A; Tue, 3 Nov 2015 19:05:40 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o5fkvX83GWIQ; Tue, 3 Nov 2015 19:05:40 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 2EC35289EA25; Tue, 3 Nov 2015 19:05:40 +0100 (CET) From: Eric Botcazou To: Richard Earnshaw Cc: gcc-patches@gcc.gnu.org, Ramana Radhakrishnan Subject: Re: [ARM] Fix PR middle-end/65958 Date: Tue, 03 Nov 2015 18:05:00 -0000 Message-ID: <2805623.kLq2Weys6P@polaris> User-Agent: KMail/4.14.9 (Linux/3.16.7-29-desktop; KDE/4.14.9; x86_64; ; ) In-Reply-To: <5638F077.5050105@foss.arm.com> References: <1478566.ZKXszbaoG4@polaris> <9319219.YanzbaT3s8@polaris> <5638F077.5050105@foss.arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2015-11/txt/msg00261.txt.bz2 > Unless there really is common code between the two patches, this should > be separated out into two posts, one for ARM and one for AArch64. The ARM bits were approved by Ramana and installed right away. > Hmm, so if PROBE_INTERVAL != 4096 we barf! Yes, but that's not usual, ARM and SPARC have it too, 4096 happens to be the limit of reg+off addressing mode on several architectures. > While that's safe and probably right for Linux, on some OSes there might > be a minimum page size of 16k or even 64k. It would be nice if we could > support that. OK, but we cannot test anything at the moment. > Ug! Manifest constants should be moved to pre-defines. > PROBE_STACK_BASE_REG? OK. > > + > > + /* The following code uses indexed address calculation on FIRST. */ > > + gcc_assert ((first % 4096) == 0); > > where's 4096 come from? It's the same constraint as above: #if (PROBE_INTERVAL % 4096) != 0 #error Cannot use indexed address calculation for stack probing #endif to be able to use the 12-bit shifted immediate instructions. > More manifest constants. Yeah, consistency first. ;-) > This should be annotated with the sequence length. OK, thanks for the review, I'll adjust. -- Eric Botcazou