From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 5EC953947412 for ; Mon, 5 Dec 2022 18:31:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5EC953947412 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42e.google.com with SMTP id h28so12210342pfq.9 for ; Mon, 05 Dec 2022 10:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=djyAkwGuxrxd/Fpvvmqva/f/Oet00lEsrVCYu0mgrKA=; b=f2AZOvLi/2wMGh3tKg2qV7vEcveIpRrc4hvFplrHEPNe6Z7sBrNcSB2FRqGsZO8Mi4 HLrkJIAa7974Ob8gw+n0NH+BoWhJzEqGlXX8zujNVqVpirpTn9t0odejHU+P6KeuzzF2 Tm/G9BRAS0doA6guD83qBEKCbFeKa+oZG9AtBhgnKc3WUpwJjU0gp4NBfVd/VcSYBCE9 8GfOP5CWqe3IKUTvUDwVeWD4cvO2OTwaNwopCOaxWwMcRVjKsfeV9VUrkKQBskUDA6Mx QDgQmtH3d5cuPPOqXrKVzxDS+yZtBkYEmDOHHOTzh1hoobWCmmlbvL8neANKBoGKgsuV 7OFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=djyAkwGuxrxd/Fpvvmqva/f/Oet00lEsrVCYu0mgrKA=; b=P44xyCoof9AprUCZprQJw8xI4BiI+669ICgRaQPKckH0SbnrB3ophE7E1mebrxRcbE WT42oKdXuSMpYzRiMVsxi96wtTOegdCcZp9Ql+Km1gF1VU29YVbflXpVGTcMdj/tykgT M+sX9pi213oe1uYzMFyjD1coRogXhmkM2v0HyAi5nq6BvRTDeWfu68NyCuZzQ0gET0gu BqobYoeBJrjX9IpznZRheJ41zELfTDHFNz3UQ8wUKBo8LcMNkTvjUOBMbcZzS7CjYhgP 9w6e+qTtvJ/AulIrNBKyr639f++r8QpyuQ2KRwHKci61KMA0gdNVUz5G950UDyxaRH9G w9Xg== X-Gm-Message-State: ANoB5pnVLtICXOohLEziUkn9uifrp5IUZY8eoklqskrbMLD6Im3NGKJ5 PaXjVRJs52yjB0QVLAOhUac= X-Google-Smtp-Source: AA0mqf5NOxADYiAMCckaZQFzYb2OJxOe658IB6mV6SQlW1ZI2gL0TECcqdIzTgGdFV8QeakCl16W/g== X-Received: by 2002:a63:5c1e:0:b0:46e:96ba:494d with SMTP id q30-20020a635c1e000000b0046e96ba494dmr57629283pgb.404.1670265086202; Mon, 05 Dec 2022 10:31:26 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id c12-20020a170903234c00b00186748fe6ccsm1787011plh.214.2022.12.05.10.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 10:31:25 -0800 (PST) Message-ID: <281f6c2a-d2db-82ce-bb16-950564568b1f@gmail.com> Date: Mon, 5 Dec 2022 11:31:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] tree-optimization/107833 - invariant motion of uninit uses Content-Language: en-US To: Richard Biener , gcc-patches@gcc.gnu.org Cc: Jakub Jelinek References: <20221202143055.46CE813644@imap1.suse-dmz.suse.de> From: Jeff Law In-Reply-To: <20221202143055.46CE813644@imap1.suse-dmz.suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/2/22 07:30, Richard Biener via Gcc-patches wrote: > The following fixes a wrong-code bug caused by loop invariant motion > hoisting an expression using an uninitialized value outside of its > controlling condition causing IVOPTs to use that to rewrite a defined > value. PR107839 is a similar case involving a bogus uninit diagnostic. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > OK? > > Thanks, > Richard. > > PR tree-optimization/107833 > PR tree-optimization/107839 > * cfghooks.cc: Include tree.h. > * tree-ssa-loop-im.cc (movement_possibility): Wrap and > make stmts using any ssa_name_maybe_undef_p operand > to preserve execution. > (loop_invariant_motion_in_fun): Call mark_ssa_maybe_undefs > to init maybe-undefined status. > * tree-ssa-loop-ivopts.cc (ssa_name_maybe_undef_p, > ssa_name_set_maybe_undef, ssa_name_any_use_dominates_bb_p, > mark_ssa_maybe_undefs): Move ... > * tree-ssa.cc: ... here. > * tree-ssa.h (ssa_name_any_use_dominates_bb_p, > mark_ssa_maybe_undefs): Declare. > (ssa_name_maybe_undef_p, ssa_name_set_maybe_undef): Define. > > * gcc.dg/torture/pr107833.c: New testcase. > * gcc.dg/uninit-pr107839.c: Likewise. OK. Jeff