From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30013 invoked by alias); 19 Apr 2015 21:00:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30000 invoked by uid 89); 19 Apr 2015 21:00:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: nef2.ens.fr Received: from nef2.ens.fr (HELO nef2.ens.fr) (129.199.96.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Apr 2015 21:00:19 +0000 Received: from mailhost.lps.ens.fr (tournesol.lps.ens.fr [129.199.120.1]) by nef2.ens.fr (8.13.6/1.01.28121999) with ESMTP id t3JL0Gut075165 ; Sun, 19 Apr 2015 23:00:16 +0200 (CEST) X-Envelope-To: gcc-patches@gcc.gnu.org Received: from localhost (localhost [127.0.0.1]) by mailhost.lps.ens.fr (Postfix) with ESMTP id 7EE5F105; Sun, 19 Apr 2015 23:00:16 +0200 (CEST) Received: from mailhost.lps.ens.fr ([127.0.0.1]) by localhost (tournesol.lps.ens.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IAeTjQiLiZc0; Sun, 19 Apr 2015 23:00:16 +0200 (CEST) Received: from [192.168.1.11] (log78-1-82-242-47-10.fbx.proxad.net [82.242.47.10]) by mailhost.lps.ens.fr (Postfix) with ESMTPSA id 4756BF8; Sun, 19 Apr 2015 23:00:16 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: [PATCH, i386, Darwin RFT]: Remove reload_in_progress checks From: =?utf-8?Q?Dominique_d=27Humi=C3=A8res?= In-Reply-To: Date: Sun, 19 Apr 2015 21:00:00 -0000 Cc: "gcc-patches@gcc.gnu.org" , Vladimir Makarov Content-Transfer-Encoding: quoted-printable Message-Id: <2820B849-BA36-481B-9699-7CD78F632B59@lps.ens.fr> References: To: Uros Bizjak X-SW-Source: 2015-04/txt/msg00975.txt.bz2 With the patch bootstrapping x86_64-apple-darwin14 was broken due to a typo: ../../work/gcc/config/i386/i386.c: In function 'void ix86_expand_move(machi= ne_mode, rtx_def**)': ../../work/gcc/config/i386/i386.c:17296:32: error: expected ',' or ';' befo= re ')' token ? op0 : gen_reg_rtx (Pmode)); ^ After removing the extra right parenthesis, I am now at stage 2. Dominique > Le 19 avr. 2015 =C3=A0 20:35, Uros Bizjak a =C3=A9cri= t : >=20 > Hello! >=20 > Attached patch removes reload_in_progress checks for x86 (LRA enabled) > target. AFAICS, reload_in_progress is never set during the > compilation, a watchpoint on this variable didn't trigger for a couple > of complex compilations. >=20 > 2015-04-19 Uros Bizjak >=20 > * config/i386/i386.c (set_pic_reg_ever_live): Remove. > (legitimize_pic_address): Do not call set_pic_reg_ever_live. > (legitimize_tls_address): Ditto. > (ix86_expand_move): Ditto. > (ix86_expand_binary_operator): Remove reload_in_progress checks. > (ix86_expand_unary_operator): Ditto. > * config/i386/predicates.md (index_register_operand): Ditto. >=20 > Patch was bootstrapped on x86_64-linux-gnu and regression tested for > x86_64-linux-gnu, i686-linux-gnu with and w/o -fpic. >=20 > The patch also changes Darwin specific code that can't be tested > properly on linux. Instead of leaving a reload_in_progress_check > theere, I'd ask someone to bootstrap and regression test the patch on > Darwin target. >=20 > I'll wait for the Darwin regression test results (and possible > comments) before committing the patch. >=20 > Uros. >