From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C5B6F385841C for ; Thu, 9 Nov 2023 20:24:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C5B6F385841C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C5B6F385841C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699561500; cv=none; b=e+GJ4YIPC/q/apEIIbJLCeX1rfCuiyazE1W+bjANaD34L2Qe9/y41OsOIULOv9Que7cWD02pqnG+C1QCgZf3ccna90uXSTIM9BpDDx33G8F+gtfKT/GE11ODFcuposWJpt/sthrneXLBAAn2dVX6VNlOqtUHE5gX8ep3KGI4zL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699561500; c=relaxed/simple; bh=N6B7O8x4V1ejBxTMscq2/O2aeSHzykr0pJLwRctz2Ws=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=k/yeqcc+xBXkbDV9Hh1O7IctqwKUqoqZU+kWHHKD2rp+1E0tnwzpDPnfAAOfhuxvKYl5aYripdvUgG18TTudka1tz4orQ96z7UCc54EUq20h458wq6lcEhici2sThMT4FX4eM4FOy+fQp684fwYV7o6WlrCQLRbb37PlEzxHSK0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699561498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cG7Usw5ENDp/WwQ49+LXfl2O9wfRLX555mfKJi5Fb5A=; b=arMWoPLGdy1Rb+gkuOVtMSh4gnw0DU7/HrALLFUcl+ft5863XU3VJhTciGUPidnBsaMGmY 4fVPqbMob3Q4bmrPGvfdGY5mEg7M/KUHgQvkH84D4BDvz6cG/tMcEn8fEkf1R1XjqET/Jo ZJdpjj587BbPq4jswA+7Qs2rl9sBbuA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-2IppX8j6M9avVvN_mp5FTg-1; Thu, 09 Nov 2023 15:24:56 -0500 X-MC-Unique: 2IppX8j6M9avVvN_mp5FTg-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-77893b0a2cdso150329985a.2 for ; Thu, 09 Nov 2023 12:24:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699561495; x=1700166295; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cG7Usw5ENDp/WwQ49+LXfl2O9wfRLX555mfKJi5Fb5A=; b=eIWmn3QT8vg8fGKVwjjk0Tj75ZkYx6nt7gNApShvq+mMZSg5hROpMLd8vVjQTGRuTN T16XRmGY1dMc4dZlNq4qq1O9/fe1saGZMc2CVTGXB3BEA+i9aZkBHWRc5ezTDk3Y3Gqt iOyUwGhr8m1ngaDHYPBJ+WwRDHyUusRnLRa+C8QX/Kkh2EYdHyA+c9y/pWExeiDAulQa UqRKiZwmtyWHXEPRjqWS4qTUkO+6FARBORuZFjS96NupAV8JYJLcihtxWPNjLgppQk8q MShpq5/LUHG5MVvls2fdUtl2o+3WA904i8sLrbaAZcv3ky8qYE/VTdDyZmquOp7lCNLs TpSQ== X-Gm-Message-State: AOJu0YwGBdIomHj3rn/184Dn3HCsUPZuXaQtOjm0wkO/MJm8duY3Tvjc 7oKNhEasybvrPT6krHNffJVoUugs85NJfFlkGym1UyvygB4xesAAePc9ILScGfML2jKo8uMgGNm tZyTVsxj6ePpI+hy/dJUJaCgAwOL5 X-Received: by 2002:a05:620a:8783:b0:77b:be50:9cbe with SMTP id py3-20020a05620a878300b0077bbe509cbemr1700330qkn.57.1699561494846; Thu, 09 Nov 2023 12:24:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdJUbh1uM/r9qVbzTVwZ2wsF5GHjMPaW2VBkwJofGcE0g716qaw5VWjh67GvHEpKg6oYo+XA== X-Received: by 2002:a05:620a:8783:b0:77b:be50:9cbe with SMTP id py3-20020a05620a878300b0077bbe509cbemr1700317qkn.57.1699561494543; Thu, 09 Nov 2023 12:24:54 -0800 (PST) Received: from [192.168.1.88] (23-233-12-249.cpe.pppoe.ca. [23.233.12.249]) by smtp.gmail.com with ESMTPSA id tq3-20020a05620a3d0300b0077890c8896bsm160646qkn.134.2023.11.09.12.24.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 12:24:54 -0800 (PST) Message-ID: <2875be42-1bc8-695d-c314-2a28b4605a98@redhat.com> Date: Thu, 9 Nov 2023 15:24:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/7] ira/lra: Support subreg coalesce To: Lehua Ding , gcc-patches@gcc.gnu.org Cc: richard.sandiford@arm.com, juzhe.zhong@rivai.ai References: <20231108034740.834590-1-lehua.ding@rivai.ai> From: Vladimir Makarov In-Reply-To: <20231108034740.834590-1-lehua.ding@rivai.ai> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/7/23 22:47, Lehua Ding wrote: > > Lehua Ding (7): > ira: Refactor the handling of register conflicts to make it more > general > ira: Add live_subreg problem and apply to ira pass > ira: Support subreg live range track > ira: Support subreg copy > ira: Add all nregs >= 2 pseudos to tracke subreg list > lra: Apply live_subreg df_problem to lra pass > lra: Support subreg live range track and conflict detect > Thank you very much for addressing subreg RA.  It is a big work.  I wanted to address this long time ago but have no time to do this by myself. I tried to evaluate your patches on x86-64 (i7-9700k) release mode GCC.  I used -O3 for SPEC2017 compilation. Here are the results:                baseline baseline(+patches) specint2017:  8.51 vs 8.58 (+0.8%) specfp2017:   21.1 vs 21.1 (+0%) compile time: 2426.41s vs 2580.58s (+6.4%) Spec2017 average code size change: -0.07% Improving specint by 0.8% is impressive for me. Unfortunately, it is achieved by decreasing compilation speed by 6.4% (although on smaller benchmark I saw only 3% slowdown). I don't know how but we should mitigate this speed degradation.  May be we can find a hot spot in the new code (but I think it is not a linear search pointed by Richard Biener as the object vectors most probably contain 1-2 elements) and this code spot can be improved, or we could use this only for -O3/fast, or the code can be function or target dependent. I also find GCC consumes more memory with the patches. May be it can be improved too (although I am not sure about this). I'll start to review the patches on the next week.  I don't expect that I'll find something serious to reject the patches but again we should work on mitigation of the compilation speed problem.  We can fill a new PR for this and resolve the problem during the release cycle.