From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by sourceware.org (Postfix) with ESMTPS id 5670E3849ADA for ; Fri, 10 May 2024 22:41:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5670E3849ADA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5670E3849ADA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715380862; cv=none; b=wfNMh8UW32aM7MuqjR6aozrCdm4q2+wteiiQl/HP9ZanwHw/nIczv7BDBhqBYsD3zDeSzMa8xfO0jgsKr9bB2zNfAdIdnAmi9+4WZApKkZf4HMtwTEhkQuH4yHvNxmFhrUucMzDCsSZdviKFF7ZH9kDwxdiGxB2+3KkR7UoYG7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715380862; c=relaxed/simple; bh=sjB4Nb0YkiJe63E4Ly51Nmek9biifVqsmVCys3abDj4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DGlkvL1x5hx4Kv9tEeUl+GscnOJfqa9vN2krJBugN+oQ6lLlIISrHRH2MvQlz8sQ8PsXpUYH0J2odb4tOFHM3Am7L0wSsHSGZo/tYZZEAREYp4ZcWMrtDfKUY4PzUoBfKRglMDhHdfQBY0rEr9C+chUnJPHPzUagCC1YzSc4HAY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-23f5a31d948so1515310fac.0 for ; Fri, 10 May 2024 15:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715380860; x=1715985660; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NU29qyi9GqAzOps/mj3TCrJwkymuKEK+37k0gSR+24Q=; b=MqpNfbX6/fEmkZvbmjfXq6vuy0BaGD3PJsorVANR4ETAP0roSWcrB8sMNIGrFGax8t Yjv8ostxAoTqBJHP4TNSJkaEyrc60YKglsi9gmpQTuNDsR1Cn48qkCLt5+mq3hHLQFla Din/NHSA/iq57e6ehcbuxD5shEzbwRs9NXF7PQK+voayu8pRKRLrC5xN0dzh2ok9FhCF 6dWCvse37sSO4K0B2+texd/lnsSr5rhEFPH1PXYcnDn45rgW17jo63BBvlH09qOfEF8W 2i0QfeGgHuQFU/25FkcPVnBGXkecqOZEvvVfBLSDFb9MMEjJSdaI75WtAB8pVOJ2hscZ EZpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715380860; x=1715985660; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NU29qyi9GqAzOps/mj3TCrJwkymuKEK+37k0gSR+24Q=; b=SqFY+HnkejL7SufJtbs3MnlK4PiwlODK7fumd7Qi0a4phGJ+k9qnP2N/ZYZ6YbKM7Z iWzjMiTg8i+0rEy8Ar7FAlb2vkpxjNec0Jnlj8HOG5p4vpHVu9zqQxf8kcHwKwEqdVfI M87AVEtUBMghrZ516l1nRCT0lO8IoX4tFEFURpPHOAGEwXkQMUf+xrFXs7/1QdmkP1ng fXzPUJNCjVb5Pvxsd3sK67hamFn/IhIAWEkuoLpPd/D+ZTNFFVOeX1s0v9V12W1rdOdj 1i/53KyJZs2sa0BrttNF2HOQlDUiIG7q2z6kSUNg5rsU8b1jKin4VS4830ecf579WWXv tnvg== X-Forwarded-Encrypted: i=1; AJvYcCUCp+rSNhJDWxkxAAwLf0WpyoUG3Ofsv56GXkPecqxWmyoeBFFVqPW5/NLAsRLq5e/QATGW5cG4Io+hydlE5wiUMI7vM9FMIA== X-Gm-Message-State: AOJu0YzDy262JovUKcAIRGOzziUmxMF3COJORLUTq1cXgEhHKD6tLfjn q9gPOin51k5UUnhbvrgb3QUW5EUOdSKoubAm1XVDxNpcDCjx0kZD X-Google-Smtp-Source: AGHT+IF5duI3ZBWR20NTYtxwtPAgMRUUiTvRu+KX4JkFdlEM/xwEQ0/igruA7beqNlLixgHx0NzgRA== X-Received: by 2002:a05:6870:e38a:b0:23c:357f:c475 with SMTP id 586e51a60fabf-24172e2ebb3mr4372866fac.38.1715380860450; Fri, 10 May 2024 15:41:00 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-6f0eb32b6a6sm458542a34.8.2024.05.10.15.40.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 May 2024 15:41:00 -0700 (PDT) Message-ID: <28ac155d-757c-478a-bbee-e9d771fd7990@gmail.com> Date: Fri, 10 May 2024 16:40:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH 3/4] RISC-V: tune: Add setting for overlapping mem ops to tuning struct Content-Language: en-US To: =?UTF-8?Q?Christoph_M=C3=BCllner?= , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Vineet Gupta References: <20240508051756.3999080-1-christoph.muellner@vrull.eu> <20240508051756.3999080-4-christoph.muellner@vrull.eu> From: Jeff Law In-Reply-To: <20240508051756.3999080-4-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/7/24 11:17 PM, Christoph Müllner wrote: > This patch adds the field overlap_op_by_pieces to the struct > riscv_tune_param, which is used by the TARGET_OVERLAP_OP_BY_PIECES_P() > hook. This hook is used by the by-pieces infrastructure to decide > if overlapping memory accesses should be emitted. > > The new property is set to false in all tune structs except for > generic-ooo. > > The changes in the expansion can be seen in the adjustments of the > cpymem test cases. These tests also reveal a limitation in the > RISC-V cpymem expansion that prevents this optimization as only > by-pieces cpymem expansions emit overlapping memory accesses. > > gcc/ChangeLog: > > * config/riscv/riscv.cc (struct riscv_tune_param): New field > overlap_op_by_pieces. > (riscv_overlap_op_by_pieces): New function. > (TARGET_OVERLAP_OP_BY_PIECES_P): Connect to > riscv_overlap_op_by_pieces. I think these are redundant with the changes I installed earlier this week :-) > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/cpymem-32-ooo.c: Adjust for overlapping > access. > * gcc.target/riscv/cpymem-64-ooo.c: Likewise. OK once prereqs are in. jeff