Hi Martin: Thanks for your patch, I comment the questions below. > Hello. > I noticed this patch set which is kind of related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107364. > And I have a couple of questions: >1) I noticed you drop AVX and F16C features for the newly added "lujiazui". Why do you need it? > I would expect these features would be properly detected by cpuid? Yes, these features could be detected by cpuid, and in respect of functionality, these features are ok, but in respect of performance, these features need further improvement, so we decide to drop it now, and add these features back when performance meet our expectation. > 2) If you really need it, can you please test for me the attached patch? It should come up > with a new function. I have tested the patch, It's ok. > 3) Have question about: > else if (vendor == signature_CENTAUR_ebx && family < 0x07) > cpu_model->__cpu_vendor = VENDOR_CENTAUR; > else if (vendor == signature_SHANGHAI_ebx > || vendor == signature_CENTAUR_ebx) > Are there any signature_CENTAUR_ebx models with family == 0x7 ? > Similarly, are there any signature_SHANGHAI_ebx modes with family < 0x7 ? Yes, both cases exist in our products. > Thanks, > Martin BR Mayshao