From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 3DA72382F08B for ; Tue, 30 Aug 2022 14:52:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3DA72382F08B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,275,1654588800"; d="scan'208";a="82252962" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 30 Aug 2022 06:52:40 -0800 IronPort-SDR: A6u6+QVCT+b5czAIqvD+abRFpBzCT2I3ytgSKdv/nIp7HruyuDn7i28QacD6J1COhseuMaGS+X /MufEu9oaPPGWusRhRMlCiXLyMWxERTyunSrLa2kKgPa7/xd30YAjULGDTvHFE3Vj87FiyYz53 XV5oVZQFlw7ROqFFupk6pf5DtPtOUqFgijTl1mTRabFyJmPgZJ1jl3bku7tDnyb3Nu/2y8AjSI xTNSA0SzIWtpEgmbGK79BjKD9mXE/MKfEpi7MCIZvmFs3PDzew/2S9+0P6bDCQaG+lZj3aOSxM TGs= Content-Type: multipart/mixed; boundary="------------hX6NiAxVdRKaA30IkqjDusWL" Message-ID: <290f72ce-e997-0a8c-f11b-cd64edb0859c@codesourcery.com> Date: Tue, 30 Aug 2022 15:52:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 1/3] omp-simd-clone: Allow fixed-lane vectors To: Jakub Jelinek CC: References: Content-Language: en-GB From: Andrew Stubbs In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------hX6NiAxVdRKaA30IkqjDusWL Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 26/08/2022 12:04, Jakub Jelinek wrote: >> gcc/ChangeLog: >> >> * doc/tm.texi: Regenerate. >> * omp-simd-clone.cc (simd_clone_adjust_return_type): Allow zero >> vecsize. >> (simd_clone_adjust_argument_types): Likewise. >> * target.def (compute_vecsize_and_simdlen): Document the new >> vecsize_int and vecsize_float semantics. > > LGTM, except for a formatting nit. Here's what I pushed. Andrew --------------hX6NiAxVdRKaA30IkqjDusWL Content-Type: text/plain; charset="UTF-8"; name="220830-allow-fixed-lane-vectors.patch" Content-Disposition: attachment; filename="220830-allow-fixed-lane-vectors.patch" Content-Transfer-Encoding: base64 b21wLXNpbWQtY2xvbmU6IEFsbG93IGZpeGVkLWxhbmUgdmVjdG9ycwoKVGhlIHZlY3NpemVf aW50L3ZlY3NpemVfZmxvYXQgaGFzIGFuIGFzc3VtcHRpb24gdGhhdCBhbGwgYXJndW1lbnRz IHdpbGwgdXNlCnRoZSBzYW1lIGJpdHNpemUsIGFuZCB2YXJ5IHRoZSBudW1iZXIgb2YgbGFu ZXMgYWNjb3JkaW5nIHRvIHRoZSBlbGVtZW50IHNpemUsCmJ1dCB0aGlzIGlzIGluYXBwcm9w cmlhdGUgb24gdGFyZ2V0cyB3aGVyZSB0aGUgbnVtYmVyIG9mIGxhbmVzIGlzIGZpeGVkIGFu ZAp0aGUgYml0c2l6ZSB2YXJpZXMgKGkuZS4gYW1kZ2NuKS4KCldpdGggdGhpcyBjaGFuZ2Ug dGhlIHZlY3NpemUgY2FuIGJlIGxlZnQgemVybyBhbmQgdGhlIHZlY3Rvcml6YXRpb24gZmFj dG9yIHdpbGwKYmUgdGhlIHNhbWUgZm9yIGFsbCB0eXBlcy4KCmdjYy9DaGFuZ2VMb2c6CgoJ KiBkb2MvdG0udGV4aTogUmVnZW5lcmF0ZS4KCSogb21wLXNpbWQtY2xvbmUuY2MgKHNpbWRf Y2xvbmVfYWRqdXN0X3JldHVybl90eXBlKTogQWxsb3cgemVybwoJdmVjc2l6ZS4KCShzaW1k X2Nsb25lX2FkanVzdF9hcmd1bWVudF90eXBlcyk6IExpa2V3aXNlLgoJKiB0YXJnZXQuZGVm IChjb21wdXRlX3ZlY3NpemVfYW5kX3NpbWRsZW4pOiBEb2N1bWVudCB0aGUgbmV3Cgl2ZWNz aXplX2ludCBhbmQgdmVjc2l6ZV9mbG9hdCBzZW1hbnRpY3MuCgpkaWZmIC0tZ2l0IGEvZ2Nj L2RvYy90bS50ZXhpIGIvZ2NjL2RvYy90bS50ZXhpCmluZGV4IDkyYmRhMWE3ZTE0Li5jMzAw MWM2ZGVkOSAxMDA2NDQKLS0tIGEvZ2NjL2RvYy90bS50ZXhpCisrKyBiL2djYy9kb2MvdG0u dGV4aQpAQCAtNjI1Myw2ICs2MjUzLDkgQEAgc3RvcmVzLgogVGhpcyBob29rIHNob3VsZCBz ZXQgQHZhcnt2ZWNzaXplX21hbmdsZX0sIEB2YXJ7dmVjc2l6ZV9pbnR9LCBAdmFye3ZlY3Np emVfZmxvYXR9CiBmaWVsZHMgaW4gQHZhcntzaW1kX2Nsb25lfSBzdHJ1Y3R1cmUgcG9pbnRl ZCBieSBAdmFye2Nsb25lX2luZm99IGFyZ3VtZW50IGFuZCBhbHNvCiBAdmFye3NpbWRsZW59 IGZpZWxkIGlmIGl0IHdhcyBwcmV2aW91c2x5IDAuCitAdmFye3ZlY3NpemVfbWFuZ2xlfSBp cyBhIG1hcmtlciBmb3IgdGhlIGJhY2tlbmQgb25seS4gQHZhcnt2ZWNzaXplX2ludH0gYW5k CitAdmFye3ZlY3NpemVfZmxvYXR9IHNob3VsZCBiZSBsZWZ0IHplcm8gb24gdGFyZ2V0cyB3 aGVyZSB0aGUgbnVtYmVyIG9mIGxhbmVzIGlzCitub3QgZGV0ZXJtaW5lZCBieSB0aGUgYml0 c2l6ZSAoaW4gd2hpY2ggY2FzZSBAdmFye3NpbWRsZW59IGlzIGFsd2F5cyB1c2VkKS4KIFRo ZSBob29rIHNob3VsZCByZXR1cm4gMCBpZiBTSU1EIGNsb25lcyBzaG91bGRuJ3QgYmUgZW1p dHRlZCwKIG9yIG51bWJlciBvZiBAdmFye3ZlY3NpemVfbWFuZ2xlfSB2YXJpYW50cyB0aGF0 IHNob3VsZCBiZSBlbWl0dGVkLgogQGVuZCBkZWZ0eXBlZm4KZGlmZiAtLWdpdCBhL2djYy9v bXAtc2ltZC1jbG9uZS5jYyBiL2djYy9vbXAtc2ltZC1jbG9uZS5jYwppbmRleCA1OGJkNjhi MTI5Yi4uNjhlZTRjMmMzYjAgMTAwNjQ0Ci0tLSBhL2djYy9vbXAtc2ltZC1jbG9uZS5jYwor KysgYi9nY2Mvb21wLXNpbWQtY2xvbmUuY2MKQEAgLTUwNCw3ICs1MDQsMTAgQEAgc2ltZF9j bG9uZV9hZGp1c3RfcmV0dXJuX3R5cGUgKHN0cnVjdCBjZ3JhcGhfbm9kZSAqbm9kZSkKICAg ICB2ZWNsZW4gPSBub2RlLT5zaW1kY2xvbmUtPnZlY3NpemVfaW50OwogICBlbHNlCiAgICAg dmVjbGVuID0gbm9kZS0+c2ltZGNsb25lLT52ZWNzaXplX2Zsb2F0OwotICB2ZWNsZW4gPSBl eGFjdF9kaXYgKHZlY2xlbiwgR0VUX01PREVfQklUU0laRSAoU0NBTEFSX1RZUEVfTU9ERSAo dCkpKTsKKyAgaWYgKGtub3duX2VxICh2ZWNsZW4sIDApKQorICAgIHZlY2xlbiA9IG5vZGUt PnNpbWRjbG9uZS0+c2ltZGxlbjsKKyAgZWxzZQorICAgIHZlY2xlbiA9IGV4YWN0X2RpdiAo dmVjbGVuLCBHRVRfTU9ERV9CSVRTSVpFIChTQ0FMQVJfVFlQRV9NT0RFICh0KSkpOwogICBp ZiAobXVsdGlwbGVfcCAodmVjbGVuLCBub2RlLT5zaW1kY2xvbmUtPnNpbWRsZW4pKQogICAg IHZlY2xlbiA9IG5vZGUtPnNpbWRjbG9uZS0+c2ltZGxlbjsKICAgaWYgKFBPSU5URVJfVFlQ RV9QICh0KSkKQEAgLTYxOCw4ICs2MjEsMTIgQEAgc2ltZF9jbG9uZV9hZGp1c3RfYXJndW1l bnRfdHlwZXMgKHN0cnVjdCBjZ3JhcGhfbm9kZSAqbm9kZSkKIAkgICAgdmVjbGVuID0gc2Mt PnZlY3NpemVfaW50OwogCSAgZWxzZQogCSAgICB2ZWNsZW4gPSBzYy0+dmVjc2l6ZV9mbG9h dDsKLQkgIHZlY2xlbiA9IGV4YWN0X2RpdiAodmVjbGVuLAotCQkJICAgICAgR0VUX01PREVf QklUU0laRSAoU0NBTEFSX1RZUEVfTU9ERSAocGFybV90eXBlKSkpOworCSAgaWYgKGtub3du X2VxICh2ZWNsZW4sIDApKQorCSAgICB2ZWNsZW4gPSBzYy0+c2ltZGxlbjsKKwkgIGVsc2UK KwkgICAgdmVjbGVuCisJICAgICAgPSBleGFjdF9kaXYgKHZlY2xlbiwKKwkJCSAgIEdFVF9N T0RFX0JJVFNJWkUgKFNDQUxBUl9UWVBFX01PREUgKHBhcm1fdHlwZSkpKTsKIAkgIGlmICht dWx0aXBsZV9wICh2ZWNsZW4sIHNjLT5zaW1kbGVuKSkKIAkgICAgdmVjbGVuID0gc2MtPnNp bWRsZW47CiAJICBhZGoub3AgPSBJUEFfUEFSQU1fT1BfTkVXOwpAQCAtNjY5LDggKzY3Niwx MSBAQCBzaW1kX2Nsb25lX2FkanVzdF9hcmd1bWVudF90eXBlcyAoc3RydWN0IGNncmFwaF9u b2RlICpub2RlKQogCXZlY2xlbiA9IHNjLT52ZWNzaXplX2ludDsKICAgICAgIGVsc2UKIAl2 ZWNsZW4gPSBzYy0+dmVjc2l6ZV9mbG9hdDsKLSAgICAgIHZlY2xlbiA9IGV4YWN0X2RpdiAo dmVjbGVuLAotCQkJICBHRVRfTU9ERV9CSVRTSVpFIChTQ0FMQVJfVFlQRV9NT0RFIChiYXNl X3R5cGUpKSk7CisgICAgICBpZiAoa25vd25fZXEgKHZlY2xlbiwgMCkpCisJdmVjbGVuID0g c2MtPnNpbWRsZW47CisgICAgICBlbHNlCisJdmVjbGVuID0gZXhhY3RfZGl2ICh2ZWNsZW4s CisJCQkgICAgR0VUX01PREVfQklUU0laRSAoU0NBTEFSX1RZUEVfTU9ERSAoYmFzZV90eXBl KSkpOwogICAgICAgaWYgKG11bHRpcGxlX3AgKHZlY2xlbiwgc2MtPnNpbWRsZW4pKQogCXZl Y2xlbiA9IHNjLT5zaW1kbGVuOwogICAgICAgaWYgKHNjLT5tYXNrX21vZGUgIT0gVk9JRG1v ZGUpCmRpZmYgLS1naXQgYS9nY2MvdGFyZ2V0LmRlZiBiL2djYy90YXJnZXQuZGVmCmluZGV4 IDJhN2ZhNjhmODNkLi40ZDQ5ZmZjMmM4OCAxMDA2NDQKLS0tIGEvZ2NjL3RhcmdldC5kZWYK KysrIGIvZ2NjL3RhcmdldC5kZWYKQEAgLTE2MjksNiArMTYyOSw5IEBAIERFRkhPT0sKICJU aGlzIGhvb2sgc2hvdWxkIHNldCBAdmFye3ZlY3NpemVfbWFuZ2xlfSwgQHZhcnt2ZWNzaXpl X2ludH0sIEB2YXJ7dmVjc2l6ZV9mbG9hdH1cblwKIGZpZWxkcyBpbiBAdmFye3NpbWRfY2xv bmV9IHN0cnVjdHVyZSBwb2ludGVkIGJ5IEB2YXJ7Y2xvbmVfaW5mb30gYXJndW1lbnQgYW5k IGFsc29cblwKIEB2YXJ7c2ltZGxlbn0gZmllbGQgaWYgaXQgd2FzIHByZXZpb3VzbHkgMC5c blwKK0B2YXJ7dmVjc2l6ZV9tYW5nbGV9IGlzIGEgbWFya2VyIGZvciB0aGUgYmFja2VuZCBv bmx5LiBAdmFye3ZlY3NpemVfaW50fSBhbmRcblwKK0B2YXJ7dmVjc2l6ZV9mbG9hdH0gc2hv dWxkIGJlIGxlZnQgemVybyBvbiB0YXJnZXRzIHdoZXJlIHRoZSBudW1iZXIgb2YgbGFuZXMg aXNcblwKK25vdCBkZXRlcm1pbmVkIGJ5IHRoZSBiaXRzaXplIChpbiB3aGljaCBjYXNlIEB2 YXJ7c2ltZGxlbn0gaXMgYWx3YXlzIHVzZWQpLlxuXAogVGhlIGhvb2sgc2hvdWxkIHJldHVy biAwIGlmIFNJTUQgY2xvbmVzIHNob3VsZG4ndCBiZSBlbWl0dGVkLFxuXAogb3IgbnVtYmVy IG9mIEB2YXJ7dmVjc2l6ZV9tYW5nbGV9IHZhcmlhbnRzIHRoYXQgc2hvdWxkIGJlIGVtaXR0 ZWQuIiwKIGludCwgKHN0cnVjdCBjZ3JhcGhfbm9kZSAqLCBzdHJ1Y3QgY2dyYXBoX3NpbWRf Y2xvbmUgKiwgdHJlZSwgaW50KSwgTlVMTCkK --------------hX6NiAxVdRKaA30IkqjDusWL--