From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by sourceware.org (Postfix) with ESMTPS id CCCA93851C39 for ; Wed, 24 Mar 2021 15:45:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CCCA93851C39 Received: by mail-qt1-x829.google.com with SMTP id u8so1725015qtq.12 for ; Wed, 24 Mar 2021 08:45:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Vy+XH/cuYN6/g/sSa7DJo9s3iJD62a20L8McI7pLY1A=; b=a1PQ4V8AneV4t/Vc4eqSlwVBAutD8vLfWN96xlZ62TynBVogVf5UFs3Q/gPBUGPSQ5 mIc/BF1O3j86gja7kSdKlU4UMsd3ciOpZdToqIKyziurfXVxxe86c2vRO+2cENJ+/xG4 SCXFT0UvOvwnKrEDjenhtlnL5XOypuNPAToENRIe/MpUtqr1VpBCyg0rEOdCIUeUgA5x ClJsUBNK1/SMvPmLqwfh5TQZnDMdgXfB/rMX7bsnqCw190jZbLxhnldveUcAACxCK2t+ z3yMe6lD+7PhhDS5e9w76TCiV95qe0BhbFjZd2iHN2hlVOys3Wu01lnKgRTZwK09erIY bpbg== X-Gm-Message-State: AOAM533E/y4FysnB2EHO3H7g+5EA8EL6fjO3LqIjCqrTOzYwDUiI0saW Sd0MppN5GfXBjr/RlYBAWrYnrDN2ucU= X-Google-Smtp-Source: ABdhPJyaVyypHqzw19m84gXqN6Z0vQa2pXSw+kjw3G+fH03Wz1XsQd3fxdDu01MyCmGZk/FVx7DQyw== X-Received: by 2002:ac8:4c87:: with SMTP id j7mr3616891qtv.338.1616600733172; Wed, 24 Mar 2021 08:45:33 -0700 (PDT) Received: from [192.168.0.41] (71-218-23-248.hlrn.qwest.net. [71.218.23.248]) by smtp.gmail.com with ESMTPSA id r35sm1666959qtd.95.2021.03.24.08.45.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 08:45:32 -0700 (PDT) Subject: Re: Patch ping To: Jakub Jelinek , Jason Merrill , Richard Biener Cc: gcc-patches@gcc.gnu.org References: <20210324114436.GH186063@tucnak> From: Martin Sebor Message-ID: <291474dd-6c23-3d74-1067-4d92b029ed2d@gmail.com> Date: Wed, 24 Mar 2021 09:45:31 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210324114436.GH186063@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 15:45:35 -0000 On 3/24/21 5:44 AM, Jakub Jelinek via Gcc-patches wrote: > Hi! > > I'd like to ping the > https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566821.html > P1 PR99565 fix. > > Marek has acked the gcc/c/ and gcc/c-family/ part of that patch, but it still > has gcc/cp/ and gcc/ parts that weren't acked. > If you have suggestions for better OEP_* flag name, I can change it. > Yes, as I said, I think changing it would be helpful. I already tried to make some these points in my comments on the patch but it might help to reiterate them. A good API name reflects the purpose of the API rather than one of its (conceivably many) use cases. By way of an example, when a new flag was needed to implement -Wduplicate-branches it wasn't called OEM_DUPLICATE_BRANCHES but OEM_LEXICOGRAPHIC. That was a good choice of a name because it's generic enough not to be surprising when used in other contexts. For the same reason, when an another flag is needed to refine the behavior of the function in a way that affects the same warning, it too should describe the effect of the flag on the function rather than just one possible use case. Since the new flag determines whether or not distinct members at the same offset are considered equal, a name that mentions MEMBER and OFFSET might be suitable. E.g., OEP_IGNORE_MEMBER_OFFSET or OEP_SAME_MEMBER_OFFSET (for the converse of the first) or something like that, but hopefully you get the idea. Martin