From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78249 invoked by alias); 6 May 2019 12:22:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 78233 invoked by uid 89); 6 May 2019 12:22:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 May 2019 12:22:52 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x46CIorx004235 for ; Mon, 6 May 2019 08:22:51 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2samges0xh-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 May 2019 08:22:50 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 May 2019 13:22:48 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 6 May 2019 13:22:45 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x46CMi7440370412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 May 2019 12:22:44 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ADF3BAE05D; Mon, 6 May 2019 12:22:44 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9007CAE058; Mon, 6 May 2019 12:22:42 +0000 (GMT) Received: from hljs-MacBook-Pro.local (unknown [9.200.36.2]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 6 May 2019 12:22:42 +0000 (GMT) Subject: Re: [PATCH] Fix a typo in two_value_replacement function To: Jakub Jelinek , Christophe Lyon Cc: gcc Patches , Segher Boessenkool , wschmidt@linux.ibm.com, Richard Biener References: <1557037872-47239-1-git-send-email-helijia@linux.ibm.com> <20190506113500.GV2706@tucnak> From: Li Jia He Date: Mon, 06 May 2019 12:22:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190506113500.GV2706@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit x-cbid: 19050612-0020-0000-0000-00000339CC8C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19050612-0021-0000-0000-0000218C6157 Message-Id: <2914a631-02e1-4c0d-c75b-67ce583a00f4@linux.ibm.com> X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00203.txt.bz2 On 2019/5/6 7:35 PM, Jakub Jelinek wrote: > On Mon, May 06, 2019 at 01:19:15PM +0200, Christophe Lyon wrote: >>> The regression testing for the patch was done on GCC mainline on >>> >>> powerpc64le-unknown-linux-gnu (Power 9 LE) >>> >>> with no regressions. Is it OK for trunk and backport to gcc 9 ? > > While the posted patch had: >>> +/* PR tree-optimization/88676 */ >>> +/* { dg-do compile } */ >>> +/* { dg-options "-O2 -fdump-tree-optimized" } */ >>> +/* { dg-final { scan-tree-dump-not " = PHI <" "optimized" } } */ > the actually committed patch has: > /* PR tree-optimization/88676 */ > /* { dg-do compile } */ > /* { dg-options "-O2 -fdump-tree-phiopt1" } */ > /* { dg-final { scan-tree-dump-not " = PHI <" "optimized" } } */ > > Dunno why this changed, if you want it in phiopt1, you need "phiopt1" > in scan-tree-dump-not as well, if you want optimized dump, you need > -fdump-tree-optimized instead. When I test the code again for submiting the code, I found that this change only affects the dump file generated by phiopt1, so I rashly decided to change the test option to dump-tree-phiopt1. If there is any code change in the future, I will send another patch. Sorry for the error caused by this. >> >> This new testcase fails on arm and aarch64: >> PASS: gcc.dg/tree-ssa/pr88676-2.c (test for excess errors) >> UNRESOLVED: gcc.dg/tree-ssa/pr88676-2.c scan-tree-dump-not optimized " = PHI <" >> because: >> gcc.dg/tree-ssa/pr88676-2.c: dump file does not exist >> >> Can you fix this? > > Jakub >