From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id D91BD3858405 for ; Fri, 29 Oct 2021 03:10:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D91BD3858405 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19T2kP9A000460; Fri, 29 Oct 2021 03:10:12 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com with ESMTP id 3c08ff8bas-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Oct 2021 03:10:11 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19T377q2032756; Fri, 29 Oct 2021 03:10:10 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma06ams.nl.ibm.com with ESMTP id 3bx4f1xqmq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Oct 2021 03:10:10 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19T3A7Qw4981392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Oct 2021 03:10:07 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 254254C05A; Fri, 29 Oct 2021 03:10:07 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E0FC64C040; Fri, 29 Oct 2021 03:10:05 +0000 (GMT) Received: from KewenLins-MacBook-Pro.local (unknown [9.197.232.137]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 29 Oct 2021 03:10:05 +0000 (GMT) Subject: Re: [PATCH] vect: Add bias parameter for partial vectorization To: Robin Dapp Cc: Richard Sandiford , GCC Patches References: <440687a0-d6e5-50e0-7105-7914b910c8c6@linux.ibm.com> From: "Kewen.Lin" Message-ID: <291b9671-8887-01e8-bddf-23840cdf6f84@linux.ibm.com> Date: Fri, 29 Oct 2021 11:10:03 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: <440687a0-d6e5-50e0-7105-7914b910c8c6@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: tW9ISYlvOHc2t5CPKknP1MV0F2IZyRHe X-Proofpoint-GUID: tW9ISYlvOHc2t5CPKknP1MV0F2IZyRHe Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-28_06,2021-10-26_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 mlxscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0 clxscore=1011 spamscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2110290017 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2021 03:10:16 -0000 Hi Robin, on 2021/10/28 下午10:44, Robin Dapp wrote: > Hi, > > as discussed in > https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582627.html this > introduces a bias parameter for the len_load/len_store ifns as well as > optabs that is meant to distinguish between Power and s390 variants. > The default is a bias of 0, while in s390's case vll/vstl do not support > lengths of zero bytes and a bias of -1 should be used. > > Bootstrapped and regtested on Power9 (--with-cpu=power9) and s390 > (--with-arch=z15). > > The tiny changes in the Power backend I will post separately. > Thanks for extending this! I guess your separated Power (rs6000) patch will be committed with this one together? otherwise I'm worried that those existing rs6000 partial vector cases could fail since the existing rs6000 optabs miss the new operand which isn't optional. You might need to update the documentation doc/md.texi for the new operand in sections len_load_@var{m} and len_store_@var{m}, and might want to add the costing consideration for this non-zero biasing in hunk " else if (LOOP_VINFO_FULLY_WITH_LENGTH_P (loop_vinfo)) { " of function vect_estimate_min_profitable_iters. I may think too much, it seems we can have one assertion in function vect_verify_loop_lens to ensure the (internal_len_load_bias_supported == internal_len_load_bias_supported) to avoid some mixed biasing cases from some weird targets or optab typos. BR, Kewen