From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3F3A23858C5F for ; Wed, 12 Jun 2024 09:34:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F3A23858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3F3A23858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718184894; cv=none; b=tPrTx9k59RimZvc1BYIjZh59YUIIBdFks9qzgtKKj9iYwnIWIcJsC+JTPsnFSR1pbB1mTCq7FCmJIN4Oh1de/0y6XVK64El1XxD06VdzkUYu4Kz3PGGuYQm6pnSr6WtZYWnbEvDXpqNKeVwsrFEFpWZhZSOJ31aQrk3jvnlyTtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718184894; c=relaxed/simple; bh=VGZTsOY8PrSA6YBC2Ny7IJgqQp3LOnIjKz8i0pRPCFw=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=hKNoTQAiXkJwcjLfOFqLA5fLtLZ6tsdi387wSjT4h58jmXpbLgKwvdV11A4NUu3+PLHCG+A3uZNTSxlxbPEi7dDzuhezC2TwBPLEF/q5LIAfMCw+mjbniuGszbHGEM+SaFMeABK128m93RRJLpLIzeGTR5Q8e34tv1ZJzsSjx30= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45C9TDHL008468; Wed, 12 Jun 2024 09:34:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s=pp1; bh= omB+XF1Fhc7uQDCu9/WEC4WXHWcl2BNgUHRyOyrPBRo=; b=VR3fCSmnTMlmr3b1 wc4Mi2Z7d8M/qnUBqFAmDpV4yoNY8xl7bvYN+YJlYkVOi2WHIeo7JfrLlMAYfGjt pj8sZyAvaymzmj9tWtE7HApXJLV9d8swigUBxbPMzibmDrA3q86jP0TCdlnAC0vm nDhdZ9JB6Qmqjepf64yGfEZ1wpxIbXdCKZr6pOquNME/dzwwFH9ks5ULCDb5rv73 sp6hgYGODfOEZKaUWH8OdaCWqOkEBy7+FdhSD1co4GVjdDfyv2CpwkkS5Du+zX5n bO8F/Vo1ZwR6Pue6SuzPKn3jYjK2fy04yztbk6mIfsPM/Jvwg17r7BM/lNUn4zJh D0Y2zQ== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yq92y80e1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Jun 2024 09:34:03 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45C8alCX023597; Wed, 12 Jun 2024 09:34:03 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3yn3umkxa1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Jun 2024 09:34:03 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45C9Xxnb15991196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2024 09:34:01 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 48F4B20040; Wed, 12 Jun 2024 09:33:59 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 271D42004B; Wed, 12 Jun 2024 09:33:58 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 12 Jun 2024 09:33:57 +0000 (GMT) Message-ID: <294171af-3ca1-44e0-8b77-d787eb612e7c@linux.ibm.com> Date: Wed, 12 Jun 2024 17:33:56 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 04/52] go: Replace uses of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE Content-Language: en-US To: gcc-patches@gcc.gnu.org Cc: ian@airs.com, Ian Lance Taylor References: <657e010ec8d3bb5d42adc765dbf384a60a3569f4.1717134752.git.linkw@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <657e010ec8d3bb5d42adc765dbf384a60a3569f4.1717134752.git.linkw@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UjkkS0s7yH-6yzEFkg7FaKUIk5ARfoE5 X-Proofpoint-ORIG-GUID: UjkkS0s7yH-6yzEFkg7FaKUIk5ARfoE5 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-12_05,2024-06-11_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1011 mlxlogscore=631 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406120067 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653387.html BR, Kewen on 2024/6/3 11:00, Kewen Lin wrote: > Joseph pointed out "floating types should have their mode, > not a poorly defined precision value" in the discussion[1], > as he and Richi suggested, the existing macros > {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE will be replaced with a > hook mode_for_floating_type. To be prepared for that, this > patch is to replace use of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE > in go with TYPE_PRECISION of {float,{,long_}double}_type_node. > > [1] https://gcc.gnu.org/pipermail/gcc-patches/2024-May/651209.html > > gcc/go/ChangeLog: > > * go-gcc.cc (Gcc_backend::float_type): Use TYPE_PRECISION of > {float,double,long_double}_type_node to replace > {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE. > (Gcc_backend::complex_type): Likewise. > --- > gcc/go/go-gcc.cc | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gcc/go/go-gcc.cc b/gcc/go/go-gcc.cc > index bc9732c3db3..6aa751f9f30 100644 > --- a/gcc/go/go-gcc.cc > +++ b/gcc/go/go-gcc.cc > @@ -993,11 +993,11 @@ Btype* > Gcc_backend::float_type(int bits) > { > tree type; > - if (bits == FLOAT_TYPE_SIZE) > + if (bits == TYPE_PRECISION (float_type_node)) > type = float_type_node; > - else if (bits == DOUBLE_TYPE_SIZE) > + else if (bits == TYPE_PRECISION (double_type_node)) > type = double_type_node; > - else if (bits == LONG_DOUBLE_TYPE_SIZE) > + else if (bits == TYPE_PRECISION (long_double_type_node)) > type = long_double_type_node; > else > { > @@ -1014,11 +1014,11 @@ Btype* > Gcc_backend::complex_type(int bits) > { > tree type; > - if (bits == FLOAT_TYPE_SIZE * 2) > + if (bits == TYPE_PRECISION (float_type_node) * 2) > type = complex_float_type_node; > - else if (bits == DOUBLE_TYPE_SIZE * 2) > + else if (bits == TYPE_PRECISION (double_type_node) * 2) > type = complex_double_type_node; > - else if (bits == LONG_DOUBLE_TYPE_SIZE * 2) > + else if (bits == TYPE_PRECISION (long_double_type_node) * 2) > type = complex_long_double_type_node; > else > {