* [Patch][Cilkplus branch] Adding include directory path to testsuite script
@ 2011-09-06 4:52 Iyer, Balaji V
2011-09-06 14:22 ` H.J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Iyer, Balaji V @ 2011-09-06 4:52 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
Hello Everyone,
This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
Thanking You,
Yours sincerely,
Balaji V. Iyer.
[-- Attachment #2: test_suite_patch.txt --]
[-- Type: text/plain, Size: 1088 bytes --]
diff --git a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
index 9f91b0c..8a9fdd4 100644
--- a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib g++-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] "-fsyntax-only -w -lcilkrts -ldl " " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] " -w -lcilkrts -ldl -I $srcdir/../../libcilkrts/include " " "
dg-finish
diff --git a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
index b228b65..dcf096e 100644
--- a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib gcc-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] "-fsyntax-only -lcilkrts -ldl -std=c99" " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] " -ldl -lcilkrts -I $srcdir/../../libcilkrts/include -std=c99 " " "
dg-finish
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 4:52 [Patch][Cilkplus branch] Adding include directory path to testsuite script Iyer, Balaji V
@ 2011-09-06 14:22 ` H.J. Lu
2011-09-06 14:31 ` Iyer, Balaji V
0 siblings, 1 reply; 12+ messages in thread
From: H.J. Lu @ 2011-09-06 14:22 UTC (permalink / raw)
To: Iyer, Balaji V; +Cc: gcc-patches
On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Hello Everyone,
> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>
> Thanking You,
>
ChangeLog entries are missing.
--
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 14:22 ` H.J. Lu
@ 2011-09-06 14:31 ` Iyer, Balaji V
2011-09-06 14:41 ` H.J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Iyer, Balaji V @ 2011-09-06 14:31 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
Sorry for the mistake.
Thanks,
Balaji V. Iyer.
-----Original Message-----
From: H.J. Lu [mailto:hjl.tools@gmail.com]
Sent: Tuesday, September 06, 2011 10:22 AM
To: Iyer, Balaji V
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Hello Everyone,
> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>
> Thanking You,
>
ChangeLog entries are missing.
--
H.J.
[-- Attachment #2: test_suite_patch.txt --]
[-- Type: text/plain, Size: 1787 bytes --]
diff --git a/gcc/testsuite/ChangeLog.cilk b/gcc/testsuite/ChangeLog.cilk
index a311052..cc2a973 100644
--- a/gcc/testsuite/ChangeLog.cilk
+++ b/gcc/testsuite/ChangeLog.cilk
@@ -1,3 +1,12 @@
+2011-09-05 Balaji V. Iyer. <balaji.v.iyer@intel.com>
+
+ * gcc.dg/cilk-plus/cilk_plus.exp: Added -I
+ $(src_dir)../../libcilkrts/include so that the compiler can find cilk.h
+ and cilk_api.h file correctly. Also removed -fsyntax-only
+ * g++.dg/cilk-plus/cilk_plus.exp: Added -I
+ $(src_dir)../../libcilkrts/include so that the compiler can find cilk.h
+ and cilk_api.h file correctly. Also removed -fsyntax-only
+
2011-08-15 Balaji V. Iyer. <balaji.v.iyer@intel.com>
diff --git a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
index 9f91b0c..8a9fdd4 100644
--- a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib g++-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] "-fsyntax-only -w -lcilkrts -ldl " " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] " -w -lcilkrts -ldl -I $srcdir/../../libcilkrts/include " " "
dg-finish
diff --git a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
index b228b65..dcf096e 100644
--- a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib gcc-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] "-fsyntax-only -lcilkrts -ldl -std=c99" " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] " -ldl -lcilkrts -I $srcdir/../../libcilkrts/include -std=c99 " " "
dg-finish
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 14:31 ` Iyer, Balaji V
@ 2011-09-06 14:41 ` H.J. Lu
2011-09-06 14:46 ` Iyer, Balaji V
0 siblings, 1 reply; 12+ messages in thread
From: H.J. Lu @ 2011-09-06 14:41 UTC (permalink / raw)
To: Iyer, Balaji V; +Cc: gcc-patches
On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
Please remove the extra blank line in ChangLog. ChangeLog
should simply say what you did, not why.
H.J.
----
> Sorry for the mistake.
>
> Thanks,
>
> Balaji V. Iyer.
>
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 10:22 AM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
>
> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>> Hello Everyone,
>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>
>> Thanking You,
>>
>
> ChangeLog entries are missing.
>
> --
> H.J.
>
--
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 14:41 ` H.J. Lu
@ 2011-09-06 14:46 ` Iyer, Balaji V
2011-09-06 14:57 ` H.J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Iyer, Balaji V @ 2011-09-06 14:46 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]
I fixed all the changed you have requested. Here is an updated patch.
Thanks,
Balaji V. Iyer.
-----Original Message-----
From: H.J. Lu [mailto:hjl.tools@gmail.com]
Sent: Tuesday, September 06, 2011 10:41 AM
To: Iyer, Balaji V
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
Please remove the extra blank line in ChangLog. ChangeLog should simply say what you did, not why.
H.J.
----
> Sorry for the mistake.
>
> Thanks,
>
> Balaji V. Iyer.
>
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 10:22 AM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to
> testsuite script
>
> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>> Hello Everyone,
>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>
>> Thanking You,
>>
>
> ChangeLog entries are missing.
>
> --
> H.J.
>
--
H.J.
[-- Attachment #2: test_suite_patch.txt --]
[-- Type: text/plain, Size: 1630 bytes --]
diff --git a/gcc/testsuite/ChangeLog.cilk b/gcc/testsuite/ChangeLog.cilk
index a311052..b018232 100644
--- a/gcc/testsuite/ChangeLog.cilk
+++ b/gcc/testsuite/ChangeLog.cilk
@@ -1,3 +1,9 @@
+2011-09-05 Balaji V. Iyer. <balaji.v.iyer@intel.com>
+
+ * gcc.dg/cilk-plus/cilk_plus.exp: Added -I
+ $(src_dir)../../libcilkrts/include. Also removed -fsyntax-only
+ * g++.dg/cilk-plus/cilk_plus.exp: Added -I
+ $(src_dir)../../libcilkrts/include. Also removed -fsyntax-only
2011-08-15 Balaji V. Iyer. <balaji.v.iyer@intel.com>
diff --git a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
index 9f91b0c..8a9fdd4 100644
--- a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib g++-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] "-fsyntax-only -w -lcilkrts -ldl " " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] " -w -lcilkrts -ldl -I $srcdir/../../libcilkrts/include " " "
dg-finish
diff --git a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
index b228b65..dcf096e 100644
--- a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib gcc-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] "-fsyntax-only -lcilkrts -ldl -std=c99" " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] " -ldl -lcilkrts -I $srcdir/../../libcilkrts/include -std=c99 " " "
dg-finish
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 14:46 ` Iyer, Balaji V
@ 2011-09-06 14:57 ` H.J. Lu
2011-09-06 15:03 ` Iyer, Balaji V
0 siblings, 1 reply; 12+ messages in thread
From: H.J. Lu @ 2011-09-06 14:57 UTC (permalink / raw)
To: Iyer, Balaji V; +Cc: gcc-patches
You should just say "* g++.dg/cilk-plus/cilk_plus.exp: Likewise" since
the change is the same as above.
H.J.
On Tue, Sep 6, 2011 at 7:45 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> I fixed all the changed you have requested. Here is an updated patch.
>
> Thanks,
>
> Balaji V. Iyer.
>
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 10:41 AM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
>
> On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
>
> Please remove the extra blank line in ChangLog. ChangeLog should simply say what you did, not why.
>
> H.J.
> ----
>> Sorry for the mistake.
>>
>> Thanks,
>>
>> Balaji V. Iyer.
>>
>>
>> -----Original Message-----
>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>> Sent: Tuesday, September 06, 2011 10:22 AM
>> To: Iyer, Balaji V
>> Cc: gcc-patches@gcc.gnu.org
>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to
>> testsuite script
>>
>> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>> Hello Everyone,
>>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>>
>>> Thanking You,
>>>
>>
>> ChangeLog entries are missing.
>>
>> --
>> H.J.
>>
>
>
>
> --
> H.J.
>
--
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 14:57 ` H.J. Lu
@ 2011-09-06 15:03 ` Iyer, Balaji V
2011-09-06 16:42 ` H.J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Iyer, Balaji V @ 2011-09-06 15:03 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]
Sure! Here is the fixed patch.
Thanks,
Balaji V. Iyer.
-----Original Message-----
From: H.J. Lu [mailto:hjl.tools@gmail.com]
Sent: Tuesday, September 06, 2011 10:57 AM
To: Iyer, Balaji V
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
You should just say "* g++.dg/cilk-plus/cilk_plus.exp: Likewise" since the change is the same as above.
H.J.
On Tue, Sep 6, 2011 at 7:45 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> I fixed all the changed you have requested. Here is an updated patch.
>
> Thanks,
>
> Balaji V. Iyer.
>
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 10:41 AM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to
> testsuite script
>
> On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
>
> Please remove the extra blank line in ChangLog. ChangeLog should simply say what you did, not why.
>
> H.J.
> ----
>> Sorry for the mistake.
>>
>> Thanks,
>>
>> Balaji V. Iyer.
>>
>>
>> -----Original Message-----
>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>> Sent: Tuesday, September 06, 2011 10:22 AM
>> To: Iyer, Balaji V
>> Cc: gcc-patches@gcc.gnu.org
>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>> to testsuite script
>>
>> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>> Hello Everyone,
>>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>>
>>> Thanking You,
>>>
>>
>> ChangeLog entries are missing.
>>
>> --
>> H.J.
>>
>
>
>
> --
> H.J.
>
--
H.J.
[-- Attachment #2: test_suite_patch.txt --]
[-- Type: text/plain, Size: 1563 bytes --]
diff --git a/gcc/testsuite/ChangeLog.cilk b/gcc/testsuite/ChangeLog.cilk
index a311052..a602b88 100644
--- a/gcc/testsuite/ChangeLog.cilk
+++ b/gcc/testsuite/ChangeLog.cilk
@@ -1,3 +1,8 @@
+2011-09-05 Balaji V. Iyer. <balaji.v.iyer@intel.com>
+
+ * gcc.dg/cilk-plus/cilk_plus.exp: Added -I
+ $(src_dir)../../libcilkrts/include. Also removed -fsyntax-only
+ * g++.dg/cilk-plus/cilk_plus.exp: Likewise
2011-08-15 Balaji V. Iyer. <balaji.v.iyer@intel.com>
diff --git a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
index 9f91b0c..8a9fdd4 100644
--- a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib g++-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] "-fsyntax-only -w -lcilkrts -ldl " " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] " -w -lcilkrts -ldl -I $srcdir/../../libcilkrts/include " " "
dg-finish
diff --git a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
index b228b65..dcf096e 100644
--- a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib gcc-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] "-fsyntax-only -lcilkrts -ldl -std=c99" " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] " -ldl -lcilkrts -I $srcdir/../../libcilkrts/include -std=c99 " " "
dg-finish
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 15:03 ` Iyer, Balaji V
@ 2011-09-06 16:42 ` H.J. Lu
[not found] ` <CAMe9rOogjm25uoBNUAmZUVYO57ccGEJu-hbp9WX+07Jv40aQiA@mail.gmail.com>
0 siblings, 1 reply; 12+ messages in thread
From: H.J. Lu @ 2011-09-06 16:42 UTC (permalink / raw)
To: Iyer, Balaji V; +Cc: gcc-patches
On Tue, Sep 6, 2011 at 8:01 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Sure! Here is the fixed patch.
It won't apply. Please make sure that it is against cilkplus branch.
H.J.
> Thanks,
>
> Balaji V. Iyer.
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 10:57 AM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
>
> You should just say "* g++.dg/cilk-plus/cilk_plus.exp: Likewise" since the change is the same as above.
>
> H.J.
> On Tue, Sep 6, 2011 at 7:45 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>> I fixed all the changed you have requested. Here is an updated patch.
>>
>> Thanks,
>>
>> Balaji V. Iyer.
>>
>>
>> -----Original Message-----
>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>> Sent: Tuesday, September 06, 2011 10:41 AM
>> To: Iyer, Balaji V
>> Cc: gcc-patches@gcc.gnu.org
>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to
>> testsuite script
>>
>> On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
>>
>> Please remove the extra blank line in ChangLog. ChangeLog should simply say what you did, not why.
>>
>> H.J.
>> ----
>>> Sorry for the mistake.
>>>
>>> Thanks,
>>>
>>> Balaji V. Iyer.
>>>
>>>
>>> -----Original Message-----
>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>> Sent: Tuesday, September 06, 2011 10:22 AM
>>> To: Iyer, Balaji V
>>> Cc: gcc-patches@gcc.gnu.org
>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>> to testsuite script
>>>
>>> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>> Hello Everyone,
>>>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>>>
>>>> Thanking You,
>>>>
>>>
>>> ChangeLog entries are missing.
>>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [Patch][Cilkplus branch] Adding include directory path to testsuite script
[not found] ` <CAMe9rOogjm25uoBNUAmZUVYO57ccGEJu-hbp9WX+07Jv40aQiA@mail.gmail.com>
@ 2011-09-06 17:35 ` Iyer, Balaji V
2011-09-06 17:39 ` H.J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Iyer, Balaji V @ 2011-09-06 17:35 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 2714 bytes --]
Ok..try it now.. I did git diff origin/cilkplus.
Thanks,
Balaji V. Iyer.
-----Original Message-----
From: H.J. Lu [mailto:hjl.tools@gmail.com]
Sent: Tuesday, September 06, 2011 12:37 PM
To: Iyer, Balaji V
Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
Please use "git diff origin/cilkplus" to generate patch.
On Tue, Sep 6, 2011 at 9:36 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Sep 6, 2011 at 8:01 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>> Sure! Here is the fixed patch.
>
> It won't apply. Please make sure that it is against cilkplus branch.
>
> H.J.
>> Thanks,
>>
>> Balaji V. Iyer.
>>
>> -----Original Message-----
>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>> Sent: Tuesday, September 06, 2011 10:57 AM
>> To: Iyer, Balaji V
>> Cc: gcc-patches@gcc.gnu.org
>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>> to testsuite script
>>
>> You should just say "* g++.dg/cilk-plus/cilk_plus.exp: Likewise" since the change is the same as above.
>>
>> H.J.
>> On Tue, Sep 6, 2011 at 7:45 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>> I fixed all the changed you have requested. Here is an updated patch.
>>>
>>> Thanks,
>>>
>>> Balaji V. Iyer.
>>>
>>>
>>> -----Original Message-----
>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>> Sent: Tuesday, September 06, 2011 10:41 AM
>>> To: Iyer, Balaji V
>>> Cc: gcc-patches@gcc.gnu.org
>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>> to testsuite script
>>>
>>> On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
>>>
>>> Please remove the extra blank line in ChangLog. ChangeLog should simply say what you did, not why.
>>>
>>> H.J.
>>> ----
>>>> Sorry for the mistake.
>>>>
>>>> Thanks,
>>>>
>>>> Balaji V. Iyer.
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>>> Sent: Tuesday, September 06, 2011 10:22 AM
>>>> To: Iyer, Balaji V
>>>> Cc: gcc-patches@gcc.gnu.org
>>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>>> to testsuite script
>>>>
>>>> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>>> Hello Everyone,
>>>>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>>>>
>>>>> Thanking You,
>>>>>
>>>>
>>>> ChangeLog entries are missing.
>>>>
>
--
H.J.
[-- Attachment #2: testsuite_patch.txt --]
[-- Type: text/plain, Size: 1601 bytes --]
diff --git a/gcc/testsuite/ChangeLog.cilk b/gcc/testsuite/ChangeLog.cilk
index c9eac87..a602b88 100644
--- a/gcc/testsuite/ChangeLog.cilk
+++ b/gcc/testsuite/ChangeLog.cilk
@@ -1,3 +1,9 @@
+2011-09-05 Balaji V. Iyer. <balaji.v.iyer@intel.com>
+
+ * gcc.dg/cilk-plus/cilk_plus.exp: Added -I
+ $(src_dir)../../libcilkrts/include. Also removed -fsyntax-only
+ * g++.dg/cilk-plus/cilk_plus.exp: Likewise
+
2011-08-15 Balaji V. Iyer. <balaji.v.iyer@intel.com>
* gcc.dg/cilk-plus/cilk-for.c: New
diff --git a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
index 9f91b0c..8a9fdd4 100644
--- a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib g++-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] "-fsyntax-only -w -lcilkrts -ldl " " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] " -w -lcilkrts -ldl -I $srcdir/../../libcilkrts/include " " "
dg-finish
diff --git a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
index b228b65..dcf096e 100644
--- a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib gcc-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] "-fsyntax-only -lcilkrts -ldl -std=c99" " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] " -ldl -lcilkrts -I $srcdir/../../libcilkrts/include -std=c99 " " "
dg-finish
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 17:35 ` Iyer, Balaji V
@ 2011-09-06 17:39 ` H.J. Lu
2011-09-06 17:46 ` Iyer, Balaji V
0 siblings, 1 reply; 12+ messages in thread
From: H.J. Lu @ 2011-09-06 17:39 UTC (permalink / raw)
To: Iyer, Balaji V; +Cc: gcc-patches
diff --git a/gcc/testsuite/ChangeLog.cilk b/gcc/testsuite/ChangeLog.cilk
index c9eac87..a602b88 100644
--- a/gcc/testsuite/ChangeLog.cilk
+++ b/gcc/testsuite/ChangeLog.cilk
@@ -1,3 +1,9 @@
+2011-09-05 Balaji V. Iyer. <balaji.v.iyer@intel.com>
^^^^^^ Your name should be
followed by 2 spaces, not a period.
+
+ * gcc.dg/cilk-plus/cilk_plus.exp: Added -I
+ $(src_dir)../../libcilkrts/include. Also removed -fsyntax-only
+ * g++.dg/cilk-plus/cilk_plus.exp: Likewise
+
On Tue, Sep 6, 2011 at 10:22 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Ok..try it now.. I did git diff origin/cilkplus.
>
> Thanks,
>
> Balaji V. Iyer.
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 12:37 PM
> To: Iyer, Balaji V
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
>
> Please use "git diff origin/cilkplus" to generate patch.
>
> On Tue, Sep 6, 2011 at 9:36 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Sep 6, 2011 at 8:01 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>> Sure! Here is the fixed patch.
>>
>> It won't apply. Please make sure that it is against cilkplus branch.
>>
>> H.J.
>>> Thanks,
>>>
>>> Balaji V. Iyer.
>>>
>>> -----Original Message-----
>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>> Sent: Tuesday, September 06, 2011 10:57 AM
>>> To: Iyer, Balaji V
>>> Cc: gcc-patches@gcc.gnu.org
>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>> to testsuite script
>>>
>>> You should just say "* g++.dg/cilk-plus/cilk_plus.exp: Likewise" since the change is the same as above.
>>>
>>> H.J.
>>> On Tue, Sep 6, 2011 at 7:45 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>> I fixed all the changed you have requested. Here is an updated patch.
>>>>
>>>> Thanks,
>>>>
>>>> Balaji V. Iyer.
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>>> Sent: Tuesday, September 06, 2011 10:41 AM
>>>> To: Iyer, Balaji V
>>>> Cc: gcc-patches@gcc.gnu.org
>>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>>> to testsuite script
>>>>
>>>> On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>>> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
>>>>
>>>> Please remove the extra blank line in ChangLog. ChangeLog should simply say what you did, not why.
>>>>
>>>> H.J.
>>>> ----
>>>>> Sorry for the mistake.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Balaji V. Iyer.
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>>>> Sent: Tuesday, September 06, 2011 10:22 AM
>>>>> To: Iyer, Balaji V
>>>>> Cc: gcc-patches@gcc.gnu.org
>>>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>>>> to testsuite script
>>>>>
>>>>> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>>>> Hello Everyone,
>>>>>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>>>>>
>>>>>> Thanking You,
>>>>>>
>>>>>
>>>>> ChangeLog entries are missing.
>>>>>
>>
>
>
>
> --
> H.J.
>
--
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 17:39 ` H.J. Lu
@ 2011-09-06 17:46 ` Iyer, Balaji V
2011-09-06 18:09 ` H.J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Iyer, Balaji V @ 2011-09-06 17:46 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 3776 bytes --]
OK..fixed. Please try it now.
Thanks,
Balaji V. Iyer.
________________________________________
From: H.J. Lu [hjl.tools@gmail.com]
Sent: Tuesday, September 06, 2011 1:35 PM
To: Iyer, Balaji V
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
diff --git a/gcc/testsuite/ChangeLog.cilk b/gcc/testsuite/ChangeLog.cilk
index c9eac87..a602b88 100644
--- a/gcc/testsuite/ChangeLog.cilk
+++ b/gcc/testsuite/ChangeLog.cilk
@@ -1,3 +1,9 @@
+2011-09-05 Balaji V. Iyer. <balaji.v.iyer@intel.com>
^^^^^^ Your name should be
followed by 2 spaces, not a period.
+
+ * gcc.dg/cilk-plus/cilk_plus.exp: Added -I
+ $(src_dir)../../libcilkrts/include. Also removed -fsyntax-only
+ * g++.dg/cilk-plus/cilk_plus.exp: Likewise
+
On Tue, Sep 6, 2011 at 10:22 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Ok..try it now.. I did git diff origin/cilkplus.
>
> Thanks,
>
> Balaji V. Iyer.
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 12:37 PM
> To: Iyer, Balaji V
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
>
> Please use "git diff origin/cilkplus" to generate patch.
>
> On Tue, Sep 6, 2011 at 9:36 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Sep 6, 2011 at 8:01 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>> Sure! Here is the fixed patch.
>>
>> It won't apply. Please make sure that it is against cilkplus branch.
>>
>> H.J.
>>> Thanks,
>>>
>>> Balaji V. Iyer.
>>>
>>> -----Original Message-----
>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>> Sent: Tuesday, September 06, 2011 10:57 AM
>>> To: Iyer, Balaji V
>>> Cc: gcc-patches@gcc.gnu.org
>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>> to testsuite script
>>>
>>> You should just say "* g++.dg/cilk-plus/cilk_plus.exp: Likewise" since the change is the same as above.
>>>
>>> H.J.
>>> On Tue, Sep 6, 2011 at 7:45 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>> I fixed all the changed you have requested. Here is an updated patch.
>>>>
>>>> Thanks,
>>>>
>>>> Balaji V. Iyer.
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>>> Sent: Tuesday, September 06, 2011 10:41 AM
>>>> To: Iyer, Balaji V
>>>> Cc: gcc-patches@gcc.gnu.org
>>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>>> to testsuite script
>>>>
>>>> On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>>> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
>>>>
>>>> Please remove the extra blank line in ChangLog. ChangeLog should simply say what you did, not why.
>>>>
>>>> H.J.
>>>> ----
>>>>> Sorry for the mistake.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Balaji V. Iyer.
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>>>> Sent: Tuesday, September 06, 2011 10:22 AM
>>>>> To: Iyer, Balaji V
>>>>> Cc: gcc-patches@gcc.gnu.org
>>>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>>>> to testsuite script
>>>>>
>>>>> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>>>> Hello Everyone,
>>>>>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>>>>>
>>>>>> Thanking You,
>>>>>>
>>>>>
>>>>> ChangeLog entries are missing.
>>>>>
>>
>
>
>
> --
> H.J.
>
--
H.J.
[-- Attachment #2: testsuite_patch.txt --]
[-- Type: text/plain, Size: 1651 bytes --]
diff --git a/gcc/testsuite/ChangeLog.cilk b/gcc/testsuite/ChangeLog.cilk
index c9eac87..e45add2 100644
--- a/gcc/testsuite/ChangeLog.cilk
+++ b/gcc/testsuite/ChangeLog.cilk
@@ -1,4 +1,10 @@
-2011-08-15 Balaji V. Iyer. <balaji.v.iyer@intel.com>
+2011-09-05 Balaji V. Iyer <balaji.v.iyer@intel.com>
+
+ * gcc.dg/cilk-plus/cilk_plus.exp: Added -I
+ $(src_dir)../../libcilkrts/include. Also removed -fsyntax-only
+ * g++.dg/cilk-plus/cilk_plus.exp: Likewise
+
+2011-08-15 Balaji V. Iyer <balaji.v.iyer@intel.com>
* gcc.dg/cilk-plus/cilk-for.c: New
* gcc.dg/cilk-plus/fib.c: New
diff --git a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
index 9f91b0c..8a9fdd4 100644
--- a/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/g++.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib g++-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] "-fsyntax-only -w -lcilkrts -ldl " " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.cpp]] " -w -lcilkrts -ldl -I $srcdir/../../libcilkrts/include " " "
dg-finish
diff --git a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
index b228b65..dcf096e 100644
--- a/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
+++ b/gcc/testsuite/gcc.dg/cilk-plus/cilk_plus.exp
@@ -18,6 +18,6 @@
load_lib gcc-dg.exp
dg-init
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] "-fsyntax-only -lcilkrts -ldl -std=c99" " "
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] " -ldl -lcilkrts -I $srcdir/../../libcilkrts/include -std=c99 " " "
dg-finish
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
2011-09-06 17:46 ` Iyer, Balaji V
@ 2011-09-06 18:09 ` H.J. Lu
0 siblings, 0 replies; 12+ messages in thread
From: H.J. Lu @ 2011-09-06 18:09 UTC (permalink / raw)
To: Iyer, Balaji V; +Cc: gcc-patches
I checked it into cilkplus branch.
Thanks.
On Tue, Sep 6, 2011 at 10:38 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> OK..fixed. Please try it now.
>
> Thanks,
>
> Balaji V. Iyer.
> ________________________________________
> From: H.J. Lu [hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 1:35 PM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
>
> diff --git a/gcc/testsuite/ChangeLog.cilk b/gcc/testsuite/ChangeLog.cilk
> index c9eac87..a602b88 100644
> --- a/gcc/testsuite/ChangeLog.cilk
> +++ b/gcc/testsuite/ChangeLog.cilk
> @@ -1,3 +1,9 @@
> +2011-09-05 Balaji V. Iyer. <balaji.v.iyer@intel.com>
> ^^^^^^ Your name should be
> followed by 2 spaces, not a period.
>
> +
> + * gcc.dg/cilk-plus/cilk_plus.exp: Added -I
> + $(src_dir)../../libcilkrts/include. Also removed -fsyntax-only
> + * g++.dg/cilk-plus/cilk_plus.exp: Likewise
> +
>
>
> On Tue, Sep 6, 2011 at 10:22 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>> Ok..try it now.. I did git diff origin/cilkplus.
>>
>> Thanks,
>>
>> Balaji V. Iyer.
>>
>> -----Original Message-----
>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>> Sent: Tuesday, September 06, 2011 12:37 PM
>> To: Iyer, Balaji V
>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
>>
>> Please use "git diff origin/cilkplus" to generate patch.
>>
>> On Tue, Sep 6, 2011 at 9:36 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Tue, Sep 6, 2011 at 8:01 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>> Sure! Here is the fixed patch.
>>>
>>> It won't apply. Please make sure that it is against cilkplus branch.
>>>
>>> H.J.
>>>> Thanks,
>>>>
>>>> Balaji V. Iyer.
>>>>
>>>> -----Original Message-----
>>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>>> Sent: Tuesday, September 06, 2011 10:57 AM
>>>> To: Iyer, Balaji V
>>>> Cc: gcc-patches@gcc.gnu.org
>>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>>> to testsuite script
>>>>
>>>> You should just say "* g++.dg/cilk-plus/cilk_plus.exp: Likewise" since the change is the same as above.
>>>>
>>>> H.J.
>>>> On Tue, Sep 6, 2011 at 7:45 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>>> I fixed all the changed you have requested. Here is an updated patch.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Balaji V. Iyer.
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>>>> Sent: Tuesday, September 06, 2011 10:41 AM
>>>>> To: Iyer, Balaji V
>>>>> Cc: gcc-patches@gcc.gnu.org
>>>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>>>> to testsuite script
>>>>>
>>>>> On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>>>> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
>>>>>
>>>>> Please remove the extra blank line in ChangLog. ChangeLog should simply say what you did, not why.
>>>>>
>>>>> H.J.
>>>>> ----
>>>>>> Sorry for the mistake.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Balaji V. Iyer.
>>>>>>
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>>>>> Sent: Tuesday, September 06, 2011 10:22 AM
>>>>>> To: Iyer, Balaji V
>>>>>> Cc: gcc-patches@gcc.gnu.org
>>>>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>>>>> to testsuite script
>>>>>>
>>>>>> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>>>>> Hello Everyone,
>>>>>>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>>>>>>
>>>>>>> Thanking You,
>>>>>>>
>>>>>>
>>>>>> ChangeLog entries are missing.
>>>>>>
>>>
>>
>>
>>
>> --
>> H.J.
>>
>
>
>
> --
> H.J.
>
--
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2011-09-06 18:06 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-06 4:52 [Patch][Cilkplus branch] Adding include directory path to testsuite script Iyer, Balaji V
2011-09-06 14:22 ` H.J. Lu
2011-09-06 14:31 ` Iyer, Balaji V
2011-09-06 14:41 ` H.J. Lu
2011-09-06 14:46 ` Iyer, Balaji V
2011-09-06 14:57 ` H.J. Lu
2011-09-06 15:03 ` Iyer, Balaji V
2011-09-06 16:42 ` H.J. Lu
[not found] ` <CAMe9rOogjm25uoBNUAmZUVYO57ccGEJu-hbp9WX+07Jv40aQiA@mail.gmail.com>
2011-09-06 17:35 ` Iyer, Balaji V
2011-09-06 17:39 ` H.J. Lu
2011-09-06 17:46 ` Iyer, Balaji V
2011-09-06 18:09 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).