From: Steve Ellcey <sellcey@marvell.com>
To: "sellcey@cavium.com" <sellcey@cavium.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Szabolcs.Nagy@arm.com" <Szabolcs.Nagy@arm.com>
Cc: "nd@arm.com" <nd@arm.com>
Subject: Re: [Patch 1/4][Aarch64] v2: Implement Aarch64 SIMD ABI
Date: Wed, 13 Feb 2019 17:24:00 -0000 [thread overview]
Message-ID: <29740e26b4329c2390406653813246858d46a049.camel@marvell.com> (raw)
In-Reply-To: <62101b5b-3ec3-6ebe-baa5-d1a85ccf3ab2@arm.com>
On Wed, 2019-02-13 at 16:54 +0000, Szabolcs Nagy wrote:
> > +/* Table of machine attributes. */
> > +static const struct attribute_spec aarch64_attribute_table[] =
> > +{
> > + /* { name, min_len, max_len, decl_req, type_req, fn_type_req,
> > + affects_type_identity, handler, exclude } */
> > + { "aarch64_vector_pcs", 0, 0, false, true, true, false, NULL,
> > NULL },
>
> i just noticed that "affects_type_identity" is set to false,
> so gcc accepts
>
> __attribute__((aarch64_vector_pcs)) void f(void);
> void (*g)(void) = f;
>
> without a warning (treats function types with different
> pcs as compatible)
>
> i think we don't want to allow calls through the wrong
> pointer type, such assignment should be an error.
I agree. I will submit a patch to change the affects_type_identity
flag and add a test for it.
Steve Ellcey
sellcey@marvell.com
prev parent reply other threads:[~2019-02-13 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 17:52 Steve Ellcey
2018-12-07 17:34 ` Richard Sandiford
2018-12-11 23:01 ` Steve Ellcey
2018-12-12 11:39 ` Richard Sandiford
2018-12-12 18:26 ` [EXT] " Steve Ellcey
2018-12-12 18:49 ` Richard Sandiford
2019-02-13 16:54 ` Szabolcs Nagy
2019-02-13 17:24 ` Steve Ellcey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29740e26b4329c2390406653813246858d46a049.camel@marvell.com \
--to=sellcey@marvell.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=sellcey@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).