From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 99849381C6C3 for ; Fri, 7 Jun 2024 20:18:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99849381C6C3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99849381C6C3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717791527; cv=none; b=k0SeSX+7bIkQPXUfzl3K+yZN+yxRJctIDmfUhKnV2/GjpIONjZwn32ek2CpdDbRoZSP7pRP2WWF3jSvgvnXNFYXa4SZq84PMDNdJ8PDkXBroK8Lyq4oQ9c07vHX7NFYTJe60lJrpNSFaJNJIH5xqtI0ScaC+W3jqIonmAPU/pLQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717791527; c=relaxed/simple; bh=bpEgQc1XCGfFv2bDCIO9i3u5kRNuSdZ+ViRmM8fWsSI=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=COCIOVCuobKSkzanYrfNxs2TT0gb4FuRZn0tJpnppLD1hHrfxw8wRLSdN0lwgpBepKStUr/FZEb1yKJVc6rFndwFVL0BKa+Aa1l7E9BjqSNxysawAKCz035rOVu3AWru/ASCjpUqd0hs93t7D1yjpmYRT2HSnO/7dnTBLNQSbs8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717791514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rvXGeF3ZU8yvpf1N7UfJecTXAQ3rEWbsP6g2q4t+cCA=; b=RqjeThxFVTu8HwKBbFBSFzQwZ6WMEoxJIrD3sIXyZDORZbHY9aNGppJjZlHCQCYZXYO53T fLEMWWoMuaIr7CgNBC21EUIGbaDiTdrrMFhiENtRgoRBfmon4uM6RWKiLAczWVgCP2aquY +KJCoQO9YwN2pGvdjSDeZ7FnHyKbKng= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-tOgZc-4XPRmsN_IL6EBSfg-1; Fri, 07 Jun 2024 16:18:33 -0400 X-MC-Unique: tOgZc-4XPRmsN_IL6EBSfg-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-79546c560d9so108734685a.3 for ; Fri, 07 Jun 2024 13:18:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717791512; x=1718396312; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rvXGeF3ZU8yvpf1N7UfJecTXAQ3rEWbsP6g2q4t+cCA=; b=f/jqm7CU/t+zL/I2SgOs4wTR8J5T5cq6XdbcBz3+mDls+u5GPpefLfuVREkyleiMhh mPetdwKGZyHuwvTsYAe+PJ5Ol/oM6QL/2yd5m66iqcGS+P1vIoSIo33xVHSxh4QlaKE/ /qKlNlwEjcEKvxeeEL5c4WM5XsPkSU1zsi3l979cYD6MgEc+QIzTTaMWXNUrcT/CilDt V9J5uJmWhiudJ6AUAVmroWNsxJ00YVAF0H+QH9RgtkZ1XOqxMQ79oGPuNITfaVSdHR6p kk8SwO/mA2uPd+ZkS5iwx32TrFpFZ3/KKCQY1o7T2oKdj1HFHEkJbQsCh1lQyg8udBD2 eopw== X-Forwarded-Encrypted: i=1; AJvYcCXD4JbKbPlhGK/pxIcZT1ITX5136PdJbZOIySkGpUP86Qw6jU4ePt5zMNzFW7doDGfHkKREL2fc9vQvgi1ZF2gSF2uJggXU9w== X-Gm-Message-State: AOJu0YyBQbC7/dvTw9ByQD6b1JIg/K2a1Wi1nei485aDgO3hrUZAJYsn ATtLkLYy/8v0+MzJSusNFXRQFeEMHOBfSaqgfuvwRNMzNpke2RtIAvOHabHQCI4teO0XHsbWyNy t3RNBiGfoXyVv96Nmr0V+MJeW/2Vjb8fhgmvZH5EI/AhR1D3LaEZXByE= X-Received: by 2002:a05:620a:2483:b0:795:1df7:b434 with SMTP id af79cd13be357-7953c49d064mr436023785a.60.1717791512329; Fri, 07 Jun 2024 13:18:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZ1TwhfKl9bz8D5y4GnS+5xGledcc2eNpwLVA7BISbpf+eRCn8YCdFEJgCcFGjB9rYAOXI+g== X-Received: by 2002:a05:620a:2483:b0:795:1df7:b434 with SMTP id af79cd13be357-7953c49d064mr436021785a.60.1717791511981; Fri, 07 Jun 2024 13:18:31 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id af79cd13be357-795332df4c7sm198353885a.127.2024.06.07.13.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 13:18:31 -0700 (PDT) Message-ID: <298741f3b5108591ca3f5e33e4c73c2d177a3aad.camel@redhat.com> Subject: Re: [analyzer PATCH] Restore bootstrap with g++ 4.8. From: David Malcolm To: Roger Sayle , gcc-patches@gcc.gnu.org Date: Fri, 07 Jun 2024 16:18:30 -0400 In-Reply-To: <026701dab90a$2cae4180$860ac480$@nextmovesoftware.com> References: <026701dab90a$2cae4180$860ac480$@nextmovesoftware.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2024-06-07 at 19:40 +0100, Roger Sayle wrote: >=20 > This patch restores bootstrap when using g++ 4.8 as a host compiler. > Returning a std::unique_ptr requires a std::move on C++ compilers > (pre-C++17) that don't guarantee copy elision/return value > optimization. >=20 > Bootstrapped on x86_64-pc-linux-gnu using both gcc 4.8.5 (system) and > gcc 10.2.1 (using "scl enable devetoolset-10") as host compilers. > Ok for mainline? Yes, thanks. Sorry for the breakage. Dave >=20 >=20 > 2024-06-07=C2=A0 Roger Sayle=C2=A0 >=20 > gcc/analyzer/ChangeLog > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * constraint-manager.cc (equiv= _class::make_dump_widget): Use > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 std::move to return a std::uni= que_ptr. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (bounded_ranges_constraint::ma= ke_dump_widget): Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (constraint_manager::make_dump= _widget): Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * program_state.cc (sm_state_m= ap::make_dump_widget): > Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (program_state::make_dump_widg= et): Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * region-model.cc (region_to_v= alue_map::make_dump_widget): > Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (region_model::make_dump_widge= t): Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * region.cc (region::make_dump= _widget): Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * store.cc (binding_cluster::m= ake_dump_widget): Likewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (store::make_dump_widget): Lik= ewise. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * svalue.cc (svalue::make_dump= _widget): Likewise. >=20 > Thanks in advance, > Roger > -- >=20