public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH][OBVIOUS] Fix thinko in transition to memop_ret type (PR middle-end/88246).
@ 2018-11-29 17:16 Martin Liška
  0 siblings, 0 replies; only message in thread
From: Martin Liška @ 2018-11-29 17:16 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Hi.

One obvious thinko I did when I convert the endp into a new enum.
The patch survives tests and bootstrap on x86_64-linux-gnu and
fixes the ICE in s390x bootstrap. I'm going to install it.

Martin

gcc/ChangeLog:

2018-11-29  Martin Liska  <mliska@suse.cz>

	PR middle-end/88246
	* builtins.c (expand_movstr): Fix thinko introduced
	when switching to the new enum.
---
 gcc/builtins.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[-- Attachment #2: 0001-Fix-thinko-in-transition-to-memop_ret-type-PR-middle.patch --]
[-- Type: text/x-patch, Size: 487 bytes --]

diff --git a/gcc/builtins.c b/gcc/builtins.c
index dcac49d8be1..537228cf3be 100644
--- a/gcc/builtins.c
+++ b/gcc/builtins.c
@@ -3931,7 +3931,7 @@ expand_movstr (tree dest, tree src, rtx target, memop_ret retmode)
 
   dest_mem = get_memory_rtx (dest, NULL);
   src_mem = get_memory_rtx (src, NULL);
-  if (retmode != RETURN_BEGIN)
+  if (retmode == RETURN_BEGIN)
     {
       target = force_reg (Pmode, XEXP (dest_mem, 0));
       dest_mem = replace_equiv_address (dest_mem, target);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-11-29 17:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-29 17:16 [PATCH][OBVIOUS] Fix thinko in transition to memop_ret type (PR middle-end/88246) Martin Liška

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).