From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3427 invoked by alias); 29 Nov 2018 17:16:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2890 invoked by uid 89); 29 Nov 2018 17:16:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=RETURN_BEGIN, return_begin, builtins.c, thinko X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 17:16:55 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D7288AF58 for ; Thu, 29 Nov 2018 17:16:52 +0000 (UTC) From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Subject: [PATCH][OBVIOUS] Fix thinko in transition to memop_ret type (PR middle-end/88246). To: gcc-patches@gcc.gnu.org Message-ID: <29c055bc-c843-07c5-6192-e336568d9e01@suse.cz> Date: Thu, 29 Nov 2018 17:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------667D40A52D1B9E63A69744F0" X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg02477.txt.bz2 This is a multi-part message in MIME format. --------------667D40A52D1B9E63A69744F0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 445 Hi. One obvious thinko I did when I convert the endp into a new enum. The patch survives tests and bootstrap on x86_64-linux-gnu and fixes the ICE in s390x bootstrap. I'm going to install it. Martin gcc/ChangeLog: 2018-11-29 Martin Liska PR middle-end/88246 * builtins.c (expand_movstr): Fix thinko introduced when switching to the new enum. --- gcc/builtins.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --------------667D40A52D1B9E63A69744F0 Content-Type: text/x-patch; name="0001-Fix-thinko-in-transition-to-memop_ret-type-PR-middle.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Fix-thinko-in-transition-to-memop_ret-type-PR-middle.pa"; filename*1="tch" Content-length: 487 diff --git a/gcc/builtins.c b/gcc/builtins.c index dcac49d8be1..537228cf3be 100644 --- a/gcc/builtins.c +++ b/gcc/builtins.c @@ -3931,7 +3931,7 @@ expand_movstr (tree dest, tree src, rtx target, memop_ret retmode) dest_mem = get_memory_rtx (dest, NULL); src_mem = get_memory_rtx (src, NULL); - if (retmode != RETURN_BEGIN) + if (retmode == RETURN_BEGIN) { target = force_reg (Pmode, XEXP (dest_mem, 0)); dest_mem = replace_equiv_address (dest_mem, target); --------------667D40A52D1B9E63A69744F0--