From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=6O6w=JA=t-online.de=oleg.endo@sourceware.org>
Received: from mailout05.t-online.de (mailout05.t-online.de [194.25.134.82])
	by sourceware.org (Postfix) with ESMTPS id 814773858C5E
	for <gcc-patches@gcc.gnu.org>; Mon, 22 Jan 2024 02:29:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 814773858C5E
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=t-online.de
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 814773858C5E
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=194.25.134.82
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705890579; cv=none;
	b=ZFE16p0EmSB+P+4qmQXgDHN/Z2IFNj2g3wfIv9hhhvx3OS0DVF2KjHlJx97IqmwVLqmUzIN7XnJ/WMEKWRG92H07ymd6oWJNVtPEGTmFXIXRIjey+yIeci2Txkp7NkbsXFa6lGNQSwcJ19Y2e0hqM1GmT+mfwK5pHlhlc7KIARE=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1705890579; c=relaxed/simple;
	bh=XD2BmMZ4nN9cEnDTgUrdmkAl6PmnfivsvI7VzJAArPc=;
	h=Message-ID:Subject:From:To:Date:MIME-Version; b=r9C56AOK49PZi3VhX6drlh0kHAFfnbmo/1wR8x39GQ+LtMcrZ0kK8omwQ83x/CtUmllJdXHGL38o8/jkqTlDv9M0taEZM/TCfNHW3w+ZeTUxPm0KLQ7bVWA2j8nClrDBo5yK2tBhGGst01qKxnGH0GNgYEPrrXcWyReJkKe+Tuc=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from fwd80.aul.t-online.de (fwd80.aul.t-online.de [10.223.144.106])
	by mailout05.t-online.de (Postfix) with SMTP id D3799204A2;
	Mon, 22 Jan 2024 03:29:35 +0100 (CET)
Received: from localhost.localdomain ([115.165.108.210]) by fwd80.t-online.de
	with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted)
	esmtp id 1rRk45-2CbBIW0; Mon, 22 Jan 2024 03:29:34 +0100
Message-ID: <29c84b5096d2b31486a54cc4ce746267a79049c6.camel@t-online.de>
Subject: Re: [committed] Adjust expectations for pr59533-1.c
From: Oleg Endo <oleg.endo@t-online.de>
To: Jeff Law <jeffreyalaw@gmail.com>, "gcc-patches@gcc.gnu.org"
	 <gcc-patches@gcc.gnu.org>
Date: Mon, 22 Jan 2024 11:29:30 +0900
In-Reply-To: <1d1bfa3e-8b63-47d6-91e9-6646c71a408e@gmail.com>
References: <1d1bfa3e-8b63-47d6-91e9-6646c71a408e@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
X-TOI-EXPURGATEID: 150726::1705890575-769C39CF-80FFB9A8/0/0 CLEAN NORMAL
X-TOI-MSGID: 19ca2e88-699a-455a-8c62-d9d269bf36bb
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>


On Sun, 2024-01-21 at 19:14 -0700, Jeff Law wrote:
> The change for pr111267 twiddled code generation for sh/pr59533-1.c
>=20
> We end up eliminating two comparisons, but require two shll instructions=
=20
> to do so.  And in a couple places we're using an addc sequence rather=20
> than a subc sequence.   This patch adjusts the expected codegen for the=
=20
> test as all those are either a wash or a
>=20
> The fwprop change does cause some code regressions on the same test.=20
> I'll file a distinct but for that issue.
>=20
> Pushed to the trunk,
>=20
> Jeff

Thanks for keeping an eye on this.

Note that on SH4 the comparison insns are of MT type, which increases
likelihood of parallel execution.  So it's better to use those e.g. to shif=
t
out the MSB into T bit than shll.

Cheers,
Oleg