From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by sourceware.org (Postfix) with ESMTPS id BFD143858431 for ; Fri, 8 Oct 2021 04:05:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFD143858431 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 65FF6542246; Fri, 8 Oct 2021 04:05:20 +0000 (UTC) Received: from pdx1-sub0-mail-a65.g.dreamhost.com (100-96-16-65.trex.outbound.svc.cluster.local [100.96.16.65]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E53DE5412A5; Fri, 8 Oct 2021 04:05:19 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a65.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.16.65 (trex/6.4.3); Fri, 08 Oct 2021 04:05:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Average-Occur: 58552d0e144e3f44_1633665920205_663011112 X-MC-Loop-Signature: 1633665920205:1206790085 X-MC-Ingress-Time: 1633665920205 Received: from pdx1-sub0-mail-a65.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a65.g.dreamhost.com (Postfix) with ESMTP id AA10F80462; Thu, 7 Oct 2021 21:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=message-id :date:mime-version:subject:from:to:cc:references:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=MfTObf 0xXC2ojO7SGzmSepM568w=; b=JB8MnSXRGeCy6le/uynblrdEGWEjnSlUqy6tRE 5mp2kfSBHS//aMPB6HCrAQLmafS9W/c+An8arAal4oYFeEq9u40Z8lE4DGcUMx1v zD+v8+aiLHFTHoQFZFT1ADmQR9dLmZADbBWPDRw09U9EpLrtlil+sbqJZ+d0hsWO dAPKk= Received: from [192.168.1.174] (unknown [1.186.223.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a65.g.dreamhost.com (Postfix) with ESMTPSA id 463247FAA3; Thu, 7 Oct 2021 21:05:16 -0700 (PDT) Message-ID: <29e901f2-37b0-a7c1-e0fb-cd30ab6cb2c2@gotplt.org> Date: Fri, 8 Oct 2021 09:35:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 2/8] tree-dynamic-object-size: New pass Content-Language: en-US X-DH-BACKEND: pdx1-sub0-mail-a65 From: Siddhesh Poyarekar To: gcc-patches@gcc.gnu.org Cc: jakub@redhat.com References: <20211007221432.1029249-1-siddhesh@gotplt.org> <20211007221432.1029249-3-siddhesh@gotplt.org> In-Reply-To: <20211007221432.1029249-3-siddhesh@gotplt.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3040.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2021 04:05:23 -0000 On 10/8/21 03:44, Siddhesh Poyarekar wrote: > diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi > index 133b82eef38..082d167cd65 100644 > --- a/gcc/doc/extend.texi > +++ b/gcc/doc/extend.texi > @@ -12777,6 +12777,17 @@ assert (__builtin_object_size (q, 1) == sizeof (var.b)); > @end smallexample > @end deftypefn > > +@deftypefn {Built-in Function} {size_t} __builtin_dynamic_object_size (const void * @var{ptr}, int @var{type}) > +is similar to @code{__builtin_object_size} in that it returns a number of bytes > +from @var{ptr} to the end of the object @var{ptr} pointer points to, except > +that the size returned may not be a constant. This results in successful > +evaluation of object size estimates in a wider range of use cases and can be > +more precise than @code{__builtin_object_size}, but it incurs a performance > +penalty since it may add a runtime overhead on size computation. Semantics of > +@var{type} as well as return values in case it is not possible to determine > +which objects @var{ptr} points to at compile time are the same as in the case > +of @code{__builtin_object_size}. > + Looks like I had pushed my scratch build without this doc update; this fails because I didn't terminate the @deftypefn. I've fixed it locally and will post an updated series along with resolution of feedback I receive on the series. Thanks, Siddhesh