From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 22EA63857C5B for ; Thu, 13 Aug 2020 22:11:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 22EA63857C5B Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07DM1h2P128775; Thu, 13 Aug 2020 18:11:23 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 32w30qma1s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Aug 2020 18:11:23 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 07DM1kbo129046; Thu, 13 Aug 2020 18:11:22 -0400 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 32w30qma1d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Aug 2020 18:11:22 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07DM9NG0002158; Thu, 13 Aug 2020 22:11:21 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma02dal.us.ibm.com with ESMTP id 32skpa0v58-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Aug 2020 22:11:21 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07DMBHeS25494004 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Aug 2020 22:11:17 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 85D38136053; Thu, 13 Aug 2020 22:11:20 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2D403136051; Thu, 13 Aug 2020 22:11:20 +0000 (GMT) Received: from lexx (unknown [9.163.2.104]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 13 Aug 2020 22:11:19 +0000 (GMT) Message-ID: <29ee0c7bb7d3a6bd9b8d1df6fe4534634ef370d2.camel@vnet.ibm.com> Subject: Re: [EXTERNAL] Re: [Patch 1/5] rs6000, Add 128-bit sign extension support From: will schmidt To: Segher Boessenkool , Carl Love Cc: dje.gcc@gmail.com, gcc-patches@gcc.gnu.org, Bill Schmidt Date: Thu, 13 Aug 2020 17:11:11 -0500 In-Reply-To: <20200813182901.GH6753@gate.crashing.org> References: <4ebaa81cef8cd6fe8caf8c33d6a4fc8a946c591f.camel@us.ibm.com> <20200813173605.GG6753@gate.crashing.org> <69627d93c9c9510aa8fe31f1d8f1456c57c87bbe.camel@us.ibm.com> <20200813182901.GH6753@gate.crashing.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-8.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-13_17:2020-08-13, 2020-08-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008130152 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 22:11:26 -0000 On Thu, 2020-08-13 at 13:29 -0500, Segher Boessenkool wrote: > On Thu, Aug 13, 2020 at 11:09:10AM -0700, Carl Love wrote: > > The builtins > > > > vector signed int vec_signexti (vector signed char a) > > vector signed long long vec_signextll (vector signed char a) > > vector signed int vec_signexti (vector signed short a) > > vector signed long long vec_signextll (vector signed short a) > > vector signed long long vec_signextll (vector signed int a) > > > > were defined in the function prototypes directory in box called > > "RFC > > 2608 - 128-bit Binary Integer Operations". The document the new > > P10 > > builtins. However, this subset of the newly defined builtins for > > P10 > > can be implemented with existing Power 9 instructions. That was > > the > > point of the comment. > > Ah, I see :-) > > > That is probably a level of detail that is not > > really needed in the GCC code comment. Probably best to just > > change > > the comment to read something like "ISA 3.0 sign extend builtins". > > Sounds good. As long as there are no issues defining the builtins for 3.0 here. AFAIK they are not documented in ISA 3.0. This is a happy accident that these ISA 3.1 builtins can be implemented with existing support. > > > My thought for calling it out is that they could be back ported to > > an > > earlier GCC version since they use Power 9 instructions but it is > > probably not worth the effort unless there is an explicit request > > for > > them. > > Yeah. Thanks for the explanation! > > > Segher