From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6CD4F3858D32 for ; Mon, 20 Mar 2023 19:28:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CD4F3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679340535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n8bJ6fbs7lhr6t3+Nu1lyUfLSQAToCQ6mC9dX2F/pyo=; b=TnsH9CNy1mfO6W9QfUWwaxC6u5LJxlDSRYEkuR6kFq/HO9IRaXvohaGtF/ZQ9d4yC1UuVL 8pdL0DUiQCCAv2aimcW781fhtURuKdUY2usHKu14RGjKoBpK9ppJz4Xn/Bl4XU2qLFIfNB FzxPOBL7gi03hO7Z6TXBUP8fmOcNqzU= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-WXOWXiwmMTi7QGYu3563Hg-1; Mon, 20 Mar 2023 15:28:54 -0400 X-MC-Unique: WXOWXiwmMTi7QGYu3563Hg-1 Received: by mail-qv1-f72.google.com with SMTP id a15-20020a0562140c2f00b005ad28a23cffso6531429qvd.6 for ; Mon, 20 Mar 2023 12:28:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679340533; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n8bJ6fbs7lhr6t3+Nu1lyUfLSQAToCQ6mC9dX2F/pyo=; b=AmMLMuSf/bPkruM6QbOTVSvt1OxxznAeG56YHvXlvkk9kzaoRAy3GNYcCI1iDlJKNm +qUBAnwUakBUBVDdrZxzoCg9bOpxd9EjNKNoXsNgy/GxCycC31ASBkS0gL7QHyG7vxc8 +WQyW9HJbSpbSJU2GiEj52PR8jJRY9xrbrjhDSaZ3Nh7iKdO7jgUiUOf/wL4cIMde5S/ 7+LtpusVvtyu8PUjsEibnpRbjKzwWPC48NdzWxbM+2M3lJCI6F3Z/KD6CxMSwh2zqM+I Dcp+qyz1wpRoNkVP1ci2hp33UzCgGP34BEJfC/aQifdlSRdErnL398SOZnH0JCfSJ5TR ZGOA== X-Gm-Message-State: AO0yUKWFoyZfY2GXyxifWU54prRr7z6UbhNulbucRiu7WI4qAc12QDaZ S7yYz/lQqCdJ5uVWzdLFTu8cxUVGCN1CiQsMjtBU9MDZqxDpSoarC983uZqEeiKqN0vuSkY1zhk mk7tgVQQnXleSU59Z7A== X-Received: by 2002:a05:622a:1707:b0:3d7:7d98:d202 with SMTP id h7-20020a05622a170700b003d77d98d202mr588555qtk.32.1679340533420; Mon, 20 Mar 2023 12:28:53 -0700 (PDT) X-Google-Smtp-Source: AK7set+d8uZ4/zYXjUrURWTqtFfd5uTko+P5Xmzr6dw/CvnC/MtGzB4PygVRJnsHOWaPioileiWrxQ== X-Received: by 2002:a05:622a:1707:b0:3d7:7d98:d202 with SMTP id h7-20020a05622a170700b003d77d98d202mr588458qtk.32.1679340532450; Mon, 20 Mar 2023 12:28:52 -0700 (PDT) Received: from [192.168.1.108] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id 142-20020a370494000000b007468cc74c77sm1905212qke.4.2023.03.20.12.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 12:28:51 -0700 (PDT) Message-ID: <29f8ac69-bae2-20c2-08fd-eb13bfd0a1a0@redhat.com> Date: Mon, 20 Mar 2023 15:28:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] c++, v2: Drop TREE_READONLY on vars (possibly) initialized by tls wrapper [PR109164] To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <70d76299-3cd0-6647-45c3-0aab6d21858a@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/20/23 15:26, Jakub Jelinek wrote: > On Mon, Mar 20, 2023 at 03:15:32PM -0400, Jason Merrill wrote: >>> + else if (VAR_P (decl) >>> + && CP_DECL_THREAD_LOCAL_P (decl) >>> + && (!DECL_EXTERNAL (decl) || flag_extern_tls_init) >> >> Hmm, I wonder why we don't check the above line in var_needs_tls_wrapper? > > It is tested in get_tls_init_fn (one of the 2 previous callers of > var_needs_tls_wrapper). No idea why it isn't in get_tls_wrapper_fn (the > other caller of it). I suppose because we might see a definition of the variable later on, and we don't want to have previously decided to omit the wrapper because we hadn't seen it yet. Jason