[PATCH, go]: Restore bootstrap

[PATCH, go]: Restore bootstrap

[Uros Bizjak]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

Hello!

2014-07-24  Uros Bizjak  <ubizjak@gmail.com>

    * go/go-gcc.cc (Gcc_backend::global_variable_set_init): Rename
    symtab_get_node to symtab_node::get.

Tested on x86_64-linux-gnu and committed to mainline SVN.

Uros.

[-- Attachment #2: g.diff.txt --]
[-- Type: text/plain, Size: 618 bytes --]

Index: go-gcc.cc
===================================================================
--- go-gcc.cc	(revision 213019)
+++ go-gcc.cc	(working copy)
@@ -2374,8 +2374,8 @@ Gcc_backend::global_variable_set_init(Bvariable* v
 
   // If this variable goes in a unique section, it may need to go into
   // a different one now that DECL_INITIAL is set.
-  if (symtab_get_node(var_decl)
-      && symtab_get_node(var_decl)->implicit_section)
+  if (symtab_node::get(var_decl)
+      && symtab_node::get(var_decl)->implicit_section)
     {
       set_decl_section_name (var_decl, NULL);
       resolve_unique_section (var_decl,

Re: [PATCH, go]: Restore bootstrap

[Martin Liška]

On 07/24/2014 07:57 PM, Uros Bizjak wrote:
> Hello!
>
> 2014-07-24  Uros Bizjak  <ubizjak@gmail.com>
>
>      * go/go-gcc.cc (Gcc_backend::global_variable_set_init): Rename
>      symtab_get_node to symtab_node::get.
>
> Tested on x86_64-linux-gnu and committed to mainline SVN.
>
> Uros.
Hello,
     thank you for your fix. As I see my configure output:

$ ../configure --disable-bootstrap --enable-checking=release 
--enable-languages=all --disable-multilib

The following languages will be built: c,c++,fortran,java,lto,objc
*** This configuration is not supported in the following subdirectories:
      gnattools target-libada target-libgo target-libbacktrace
     (Any other directories should still work fine.)

I thought with 'all' I cover all front-ends, is it really intended 
behavior that go is disable by 'all'?

Thank you,
Martin

Re: [PATCH, go]: Restore bootstrap

[Ian Lance Taylor]

On Thu, Jul 24, 2014 at 12:21 PM, Martin Liška <mliska@suse.cz> wrote:
> On 07/24/2014 07:57 PM, Uros Bizjak wrote:
>>
>> Hello!
>>
>> 2014-07-24  Uros Bizjak  <ubizjak@gmail.com>
>>
>>      * go/go-gcc.cc (Gcc_backend::global_variable_set_init): Rename
>>      symtab_get_node to symtab_node::get.
>>
>> Tested on x86_64-linux-gnu and committed to mainline SVN.
>>
>> Uros.
>
> Hello,
>     thank you for your fix. As I see my configure output:
>
> $ ../configure --disable-bootstrap --enable-checking=release
> --enable-languages=all --disable-multilib
>
> The following languages will be built: c,c++,fortran,java,lto,objc
> *** This configuration is not supported in the following subdirectories:
>      gnattools target-libada target-libgo target-libbacktrace
>     (Any other directories should still work fine.)
>
> I thought with 'all' I cover all front-ends, is it really intended behavior
> that go is disable by 'all'?

Yes, --enable-languages=all is the default, so it only builds the
frontends that are enabled by default, so it does not build the Go or
Ada frontends.  I know it doesn't make much sense.

Ian

Re: [PATCH, go]: Restore bootstrap

[Martin Liška]

On 07/25/2014 03:51 AM, Ian Lance Taylor wrote:
> On Thu, Jul 24, 2014 at 12:21 PM, Martin Liška <mliska@suse.cz> wrote:
>> On 07/24/2014 07:57 PM, Uros Bizjak wrote:
>>> Hello!
>>>
>>> 2014-07-24  Uros Bizjak  <ubizjak@gmail.com>
>>>
>>>       * go/go-gcc.cc (Gcc_backend::global_variable_set_init): Rename
>>>       symtab_get_node to symtab_node::get.
>>>
>>> Tested on x86_64-linux-gnu and committed to mainline SVN.
>>>
>>> Uros.
>> Hello,
>>      thank you for your fix. As I see my configure output:
>>
>> $ ../configure --disable-bootstrap --enable-checking=release
>> --enable-languages=all --disable-multilib
>>
>> The following languages will be built: c,c++,fortran,java,lto,objc
>> *** This configuration is not supported in the following subdirectories:
>>       gnattools target-libada target-libgo target-libbacktrace
>>      (Any other directories should still work fine.)
>>
>> I thought with 'all' I cover all front-ends, is it really intended behavior
>> that go is disable by 'all'?
> Yes, --enable-languages=all is the default, so it only builds the
> frontends that are enabled by default, so it does not build the Go or
> Ada frontends.  I know it doesn't make much sense.
>
> Ian
I would suggest to replace currently used 'all' to 'default'. And 'all' can be really used for all possible frontends we have :) I know it changes the behavior, but I hope I makes sense?

Thank you,
Martin

Re: [PATCH, go]: Restore bootstrap

[Gerald Pfeifer]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 574 bytes --]

On Fri, 25 Jul 2014, Martin Liška wrote:
>> Yes, --enable-languages=all is the default, so it only builds the
>> frontends that are enabled by default, so it does not build the Go or
>> Ada frontends.  I know it doesn't make much sense.
> I would suggest to replace currently used 'all' to 'default'. And 'all' 
> can be really used for all possible frontends we have :) I know it 
> changes the behavior, but I hope I makes sense?

I'd be in favor of that (assuming you mean "all that we have and
that are supported for the host/target combination in questions).

Gerald

Re: [PATCH, go]: Restore bootstrap

[Mike Stump]

On Jul 28, 2014, at 3:29 AM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> On Fri, 25 Jul 2014, Martin Liška wrote:
>>> Yes, --enable-languages=all is the default, so it only builds the
>>> frontends that are enabled by default, so it does not build the Go or
>>> Ada frontends.  I know it doesn't make much sense.
>> I would suggest to replace currently used 'all' to 'default'. And 'all' 
>> can be really used for all possible frontends we have :) I know it 
>> changes the behavior, but I hope I makes sense?
> 
> I'd be in favor of that (assuming you mean "all that we have and
> that are supported for the host/target combination in questions).

When I want to do all, I actually do want to do all.  I think as long as we retain a spelling for the trimmed list, (aka default or most or some spelling), I think it would be an improvement.  A second option would be a noimeanreallyall spelling to get all and leave all alone.  I don’t favor that.

Re: [PATCH, go]: Restore bootstrap

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]


On 07/28/2014 05:24 PM, Mike Stump wrote:
> On Jul 28, 2014, at 3:29 AM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
>> On Fri, 25 Jul 2014, Martin Liška wrote:
>>>> Yes, --enable-languages=all is the default, so it only builds the
>>>> frontends that are enabled by default, so it does not build the Go or
>>>> Ada frontends.  I know it doesn't make much sense.
>>> I would suggest to replace currently used 'all' to 'default'. And 'all'
>>> can be really used for all possible frontends we have :) I know it
>>> changes the behavior, but I hope I makes sense?
>> I'd be in favor of that (assuming you mean "all that we have and
>> that are supported for the host/target combination in questions).
> When I want to do all, I actually do want to do all.  I think as long as we retain a spelling for the trimmed list, (aka default or most or some spelling), I think it would be an improvement.  A second option would be a noimeanreallyall spelling to get all and leave all alone.  I donÂ’t favor that.
Hello,
    I am not a configure script guru, but what do you think about suggested patch?

Thanks,
MArtin

[-- Attachment #2: enable-languages.patch --]
[-- Type: text/x-patch, Size: 3978 bytes --]

diff --git a/configure b/configure
index 353730b..e5eb557 100755
--- a/configure
+++ b/configure
@@ -6298,7 +6298,7 @@ if test -d ${srcdir}/gcc; then
       enable_languages="${LANGUAGES}"
         echo configure.in: warning: setting LANGUAGES is deprecated, use --enable-languages instead 1>&2
     else
-      enable_languages=all
+      enable_languages=default
     fi
   else
     if test x"${enable_languages}" = x ||
@@ -6350,6 +6350,7 @@ if test -d ${srcdir}/gcc; then
         for other in ${lang_requires} ${lang_requires_boot_languages}; do
           case ,${enable_languages}, in
 	    *,$other,*) ;;
+	    *,default,*) ;;
 	    *,all,*) ;;
 	    *,$language,*)
 	      echo " \`$other' language required by \`$language'; enabling" 1>&2
@@ -6361,6 +6362,7 @@ if test -d ${srcdir}/gcc; then
 	  if test "$other" != "c"; then
 	    case ,${enable_stage1_languages}, in
 	      *,$other,*) ;;
+	      *,default,*) ;;
 	      *,all,*) ;;
 	      *)
 		case ,${enable_languages}, in
@@ -6393,7 +6395,7 @@ if test -d ${srcdir}/gcc; then
   fi
 
 
-  missing_languages=`echo ",$enable_languages," | sed -e s/,all,/,/ -e s/,c,/,/ `
+  missing_languages=`echo ",$enable_languages," | sed -e s/,all,/,/ -e s/,default,/,/ -e s/,c,/,/ `
   potential_languages=,c,
 
   enabled_target_libs=
@@ -6433,12 +6435,18 @@ if test -d ${srcdir}/gcc; then
 	      add_this_lang=yes
 	    fi
             ;;
-          *,all,*)
-            # 'all' was selected, select it if it is a default language
+          *,default,*)
+            # 'default' was selected, select it if it is a default language
 	    if test "$language" != "c"; then
 	      add_this_lang=${build_by_default}
 	    fi
             ;;
+          *,all,*)
+            # 'all' was selected, add the language
+	    if test "$language" != "c"; then
+	      add_this_lang=yes
+	    fi
+            ;;
         esac
 
         # Disable languages that need other directories if these aren't available.
diff --git a/configure.ac b/configure.ac
index d0f7471..2d99dc5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1759,7 +1759,7 @@ if test -d ${srcdir}/gcc; then
       enable_languages="${LANGUAGES}"
         echo configure.in: warning: setting LANGUAGES is deprecated, use --enable-languages instead 1>&2
     else
-      enable_languages=all
+      enable_languages=default
     fi
   else
     if test x"${enable_languages}" = x ||
@@ -1811,6 +1811,7 @@ if test -d ${srcdir}/gcc; then
         for other in ${lang_requires} ${lang_requires_boot_languages}; do
           case ,${enable_languages}, in
 	    *,$other,*) ;;
+	    *,default,*) ;;
 	    *,all,*) ;;
 	    *,$language,*)
 	      echo " \`$other' language required by \`$language'; enabling" 1>&2
@@ -1822,6 +1823,7 @@ if test -d ${srcdir}/gcc; then
 	  if test "$other" != "c"; then
 	    case ,${enable_stage1_languages}, in
 	      *,$other,*) ;;
+	      *,default,*) ;;
 	      *,all,*) ;;
 	      *)
 		case ,${enable_languages}, in
@@ -1854,7 +1856,7 @@ if test -d ${srcdir}/gcc; then
   fi
   AC_SUBST(extra_host_libiberty_configure_flags)
 
-  missing_languages=`echo ",$enable_languages," | sed -e s/,all,/,/ -e s/,c,/,/ `
+  missing_languages=`echo ",$enable_languages," | sed -e s/,all,/,/ -e s/,default,/,/ -e s/,c,/,/ `
   potential_languages=,c,
 
   enabled_target_libs=
@@ -1894,12 +1896,18 @@ if test -d ${srcdir}/gcc; then
 	      add_this_lang=yes
 	    fi
             ;;
-          *,all,*)
-            # 'all' was selected, select it if it is a default language
+          *,default,*)
+            # 'default' was selected, select it if it is a default language
 	    if test "$language" != "c"; then
 	      add_this_lang=${build_by_default}
 	    fi
             ;;
+          *,all,*)
+            # 'all' was selected, add the language
+	    if test "$language" != "c"; then
+	      add_this_lang=yes
+	    fi
+            ;;
         esac
 
         # Disable languages that need other directories if these aren't available.

Re: [PATCH, go]: Restore bootstrap

[Mike Stump]

On Jul 29, 2014, at 2:10 AM, Martin Liška <mliska@suse.cz> wrote:
>   I am not a configure script guru, but what do you think about suggested patch?

Looks exactly like what I would do.

Re: [PATCH, go]: Restore bootstrap

[Martin Liška]

On 07/29/2014 07:01 PM, Mike Stump wrote:
> On Jul 29, 2014, at 2:10 AM, Martin Liška <mliska@suse.cz> wrote:
>>    I am not a configure script guru, but what do you think about suggested patch?
> Looks exactly like what I would do.
All right, I'll send the patch, as well as documentation enhancement, to 
a separate mailing list thread.

Thanks,
Martin