From: "Thomas König" <tk@tkoenig.net>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
Cc: Janne Blomqvist <blomqvist.janne@gmail.com>,
Thomas Koenig <tkoenig@netcologne.de>,
Richard Biener <richard.guenther@gmail.com>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][Fortran][v2] Use MIN/MAX_EXPR for min/max intrinsics
Date: Wed, 18 Jul 2018 13:26:00 -0000 [thread overview]
Message-ID: <2AD7441E-7E57-47EC-9073-92375938B8B8@tkoenig.net> (raw)
In-Reply-To: <5B4F21E0.3060307@foss.arm.com>
Hi Kyrlll,
> Am 18.07.2018 um 13:17 schrieb Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>:
>
> Thomas, Janne, would this relaxation of NaN handling be acceptable given the benefits
> mentioned above? If so, what would be the recommended adjustment to the nan_1.f90 test?
I would be a bit careful about changing behavior in such a major way. What would the results with NaN and infinity then be, with or without optimization? Would the results be consistent with min(nan,num) vs min(num,nan)? Would they be consistent with the new IEEE standard?
In general, I think that min(nan,num) should be nan and that our current behavior is not the best.
Does anybody have dats points on how this is handled by other compilers?
Oh, and if anything is changed, then compile and runtime behavior should always be the same.
Regards, Thomas
next prev parent reply other threads:[~2018-07-18 13:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 12:35 [PATCH][Fortran] Use MIN/MAX_EXPR for intrinsics or __builtin_fmin/max when appropriate Kyrill Tkachov
2018-07-17 13:27 ` Richard Biener
2018-07-17 13:46 ` Kyrill Tkachov
2018-07-17 15:37 ` Thomas Koenig
2018-07-17 16:16 ` Kyrill Tkachov
2018-07-17 17:42 ` Thomas Koenig
2018-07-17 20:06 ` Janne Blomqvist
2018-07-17 20:35 ` Janne Blomqvist
2018-07-18 11:17 ` [PATCH][Fortran][v2] Use MIN/MAX_EXPR for min/max intrinsics Kyrill Tkachov
2018-07-18 13:26 ` Thomas König [this message]
2018-07-18 14:03 ` Kyrill Tkachov
2018-07-18 14:55 ` Janne Blomqvist
2018-07-18 15:28 ` Richard Sandiford
2018-07-18 16:04 ` Kyrill Tkachov
2018-07-18 15:10 ` Janne Blomqvist
2018-07-26 20:36 ` Joseph Myers
2018-08-06 12:05 ` Janne Blomqvist
2018-07-18 9:44 ` [PATCH][Fortran] Use MIN/MAX_EXPR for intrinsics or __builtin_fmin/max when appropriate Richard Biener
2018-07-18 9:50 ` Kyrill Tkachov
2018-07-18 10:06 ` Richard Biener
2018-07-18 11:45 ` [PATCH]Use " Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2AD7441E-7E57-47EC-9073-92375938B8B8@tkoenig.net \
--to=tk@tkoenig.net \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=richard.guenther@gmail.com \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).