public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Dominique d'Humières" <dominiq@lps.ens.fr>
To: FX <fxcoudert@gmail.com>
Cc: GNU GFortran <fortran@gcc.gnu.org>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [libquadmath, patch] Add logbq() to libquadmath
Date: Wed, 05 Aug 2015 13:43:00 -0000	[thread overview]
Message-ID: <2B7CD2AA-791E-4A95-AC94-5D08D14441A9@lps.ens.fr> (raw)
In-Reply-To: <CE123F91-715D-40A8-9FE9-460E00FBFA3C@gmail.com>


> Le 5 août 2015 à 15:11, FX <fxcoudert@gmail.com> a écrit :
> 
>> AFAICT there is something missing in the patch: I do not see any compilation of math/logbq.c and indeed no trace of logbq in libquadmath. What I am missing?
> 
> Maybe you didn’t regenerate the Makefile.in?

Indeed I did not!-(I have never succeeded with the regenerate process: not the right version, …).

> The patch was sent without this regenerated file, as is (as I understand) the custom on gcc-patches.
> 
> Attached is the full diff, including Makefile.in.

With the updated patch the test gfortran.dg/ieee/large_1.f90 compiles, but fails at run time due to the lines

  if (.not. ieee_support_underflow_control(x1)) call abort

and

  if (.not. ieee_support_underflow_control(x2)) call abort

IIRC Uros said that underflow id not supported for __float128.

Thanks for the answer,

Dominique

> 
> FX
> 
> <x.diff>

  reply	other threads:[~2015-08-05 13:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 11:43 Dominique d'Humières
2015-08-05 13:11 ` FX
2015-08-05 13:43   ` Dominique d'Humières [this message]
2015-08-06  8:39     ` FX
  -- strict thread matches above, loose matches on Subject: below --
2015-08-03 21:04 FX
2015-08-09  6:27 ` FX
2015-08-09  7:08   ` Paul Richard Thomas
2015-08-09  7:13     ` Paul Richard Thomas
2015-08-09  7:09   ` Richard Biener
2015-08-09  8:47     ` FX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2B7CD2AA-791E-4A95-AC94-5D08D14441A9@lps.ens.fr \
    --to=dominiq@lps.ens.fr \
    --cc=fortran@gcc.gnu.org \
    --cc=fxcoudert@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).