Re: [PATCH, aarch64] Add prefetch support

["Dr. Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>]

Great. I should have an update patch-set ready & tested later tonight.

Best,
Phil.

> On 13 Jan 2015, at 15:18, Andrew Pinski <pinskia@gmail.com> wrote:
> 
> On Tue, Jan 13, 2015 at 6:13 AM, Marcus Shawcroft
> <marcus.shawcroft@gmail.com> wrote:
>> On 11 January 2015 at 02:37, Andrew Pinski <pinskia@gmail.com> wrote:
>>> On Tue, Nov 11, 2014 at 6:47 AM, Marcus Shawcroft
>>> <marcus.shawcroft@gmail.com> wrote:
>>>> On 30 October 2014 08:54, Gopalasubramanian, Ganesh
>>>> <Ganesh.Gopalasubramanian@amd.com> wrote:
>>>> 
>>>>> 2014-10-30  Ganesh Gopalasubramanian <Ganesh.Gopalasubramanian@amd.com>
>>>> 
>>>> Check the whitespace in your ChangeLog line.
>>>> 
>>>>>        * config/arm/types.md (define_attr "type"): Add prefetch.
>>>> 
>>>> The existing schedulers use 'load1'.  We can of course split that into
>>>> two introducing "prefetch" and update all of the existing schedulers
>>>> to reflect the change.  However I suggest we do that as a separate
>>>> activity when someone actually needs the distinction, note this change
>>>> will require updating the schedulers for both ARM and AArch64 backends
>>>> not just those relevant to AArch64.  For this prefetch patch I suggest
>>>> we go with the existing "load1".
>>> 
>>> I will need this change for ThunderX schedule.  The Pref instruction
>>> is single issued while load1 can be dual issued.
>> 
>> Hi
>> 
>> https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00802.html
>> 
>> Philipp when you deal with Ramana's request above to split
>> load1->load1/prefetch in the existing schedulers I suggest you also
>> split it in aarch64/thunderx.md in order to retain existing behaviour.
>> Andrew can then follow up add the "right" behaviour when he is ready.
>> Andrew OK ?
> 
> Yes that sounds ok to me.  I was going to submit an update to
> thunderx.md file this week anyways.
> 
> Thanks,
> Andrew
> 
> 
>> 
>> Cheers
>> /Marcus