public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Qing Zhao <qing.zhao@oracle.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: jakub Jelinek <jakub@redhat.com>,
	richard Biener <rguenther@suse.de>,
	Kees Cook <keescook@chromium.org>,
	gcc Patches <gcc-patches@gcc.gnu.org>,
	Nathan Sidwell <Nathan@acm.org>, martin Sebor <msebor@gmail.com>
Subject: Re: [[GCC13][Patch][V3] 1/2] Add a new option -fstrict-flex-array[=n] and new attribute strict_flex_array
Date: Wed, 31 Aug 2022 19:47:53 +0000	[thread overview]
Message-ID: <2C0B6A60-A27D-4B96-9559-096712EC32FA@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2208311927220.498823@digraph.polyomino.org.uk>



> On Aug 31, 2022, at 3:29 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> 
> On Wed, 31 Aug 2022, Qing Zhao via Gcc-patches wrote:
> 
>>> How is level 3 (thus -fstrict-flex-array) interpreted when you specify 
>>> -std=c89?  How for -std=gnu89?
>> 
>> 1. what’s the major difference between -std=c89 and -std=gnu89 on flexible array? (Checked online, cannot find a concrete answer on this).
>> 	** my understanding is:   -std=c89 will not support any flexible array (neither [], [0], [1]), but -std=gnu89 will support [0] and [1], but not [].
>>        Is this correct?
> 
> Flexible array members are supported in all C standard modes, since they 
> don't affect the semantics of any valid pre-C99 program (only make valid 
> programs that were previously erroneous).
> 
> With -std=c89 or -std=gnu89, -pedantic will give a warning "ISO C90 does 
> not support flexible array members" and -pedantic-errors will change that 
> to an error.

A little confused here…

With both -std=c89 and -std=gnu89, -pedantic will warning on “[]” (C99 flexible array member):

[opc@qinzhao-ol8u3-x86 ~]$ gcc -std=c89 t.c  -pedantic
t.c:5:7: warning: ISO C90 does not support flexible array members [-Wpedantic]
    5 |   int b[];
      |       ^
[opc@qinzhao-ol8u3-x86 ~]$ gcc -std=gnu89 t.c  -pedantic
t.c:5:7: warning: ISO C90 does not support flexible array members [-Wpedantic]
    5 |   int b[];
      |       ^

Does the above mean that -std=gnu89 does not support C99 flexible array member,  then

When -std=gnu89 + -fstrict-flex-array=3  (ONLY C99 flexible array member [] is treated as a valid flexible array) present together, 

It should be reasonable to issue warning on this?      (-fstrict-flex-arrays=3 is not supported by GNU extension GNU89, ignored)

Right?

Qing




> 
> -- 
> Joseph S. Myers
> joseph@codesourcery.com


  parent reply	other threads:[~2022-08-31 19:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 14:40 Qing Zhao
2022-08-17 14:40 ` [[GCC13][Patch][V3] 2/2] Use array_at_struct_end_p in __builtin_object_size [PR101836] Qing Zhao
2022-08-26  8:49   ` Richard Biener
2022-08-26 13:37     ` Qing Zhao
2022-08-26  8:48 ` [[GCC13][Patch][V3] 1/2] Add a new option -fstrict-flex-array[=n] and new attribute strict_flex_array Richard Biener
2022-08-26 13:47   ` Qing Zhao
2022-08-29  8:04     ` Richard Biener
2022-08-30 20:30 ` Fwd: " Qing Zhao
2022-08-30 20:30   ` Qing Zhao
2022-08-30 22:53   ` Joseph Myers
2022-08-31 14:00     ` Qing Zhao
2022-08-31 17:21       ` Joseph Myers
2022-08-31 17:21         ` Joseph Myers
2022-08-31 18:55         ` Qing Zhao
2022-08-31 19:24           ` Qing Zhao
2022-08-31 19:29           ` Joseph Myers
2022-08-31 19:29             ` Joseph Myers
2022-08-31 19:47             ` Qing Zhao [this message]
2022-08-31 19:52               ` Joseph Myers
2022-08-31 20:06                 ` Qing Zhao
2022-08-31 20:09                   ` Joseph Myers
2022-08-31 20:16                     ` Qing Zhao
2022-08-31 20:35                       ` Qing Zhao
2022-08-31 22:23                         ` Kees Cook
2022-09-01  6:11                           ` Richard Biener
2022-09-04 14:17                             ` Qing Zhao
2022-08-31 22:17                       ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2C0B6A60-A27D-4B96-9559-096712EC32FA@oracle.com \
    --to=qing.zhao@oracle.com \
    --cc=Nathan@acm.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=keescook@chromium.org \
    --cc=msebor@gmail.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).