public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: FX <fxcoudert@gmail.com>
To: gfortran <fortran@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>,
	Andreas Schwab <schwab@suse.de>
Subject: Re: [patch,libgfortran] Fix binary128 ERFC_SCALED
Date: Thu, 21 Nov 2013 10:43:00 -0000	[thread overview]
Message-ID: <2C35B54E-3BC3-4744-8419-12A35ADEDE4E@gmail.com> (raw)
In-Reply-To: <mvmeh6ai2sa.fsf@hawking.suse.de>

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

> ../../../libgfortran/intrinsics/erfc_scaled.c:59:1: error: unknown type name ‘GFC_REAL_16'

I’m really sorry about that, I should have tested on a system without binary128, that would have caught it.
Attached patch committed as rev. 205193 after checking it on system both with and without binary128.

Sorry again,
FX



2013-11-20  Francois-Xavier Coudert  <fxcoudert@gcc.gnu.org>

	PR libfortran/59227
	* intrinsics/erfc_scaled.c (erfc_scaled_r16): Don't define if
	__float128 is not available.


[-- Attachment #2: fix.diff --]
[-- Type: application/octet-stream, Size: 635 bytes --]

Index: intrinsics/erfc_scaled.c
===================================================================
--- intrinsics/erfc_scaled.c	(revision 205151)
+++ intrinsics/erfc_scaled.c	(working copy)
@@ -52,14 +52,14 @@ see the files COPYING3 and COPYING.RUNTI
 #endif
 
 
+#ifdef GFC_REAL_16_IS_FLOAT128
+
 /* For quadruple-precision (__float128), netlib's implementation is
    not accurate enough.  We provide another one.  */
 
-
 extern GFC_REAL_16 erfc_scaled_r16 (GFC_REAL_16);
 export_proto(erfc_scaled_r16);
 
-
 GFC_REAL_16
 erfc_scaled_r16 (GFC_REAL_16 x)
 {
@@ -101,3 +101,5 @@ erfc_scaled_r16 (GFC_REAL_16 x)
     }
 }
 
+#endif
+

  reply	other threads:[~2013-11-21  8:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-17 21:41 FX
2013-11-20 20:13 ` Steve Kargl
2013-11-20 22:19   ` FX
2013-11-20 23:02     ` Steve Kargl
2013-11-21  1:00       ` FX
2013-11-21 10:32     ` Andreas Schwab
2013-11-21 10:43       ` FX [this message]
2013-11-21 11:43         ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2C35B54E-3BC3-4744-8419-12A35ADEDE4E@gmail.com \
    --to=fxcoudert@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=schwab@suse.de \
    --cc=sgk@troutmask.apl.washington.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).