From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 161BF3858C52 for ; Fri, 12 May 2023 19:14:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 161BF3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-50bd37ca954so92441006a12.0 for ; Fri, 12 May 2023 12:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683918875; x=1686510875; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MWZ/M653xi31wqd/RxX0kiDXEYgzMqmQBif+c+1acWE=; b=N8SLHrO46f8TwZc6mdFmiBEj7E+0X6GXF6wCdZnd/fm3f3Ir3L6GyB2/qL98qbLm1u lcDTEij0O6Fesr+m8LGecY3fLLdPzrGgH8Ql7fryjqyMt/9hKKniPE9Vk2suEFoyUiGB UNbosn8JrvoG/f47t3mDlIQsaRaXSVXQo/9gG2SuCn4iyK4SCwWZ/12KRCn3MJG/ylFW QydkwojQe+2xJtA+3PelpuhVIJaHEIN7yVaYjZQV6nI5Q00vvx11VyIC/JNAjrDhkCgm IbAgsaSzjT3Brp8hBoLrA4ZON7zO1OGOZhIyHH9PFBBpwRy/3PzO31qWmATFtkKNVQzL 2cvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683918875; x=1686510875; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MWZ/M653xi31wqd/RxX0kiDXEYgzMqmQBif+c+1acWE=; b=IJLbLn02mhjgnEEYwOkbIxmVZUuX4AzuuGzDjSN/4Tcj+dGYgFtmcGi7IigbwrErjX OlzNaMSjjRmu7PyCqu4VEQUFQTHjY703aRxVW2tkzDZ57ig2Goj22X/QvaCIEWwn5zza k5tCb92FxGVcTunlfIEAQgTwgcCUoykL/gSAQTtPNku8j5Hmc/whkhbw4kDYm7YJtpXq z2Ko5ds42T7WOxjGQS7qrJAGc/W+j2lCstcrmnMojB3ksuk/vONy6lGT5yDaApC9HJhD p0or//vbkmW9gvivNDatsxuwh11af7M1OnvxchuwfgPeipLrL3cuCCpHilrZi8fLT5X9 am2Q== X-Gm-Message-State: AC+VfDx/enKerCzR7IowGLCnU7RRkv58n6jrwCphXGCOpClL75nVMxoW WJZPPcYS5X1sODaoGPo2Ivo= X-Google-Smtp-Source: ACHHUZ6CKr7c40ppWvLUum4nPmoqQoImAv2AKboIMYad+Ib97J1XzRicS6Qx1kqhgVkrvgv1u2aHQg== X-Received: by 2002:a05:6402:40c9:b0:506:72f8:eb10 with SMTP id z9-20020a05640240c900b0050672f8eb10mr23329194edb.0.1683918875401; Fri, 12 May 2023 12:14:35 -0700 (PDT) Received: from ?IPv6:::1? ([2001:871:227:ce8b:39de:e3d6:ecfc:f9a7]) by smtp.gmail.com with ESMTPSA id o22-20020aa7d3d6000000b0050696c2d2f6sm4037596edr.88.2023.05.12.12.14.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 12:14:34 -0700 (PDT) Date: Fri, 12 May 2023 21:14:29 +0200 From: Bernhard Reutner-Fischer To: Richard Biener , Richard Biener via Gcc-patches , pan2.li@intel.com CC: gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai, kito.cheng@sifive.com, yanzhang.wang@intel.com, jeffreyalaw@gmail.com, richard.sandiford@arm.com Subject: Re: [PATCH] Machine_Mode: Extend machine_mode from 8 to 16 bits In-Reply-To: References: <20230512050016.476110-1-pan2.li@intel.com> Message-ID: <2CEAD79B-D664-41B4-A337-5E77ECFB2F9D@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12 May 2023 08:49:53 CEST, Richard Biener via Gcc-patches wrote: >> gcc/ChangeLog: >>=20 >> * combine=2Ecc (struct reg_stat_type): Extended machine mode to 16 bit= s=2E >> * cse=2Ecc (struct qty_table_elem): Ditto=2E >> (struct table_elt): Ditto=2E >> (struct set): Ditto=2E >> * genopinit=2Ecc (main): Reconciled the machine mode limit=2E >> * ira-int=2Eh (struct ira_allocno): Extended machine mode to 16 bits= =2E >> * ree=2Ecc (struct ATTRIBUTE_PACKED): Ditto=2E > >please go over the ChangeLog and properly specify the structure types >altered=2E The script generating the changelog isn't perfect=2E And a nitpick, please use present tense in the ChangeLog: Extend, etc And I wouldn't have said reconcile=2E thanks,