Re: [Patch] PR55189 enable -Wreturn-type by default

[Mike Stump <mikestump@comcast.net>]

On Jun 4, 2014, at 12:49 PM, Sylvestre Ledru <sylvestre@debian.org> wrote:
> Finally, I have been able to update all tests with -Wreturn-type enabled
> by default.

> Now, I would like to know if I can commit that into the repository. Who
> can review that?

I’d like a C style person to review gcc.dg/Wreturn-type2.c, just to ensure they think it is reasonable, and a Fortran person to spot check, but other than that the test suite patches look good.

I will note that adding:

+/* { dg-options "-Wno-return-type" } */

to some parts of the test suite will change the options used to compile:

# If a testcase doesn't have special options, use these.                                          
global DEFAULT_CXXFLAGS
if ![info exists DEFAULT_CXXFLAGS] then {
    set DEFAULT_CXXFLAGS " -pedantic-errors -Wno-long-long”
}

In theory, this could matter.  I was going to not worry about this problem, and let people fault the additional options in as necessary.

Also, any time there are target options, it is easy to miss adding the flag to the other dg-options lines and have them by caught by your test suite runs, but I checked and you seemed to have correctly edited them, though I only spot checked.