From: Alan Hayward <Alan.Hayward@arm.com>
To: Kilian Verhetsel <kilian.verhetsel@uclouvain.be>
Cc: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>
Subject: Re: [PATCH] Fix result for conditional reductions matching at index 0
Date: Thu, 23 Nov 2017 10:30:00 -0000 [thread overview]
Message-ID: <2E74E2B4-E89F-4B6E-95DB-8733A912AF2C@arm.com> (raw)
In-Reply-To: <87wp2ib6aj.fsf@uclouvain.be>
> On 22 Nov 2017, at 16:57, Kilian Verhetsel <kilian.verhetsel@uclouvain.be> wrote:
>
>
> Thank you both for your comments.
>
> I have added the check to ensure the index vector won't cause an
> overflow. I also added tests to the testsuite in order to check that the
> loop is vectorized for UINT_MAX - 1 iterations but not UINT_MAX
> iterations. I was not able to write code that triggers
> INTEGER_INDUC_COND_REDUCTION when using char or other smaller types
> (changing the types of last, min_v and a to something else causes
> COND_REDUCTION to be used instead), so these tests are only compiled and
> not executed.
I had similar problems when playing around with -14.c, but didn’t have chance to
investigate why. Possibly worth raising a bug to mentioning there is a missed
optimisation. It’d be nice to figure out why.
>
> I also moved an instruction that generates a vector of zeroes (used for
> COND_REDUCTION) in the branch of code run only for COND_REDUCTION, this
> should remove the unused vector that Alan noticed.
Patch is ok for me.
Alan.
next prev parent reply other threads:[~2017-11-23 9:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 11:41 Kilian Verhetsel
2017-11-21 14:06 ` Richard Biener
2017-11-21 16:49 ` Kilian Verhetsel
2017-11-21 17:09 ` Alan Hayward
2017-11-22 9:17 ` Richard Biener
2017-11-22 11:15 ` Alan Hayward
2017-11-22 15:07 ` Richard Biener
2017-11-22 17:23 ` Kilian Verhetsel
2017-11-23 10:30 ` Alan Hayward [this message]
2017-11-23 12:39 ` Richard Biener
2017-12-08 18:15 ` Jakub Jelinek
2017-12-11 10:57 ` Kilian Verhetsel
2017-12-11 13:11 ` Jakub Jelinek
2017-12-11 13:51 ` Jakub Jelinek
2017-12-11 17:00 ` Kilian Verhetsel
2017-12-11 17:06 ` Jakub Jelinek
2017-12-11 21:22 ` [PATCH] Fix result for conditional reductions matching at index 0 (PR tree-optimization/80631) Jakub Jelinek
2017-12-12 7:57 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E74E2B4-E89F-4B6E-95DB-8733A912AF2C@arm.com \
--to=alan.hayward@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kilian.verhetsel@uclouvain.be \
--cc=nd@arm.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).