From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31869 invoked by alias); 7 May 2015 18:07:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31857 invoked by uid 89); 7 May 2015 18:07:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: resqmta-po-01v.sys.comcast.net Received: from resqmta-po-01v.sys.comcast.net (HELO resqmta-po-01v.sys.comcast.net) (96.114.154.160) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 07 May 2015 18:07:18 +0000 Received: from resomta-po-07v.sys.comcast.net ([96.114.154.231]) by resqmta-po-01v.sys.comcast.net with comcast id R67D1q00F4zp9eg0167FsZ; Thu, 07 May 2015 18:07:15 +0000 Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d]) by resomta-po-07v.sys.comcast.net with comcast id R67C1q0022ztT3H0167DSe; Thu, 07 May 2015 18:07:14 +0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [libgomp, testsuite] Support parallel testing in libgomp (PR libgomp/66005) From: Mike Stump In-Reply-To: <20150507113940.GI1751@tucnak.redhat.com> Date: Thu, 07 May 2015 18:07:00 -0000 Cc: Rainer Orth , Thomas Schwinge , gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <2ED14F3A-FC4A-4BA8-9AEE-64FB8A62C9C0@comcast.net> References: <20150507113940.GI1751@tucnak.redhat.com> To: Jakub Jelinek X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00580.txt.bz2 On May 7, 2015, at 4:39 AM, Jakub Jelinek wrote: > On Thu, May 07, 2015 at 01:26:57PM +0200, Rainer Orth wrote: >> As reported in the PR, with the addition of all those OpenACC tests, >> libgomp make check times have skyrocketed since the testsuite is still >> run sequentially. >>=20 >> Even on a reasonably fast x86 machine (4 x 2.0 Ghz Xeon E7450) the run >> takes 4286 seconds. >>=20 >> On slower sparc boxes (1.2 GHz UltraSPARC-T2) we're at 29406 seconds, >> compared to 7825 seconds on the 4.9 branch. >>=20 >> Thus, the libgomp tests massively slow down the whole testsuite run, >> being the last part to finish. >>=20 >> Fixing this proved trivial: I managed to almost literally copy the >> solution from libstdc++-v3/testsuite/Makefile.am, with a minimal change >> to libgomp.exp so the generated libgomp-test-support.exp file is found >> in both the sequential and parallel cases. This isn't an issue in >> libstdc++ since all necessary variables are stored in a single >> site.exp. >=20 > It is far from trivial though. > The point is that most of the OpenMP tests are parallelized with the > default OMP_NUM_THREADS, so running the tests in parallel oversubscribes = the > machine a lot If OpenMP cannot keep the machine busy, then the test suite should. A 15x = speed up means that OpenMP cannot keep the machine busy. I=92d not expect = OpenMP to fill the gap here, so that leave just the test suite. So, unless= someone wants to try their hand at getting some serious time from OpenMP, = I think the patch lies on the path of goodness.