* omit frame pointer in pr89676
@ 2021-04-27 15:35 Alexandre Oliva
2021-04-27 17:13 ` Uros Bizjak
2021-04-27 20:26 ` Jeff Law
0 siblings, 2 replies; 3+ messages in thread
From: Alexandre Oliva @ 2021-04-27 15:35 UTC (permalink / raw)
To: gcc-patches; +Cc: Rainer Orth, Mike Stump, Jan Hubicka, Uros Bizjak
This i386 test expects only two movl instructions.
In configurations that --enable-frame-pointer, -O2 won't implicitly
enable -fomit-frame-pointer, so we end up with a third movl to set up
the frame pointer.
This patch enables -fomit-frame-pointer explicitly, so that the result
no longer depends on that configuration option.
Regstrapped on x86_64-linux-gnu, also tested with a cross to x86-vx7r2.
Ok to install?
for gcc/testsuite/ChangeLog
* gcc.target/i386/pr89676.c: Add -fomit-frame-pointer.
---
gcc/testsuite/gcc.target/i386/pr89676.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/i386/pr89676.c b/gcc/testsuite/gcc.target/i386/pr89676.c
index 164a9da468046..7afa1a1778d71 100644
--- a/gcc/testsuite/gcc.target/i386/pr89676.c
+++ b/gcc/testsuite/gcc.target/i386/pr89676.c
@@ -1,6 +1,6 @@
/* PR rtl-optimization/89676 */
/* { dg-do compile { target ia32 } } */
-/* { dg-options "-O2 -mno-stv" } */
+/* { dg-options "-O2 -mno-stv -fomit-frame-pointer" } */
unsigned long long
foo (unsigned long long i)
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: omit frame pointer in pr89676
2021-04-27 15:35 omit frame pointer in pr89676 Alexandre Oliva
@ 2021-04-27 17:13 ` Uros Bizjak
2021-04-27 20:26 ` Jeff Law
1 sibling, 0 replies; 3+ messages in thread
From: Uros Bizjak @ 2021-04-27 17:13 UTC (permalink / raw)
To: Alexandre Oliva; +Cc: gcc-patches, Rainer Orth, Mike Stump, Jan Hubicka
On Tue, Apr 27, 2021 at 5:35 PM Alexandre Oliva <oliva@adacore.com> wrote:
>
>
> This i386 test expects only two movl instructions.
>
> In configurations that --enable-frame-pointer, -O2 won't implicitly
> enable -fomit-frame-pointer, so we end up with a third movl to set up
> the frame pointer.
>
> This patch enables -fomit-frame-pointer explicitly, so that the result
> no longer depends on that configuration option.
>
> Regstrapped on x86_64-linux-gnu, also tested with a cross to x86-vx7r2.
> Ok to install?
OK.
Thanks,
Uros.
>
> for gcc/testsuite/ChangeLog
>
> * gcc.target/i386/pr89676.c: Add -fomit-frame-pointer.
> ---
> gcc/testsuite/gcc.target/i386/pr89676.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr89676.c b/gcc/testsuite/gcc.target/i386/pr89676.c
> index 164a9da468046..7afa1a1778d71 100644
> --- a/gcc/testsuite/gcc.target/i386/pr89676.c
> +++ b/gcc/testsuite/gcc.target/i386/pr89676.c
> @@ -1,6 +1,6 @@
> /* PR rtl-optimization/89676 */
> /* { dg-do compile { target ia32 } } */
> -/* { dg-options "-O2 -mno-stv" } */
> +/* { dg-options "-O2 -mno-stv -fomit-frame-pointer" } */
>
> unsigned long long
> foo (unsigned long long i)
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: omit frame pointer in pr89676
2021-04-27 15:35 omit frame pointer in pr89676 Alexandre Oliva
2021-04-27 17:13 ` Uros Bizjak
@ 2021-04-27 20:26 ` Jeff Law
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Law @ 2021-04-27 20:26 UTC (permalink / raw)
To: Alexandre Oliva, gcc-patches; +Cc: Jan Hubicka
On 4/27/2021 9:35 AM, Alexandre Oliva wrote:
> This i386 test expects only two movl instructions.
>
> In configurations that --enable-frame-pointer, -O2 won't implicitly
> enable -fomit-frame-pointer, so we end up with a third movl to set up
> the frame pointer.
>
> This patch enables -fomit-frame-pointer explicitly, so that the result
> no longer depends on that configuration option.
>
> Regstrapped on x86_64-linux-gnu, also tested with a cross to x86-vx7r2.
> Ok to install?
>
>
> for gcc/testsuite/ChangeLog
>
> * gcc.target/i386/pr89676.c: Add -fomit-frame-pointer.
OK
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-27 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 15:35 omit frame pointer in pr89676 Alexandre Oliva
2021-04-27 17:13 ` Uros Bizjak
2021-04-27 20:26 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).