public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: "Arsen Arsenović" <arsen@aarsen.me>,
	"Jonathan Wakely" <jwakely.gcc@gmail.com>,
	gcc-patches@gcc.gnu.org
Cc: "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>,
	Jakub Jelinek <jakub@redhat.com>,
	"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: Handling of main() function for freestanding
Date: Thu, 13 Oct 2022 13:24:41 -0400	[thread overview]
Message-ID: <2a959ba5-e9a3-768b-2d66-cba2bc389eca@redhat.com> (raw)
In-Reply-To: <16718001.dR7co8bJll@bstg>

On 10/13/22 13:02, Arsen Arsenović wrote:
> Hi,
> 
> On Friday, 7 October 2022 15:51:31 CEST Jason Merrill wrote:
>>> 	* gcc.dg/noreturn-4.c: Likewise.
>>
>> I'd be inclined to drop this test.
> That seems like an odd choice, why do that over using another function
> for the test case? (there's nothing specific to main in this test, and
> it doesn't even need to link, so using any ol' function should be okay;
> see attachment)

It seemed to me that the test was specifically checking that main was 
treated like any other function when freestanding.

> The attached patch is also v2 of the original builtin-main one submitted
> earlier.  Tested on x86_64-pc-linux-gnu.  This revision excludes the
> mentioned pedwarns unless hosted.

I was arguing that we don't need the new flag; there shouldn't be any 
need to turn it off.

Jason


  parent reply	other threads:[~2022-10-13 17:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAH6eHdRr2uYW=Q8BKvhx472LXkT+nCKQg4uYAETNCs+b=YY7GA@mail.gmail.com>
     [not found] ` <CAH6eHdSWbgYy2qaneHyeEMAVLhkgZGjjtoRO4D5Dy5HOfmP95Q@mail.gmail.com>
     [not found]   ` <2489d88a-e80b-2f89-bac5-07c0b70bc175@redhat.com>
2022-10-13 17:03     ` Arsen Arsenović
2022-10-13 17:10       ` Jakub Jelinek
2022-10-13 17:26         ` Arsen Arsenović
2022-10-13 17:24       ` Jason Merrill [this message]
2022-10-13 20:14         ` Arsen Arsenović
2022-10-13 21:16           ` Jason Merrill
2022-10-14 10:04             ` Arsen Arsenović
2022-10-14 15:17               ` Jason Merrill
2022-10-21 10:33               ` Ping (c,c++): " Arsen Arsenović
2022-10-21 21:02                 ` Joseph Myers
2022-10-23 11:54                   ` Arsen Arsenović
2022-10-24 13:46                     ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a959ba5-e9a3-768b-2d66-cba2bc389eca@redhat.com \
    --to=jason@redhat.com \
    --cc=arsen@aarsen.me \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=jwakely.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).