From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 96AA53857C7A for ; Fri, 10 Dec 2021 21:20:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96AA53857C7A Received: by mail-il1-x12f.google.com with SMTP id s11so9653804ilv.3 for ; Fri, 10 Dec 2021 13:20:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=K3hkR4JoXJc77K0mHVbQkyRQfNs1kb5Dsc1TSmT5yoQ=; b=ubv8V6Og0AjCyQBltVkESKf6QMhyGpvUTcI209/0b+PaRntoTozKVlkhOfTsSueqSh 3OCv5Mx3bhUYy+miIpEOqlQR/ZybqzwdFm9wW40KZ//CwShKiX20KMN3ot/PXt97peto DjDzTxYiGv3cs+Kd6el0vVJomSfTNkz7Qd+nZZhJvNCVdY+X318JYbrws/F5KwB7INZJ GoG8pOCjkOyvizHhYVp653CDP1MAGaHT6wqivRiKlQVDok3qpsdvFjNJywBPRb5c1uX/ oowKz5crVa/cIXFg4AowOqb0hfu3hSL2KO5KGO5hdGmF5vDhQMRnym4IoO2MyUgjylI4 pVKw== X-Gm-Message-State: AOAM5335MWTI5RfefgMP9iPz1S95InMU3+nSEV3Drk0d0U1lSd3q9lXW 8/8J/G6MAk71j90n1WDvjCA= X-Google-Smtp-Source: ABdhPJw5YYvn2v6/58AZWQpV4bK/9btdAbqaHpVd3VUtd6UkuvnE4JspsegrfZx0YEVb7mvkgdQdSQ== X-Received: by 2002:a05:6e02:160e:: with SMTP id t14mr22257635ilu.16.1639171249971; Fri, 10 Dec 2021 13:20:49 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id 11sm2585930ilt.63.2021.12.10.13.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 13:20:49 -0800 (PST) Message-ID: <2acacc22-09db-16e0-de50-b79f118f8a81@gmail.com> Date: Fri, 10 Dec 2021 14:20:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH] pch: Small cleanup Content-Language: en-US To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <20211207095507.GV2646553@tucnak> <20211207145007.GX2646553@tucnak> <20211209145940.GI2646553@tucnak> <20211209165954.GJ2646553@tucnak> <20211210125613.GO2646553@tucnak> From: Jeff Law In-Reply-To: <20211210125613.GO2646553@tucnak> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 21:20:52 -0000 On 12/10/2021 5:56 AM, Jakub Jelinek wrote: > On Thu, Dec 09, 2021 at 05:59:54PM +0100, Jakub Jelinek via Gcc-patches wrote: >>> /tmp/6140018_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/config/aarch64/aarch64-sve-builtins.cc:3920:0: >>> ./gt-aarch64-sve-builtins.h: In function 'void >>> gt_pch_p_19registered_function(void*, void*, gt_pointer_operator, void*)': >>> ./gt-aarch64-sve-builtins.h:86:44: error: no matching function for call to >>> 'gt_pch_nx(aarch64_sve::function_instance*, void (*&)(void*, void*, void*), >>> void*&)' >>> gt_pch_nx (&((*x).instance), op, cookie); >> Fixed thusly, compile tested on x86_64-linux, committed to trunk. > Here is a small cleanup. IMHO we should use gt_pointer_operator instead of > specifying manually void (*) (void *, void *) or > void (*) (void *, void *, void *) so that next time we want to change it, > we don't have to trace all the spots. I was afraid it wouldn't work due to > header dependencies, but it works well. gengtype generated files also > use gt_pointer_operator. > > Ok for trunk (tested on x86_64-linux and cross to aarch64-linux)? > > 2021-12-10 Jakub Jelinek > > * machmode.h (gt_pch_nx): Use gt_pointer_operator as type of second > argument instead of equivalent void (*) (void *, void *, void *). > * poly-int.h (gt_pch_nx): Likewise. > * wide-int.h (gt_pch_nx): Likewise. > * config/aarch64/aarch64-sve-builtins.cc (gt_pch_nx): Likewise. OK jeff