From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 9CEA43858D20 for ; Thu, 10 Aug 2023 12:33:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CEA43858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-52164adea19so1069915a12.1 for ; Thu, 10 Aug 2023 05:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691670819; x=1692275619; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eDhYLNBMtpnLHx2fsGSZpRHkUU1W06WAaJ2axal5ocI=; b=RIYudB44SR6KCzGO3pHduZ6pQ0/WAtC8qdBaZU1LjxSSqsFsRINdgPhWcXuUj6a9iz ftLmcGCG1rpEIzn+g0ruOlw7C3ctoPNDi8P9PvBXqwI7mF6MQ1gTl4g1VtJM30D6cB5S itGU573ozdkvgfb0c+zirwRVugZLIBIu+wPf8zg5OFkTMRCDbgaLNq+fd7CXifgexUjL k9y17B8jLcGwMetVqP3w6EKchbDBNi4P7KlBjDWMkgFvjNz6XRsTMHHjckq2hFzhPcL0 TG51YxE02Ps6l9KpzxblpvSgC2V3A/v+1XpyPSmLsc1FzQvP/DWu20Siz1+1vOQ2oW5x eAqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691670819; x=1692275619; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eDhYLNBMtpnLHx2fsGSZpRHkUU1W06WAaJ2axal5ocI=; b=J06pCi4Bc8ALBIWqCgrjDAdmIf7N5CapGI4dY5wqySlXdxzwKfRHmxhTpRG6GDgX+l V6f8iFIBm0wEroDXX1gZ8Gce51YdjAZkiS0lh8Tk02uYuIdsHgoo0VYQskHoD6wVtfx+ gzaWKd10kPiVPd+KYdh8IHXscbej//vAvgRTwF7ff6hbXAxmA0YFgoz6x6FBk0PCJl/c vBGLRVgtlwfA6Jn/FhCAA7iLbQChvKZkf24XA6bhD0FNC2gPzk6qa2/wYeStD2RConvK cYlf6vXzqrdRn8ZFCa22ROsrT3THRKGFuZ6Y9TmgiTk3Dkgmvi9E3LXx8mgFApK8oToU Amuw== X-Gm-Message-State: AOJu0Yy4DxA9p/XJmdEYOpupf//6DFnLM2YgCwb3tW37yakbd7+4L0Tc +M69v9IsG9BS58+V7mYmqDU= X-Google-Smtp-Source: AGHT+IFkX8zXIsTGTn4K55lHzSMh6J5drvGfe0S7gZ6qvipw08FIZmyeGp/EETbvxe4oUgtQ31d2Kg== X-Received: by 2002:aa7:d8cf:0:b0:522:1fd1:1035 with SMTP id k15-20020aa7d8cf000000b005221fd11035mr1863097eds.6.1691670819042; Thu, 10 Aug 2023 05:33:39 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id r6-20020aa7cfc6000000b0052275deb475sm747932edy.23.2023.08.10.05.33.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Aug 2023 05:33:38 -0700 (PDT) Message-ID: <2ad79047-6404-2a92-4af4-92aeae84cfbd@gmail.com> Date: Thu, 10 Aug 2023 14:33:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: rdapp.gcc@gmail.com, gcc-patches , "richard.sandiford" Subject: Re: [PATCH V2] VECT: Support loop len control on EXTRACT_LAST vectorization Content-Language: en-US To: Richard Biener , "juzhe.zhong@rivai.ai" References: <20230810074909.492039-1-juzhe.zhong@rivai.ai> <5E5A5DF866F60714+2023081019384780401345@rivai.ai> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Hmm, I think VEC_EXTRACT and VEC_SET should be ECF_CONST. Maybe the > GIMPLE ISEL > comments do not match the implementation, but then that should be fixed? > > /* Expand all ARRAY_REF(VIEW_CONVERT_EXPR) gimple assignments into calls > to > internal function based on vector type of selected expansion. > > For vec_set: > > VIEW_CONVERT_EXPR(u)[_1] = i_4(D); > => > _7 = u; > _8 = .VEC_SET (_7, i_4(D), _1); > u = _8; > > For vec_extract: > > _3 = VIEW_CONVERT_EXPR(vD.2208)[idx_2(D)]; > => > _4 = vD.2208; > _3 = .VEC_EXTRACT (_4, idx_2(D)); */ > I probably just forgot to set ECF_CONST in the recent isel patch for vec_extract. Regards Robin