From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id D64933858013 for ; Thu, 23 Nov 2023 14:58:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D64933858013 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D64933858013 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700751513; cv=none; b=om9vSpVlf3O9mncJKMgTxMfUG1i9DwKbQF3AJg9yc3pbpmzF1JUDoaa6TBbT7UJVdevtQXuWN/K/rv+8I/bdYkfxED3iYcFIRafA9AufLCloC8EadzaDLWv5Sr6FYiAcoDei84Msv8TmZNFf4MHZQIvO9EdbmPEAADXneAQRzss= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700751513; c=relaxed/simple; bh=U3car8MlBLX0wHeeuajSv+6p8HbNkVJ9eAXxTyDfp0s=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Xkw4i8wbYrBVa/X0ilofh5lqbwfGReaoZmnLmYtBtus1ijjHM7N+MXLitBexYX0dQrhXGojyIw/9m9jOOPjl/ypbbI+305uE0Q9tyzoLyzFZJN4hZqvASDaJbHRE9s1WIbLJjcA6aAz4XSg66FpEP3VyhDC7fIeELuKQWauqhDg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a00b01955acso139101366b.1 for ; Thu, 23 Nov 2023 06:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700751509; x=1701356309; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QsRxpLqnvkBu8JP/TSx0ntaYwNq9G6bNYPIUS3r+Uf4=; b=KYpKrzr6cGTR8HySTOcRCP4pvaQAp0ZqCgRjgpsCRk4JozG6ez1Vfb7P3v5NdOOLsJ xK3bflz6PunGGPRn88vNZD4T2Ki3BZzafwxQurEhJiLyKDs7adKhDtzVJ2ldPjCdbIUv hRobVNddVpwZ85PWSqlqinrO0BHKnIeOKvYTR5Ba7lVL0RZGwyVd78p2qEdElMzKlevE 6iGtrbdMj03qC7MrbTIpgdRM09u0kA1Flb6wpPKaMvymq46MGImCp/Rut/WnGlNvYR2b O02XgdFppRXxYrNKk94aSGzeyjKog1zA6psRPEkRpu0g7thjRoPQyh6FmrKJc5zVsDnY D0HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700751509; x=1701356309; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QsRxpLqnvkBu8JP/TSx0ntaYwNq9G6bNYPIUS3r+Uf4=; b=vyNBoC4IQu1xiwL8jaAVvdMVfz5B0CYbqkc2JviJnn1uY/1pmeCOdfn7+LDofndyGt cMvSFtReKiBQ3ZsDK7wUF/HFXvsWAHNhgz9VEPyovs+Fs8vHSIXMTWVWf6YnrDeGfetq +rgjp6U9j8XOHr1yX2/aedpfI71g2pwyg+K+YaiY4E1Kd5H7XFoRTRqCUw+ER1bdAHmf cpRlOW4TTiG9DzjEhXC/7hbtbPsPmZO76nmXwmm3w/toOfLOdod+XYSFxsR4WDsZ5wR2 KPHmTihb1u40KY4pMBKjSzW8nYozXPIJ91T+rx/6A3t8c5/+S2AP+0mErnHAv0NML2IJ MPGQ== X-Gm-Message-State: AOJu0YzOVyrISInEIO9z5VXjGl0YUcgLSCiMxDKKtEDC84/yayhmSnLa 4d/v3DRxRR8iFlF3S+ebdLE= X-Google-Smtp-Source: AGHT+IFWTWgbg5lDBG933OMlQ35J52+Zivniw+ZpOwiJ8kjWOJ+0kfUMnvJeTBMC3o1LmyEB0dWCPg== X-Received: by 2002:a17:906:71c5:b0:9e3:f97b:239e with SMTP id i5-20020a17090671c500b009e3f97b239emr4245684ejk.29.1700751509338; Thu, 23 Nov 2023 06:58:29 -0800 (PST) Received: from [192.168.1.23] (ip-046-223-203-173.um13.pools.vodafone-ip.de. [46.223.203.173]) by smtp.gmail.com with ESMTPSA id gl20-20020a170906e0d400b009cc1e8ed7c5sm878157ejb.133.2023.11.23.06.58.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 06:58:29 -0800 (PST) Message-ID: <2ae043b9-d5c8-43e4-a56e-324237f10a68@gmail.com> Date: Thu, 23 Nov 2023 15:58:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com, jeffreyalaw@gmail.com Subject: Re: [PATCH] RISC-V: Optimize a special case of VLA SLP Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org References: <20231123125910.1889955-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: <20231123125910.1889955-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM (and harmless enough) but I'd rather wait for a second look or a maintainer's OK as we're past stage 1 and it's not a real bugfix. (On top, it's Thanksgiving so not many people will even notice). On a related note, this should probably be a middle-end optimization but before a variable-index vec extract most likely nobody bothered. Regards Robin